coreboot October 2007

coreboot@coreboot.org

84 participants
481 discussions

[LinuxBIOS] r2864 - trunk/util/flashrom
by svn＠openbios.org 16 Oct '07

16 Oct '07

Author: hailfinger Date: 2007-10-16 23:18:43 +0200 (Tue, 16 Oct 2007) New Revision: 2864 Modified: trunk/util/flashrom/README trunk/util/flashrom/board_enable.c Log: Add Gigabyte M61P-S3 SPI flash support to board_enable.c Signed-off-by: Michael van der Kolff <mvanderkolff(a)gmail.com> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/util/flashrom/README =================================================================== --- trunk/util/flashrom/README 2007-10-16 21:09:06 UTC (rev 2863) +++ trunk/util/flashrom/README 2007-10-16 21:18:43 UTC (rev 2864) @@ -55,8 +55,9 @@ * ASUS P5A: use -m asus:p5a * IBM x3455: use -m ibm:x3455 * EPoX EP-BX3: use -m epox:ep-bx3 +* GIGABYTE GA-M57SLI v2.0: use -m gigabyte:m57sli +* GIGABYTE GA-M61P-S3: use -m gigabyte:m61ps3 - ROM Layout Support ------------------ Modified: trunk/util/flashrom/board_enable.c =================================================================== --- trunk/util/flashrom/board_enable.c 2007-10-16 21:09:06 UTC (rev 2863) +++ trunk/util/flashrom/board_enable.c 2007-10-16 21:18:43 UTC (rev 2864) @@ -356,6 +356,8 @@ struct board_pciid_enable board_pciid_enables[] = { {0x10de, 0x0360, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, "gigabyte", "m57sli", "GIGABYTE GA-M57SLI", it87xx_probe_spi_flash}, + {0x10de, 0x03e0, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, + "gigabyte", "m61ps3", "GIGABYTE GA-M61P-S3", it87xx_probe_spi_flash}, {0x1022, 0x7468, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, "iwill", "dk8_htx", "IWILL DK8-HTX", w83627hf_gpio24_raise_2e}, {0x10de, 0x005e, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000,

1 0

[LinuxBIOS] [PATCH] flashrom: better abstraction for SPI functions
by Carl-Daniel Hailfinger 16 Oct '07

16 Oct '07

Convert the existing it8716f_* functions to generic_spi_* functions by applying abstraction and wrapping. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> --- Index: util/flashrom/flash.h =================================================================== --- util/flashrom/flash.h (Revision 2862) +++ util/flashrom/flash.h (Arbeitskopie) @@ -209,7 +209,7 @@ /* spi.c */ int probe_spi(struct flashchip *flash); -int it87xx_probe_serial_flash(const char *name); +int it87xx_probe_spi_flash(const char *name); /* 82802ab.c */ int probe_82802ab(struct flashchip *flash); Index: util/flashrom/spi.c =================================================================== --- util/flashrom/spi.c (Revision 2862) +++ util/flashrom/spi.c (Arbeitskopie) @@ -68,7 +68,7 @@ regwrite(port, 0x02, 0x02); } -static uint16_t find_ite_serial_flash_port(uint16_t port) +static uint16_t find_ite_spi_flash_port(uint16_t port) { uint8_t tmp = 0; uint16_t id, flashport = 0; @@ -102,6 +102,14 @@ return flashport; } +int it87xx_probe_spi_flash(const char *name) +{ + it8716f_flashport = find_ite_spi_flash_port(ITE_SUPERIO_PORT1); + if (!it8716f_flashport) + it8716f_flashport = find_ite_spi_flash_port(ITE_SUPERIO_PORT2); + return (!it8716f_flashport); +} + /* The IT8716F only supports commands with length 1,2,4,5 bytes including command byte and can not read more than 3 bytes from the device. This function expects writearr[0] to be the first byte sent to the device, @@ -162,31 +170,30 @@ return 0; } -static int it8716f_serial_rdid(uint16_t port, unsigned char *readarr) +static int generic_spi_command(unsigned char writecnt, unsigned char readcnt, const unsigned char *writearr, unsigned char *readarr) { + if (it8716f_flashport) + return it8716f_spi_command(it8716f_flashport, writecnt, readcnt, writearr, readarr); + printf("%s called, but no SPI chipset detected\n", __FUNCTION__); + return 1; +} + +static int generic_spi_rdid(unsigned char *readarr) +{ const unsigned char cmd[] = JEDEC_RDID; - if (it8716f_spi_command(port, JEDEC_RDID_OUTSIZE, JEDEC_RDID_INSIZE, cmd, readarr)) + if (generic_spi_command(JEDEC_RDID_OUTSIZE, JEDEC_RDID_INSIZE, cmd, readarr)) return 1; printf("RDID returned %02x %02x %02x\n", readarr[0], readarr[1], readarr[2]); return 0; } -int it87xx_probe_serial_flash(const char *name) -{ - it8716f_flashport = find_ite_serial_flash_port(ITE_SUPERIO_PORT1); - if (!it8716f_flashport) - it8716f_flashport = find_ite_serial_flash_port(ITE_SUPERIO_PORT2); - return (!it8716f_flashport); -} - int probe_spi(struct flashchip *flash) { unsigned char readarr[3]; uint8_t manuf_id; uint16_t model_id; - if (it8716f_flashport) { - it8716f_serial_rdid(it8716f_flashport, readarr); + if (!generic_spi_rdid(readarr)) { manuf_id = readarr[0]; model_id = (readarr[1] << 8) | readarr[2]; printf_debug("%s: id1 0x%x, id2 0x%x\n", __FUNCTION__, manuf_id, model_id); Index: util/flashrom/board_enable.c =================================================================== --- util/flashrom/board_enable.c (Revision 2862) +++ util/flashrom/board_enable.c (Arbeitskopie) @@ -355,7 +355,7 @@ struct board_pciid_enable board_pciid_enables[] = { {0x10de, 0x0360, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, - "gigabyte", "m57sli", "GIGABYTE GA-M57SLI", it87xx_probe_serial_flash}, + "gigabyte", "m57sli", "GIGABYTE GA-M57SLI", it87xx_probe_spi_flash}, {0x1022, 0x7468, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, "iwill", "dk8_htx", "IWILL DK8-HTX", w83627hf_gpio24_raise_2e}, {0x10de, 0x005e, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000,

2 2

[LinuxBIOS] r2863 - trunk/util/flashrom
by svn＠openbios.org 16 Oct '07

16 Oct '07

Author: hailfinger Date: 2007-10-16 23:09:06 +0200 (Tue, 16 Oct 2007) New Revision: 2863 Modified: trunk/util/flashrom/board_enable.c trunk/util/flashrom/flash.h trunk/util/flashrom/spi.c Log: Convert the existing it8716f_* functions to generic_spi_* functions by applying abstraction and wrapping. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/util/flashrom/board_enable.c =================================================================== --- trunk/util/flashrom/board_enable.c 2007-10-16 18:21:22 UTC (rev 2862) +++ trunk/util/flashrom/board_enable.c 2007-10-16 21:09:06 UTC (rev 2863) @@ -355,7 +355,7 @@ struct board_pciid_enable board_pciid_enables[] = { {0x10de, 0x0360, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, - "gigabyte", "m57sli", "GIGABYTE GA-M57SLI", it87xx_probe_serial_flash}, + "gigabyte", "m57sli", "GIGABYTE GA-M57SLI", it87xx_probe_spi_flash}, {0x1022, 0x7468, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, "iwill", "dk8_htx", "IWILL DK8-HTX", w83627hf_gpio24_raise_2e}, {0x10de, 0x005e, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, Modified: trunk/util/flashrom/flash.h =================================================================== --- trunk/util/flashrom/flash.h 2007-10-16 18:21:22 UTC (rev 2862) +++ trunk/util/flashrom/flash.h 2007-10-16 21:09:06 UTC (rev 2863) @@ -209,7 +209,7 @@ /* spi.c */ int probe_spi(struct flashchip *flash); -int it87xx_probe_serial_flash(const char *name); +int it87xx_probe_spi_flash(const char *name); /* 82802ab.c */ int probe_82802ab(struct flashchip *flash); Modified: trunk/util/flashrom/spi.c =================================================================== --- trunk/util/flashrom/spi.c 2007-10-16 18:21:22 UTC (rev 2862) +++ trunk/util/flashrom/spi.c 2007-10-16 21:09:06 UTC (rev 2863) @@ -68,7 +68,7 @@ regwrite(port, 0x02, 0x02); } -static uint16_t find_ite_serial_flash_port(uint16_t port) +static uint16_t find_ite_spi_flash_port(uint16_t port) { uint8_t tmp = 0; uint16_t id, flashport = 0; @@ -102,6 +102,14 @@ return flashport; } +int it87xx_probe_spi_flash(const char *name) +{ + it8716f_flashport = find_ite_spi_flash_port(ITE_SUPERIO_PORT1); + if (!it8716f_flashport) + it8716f_flashport = find_ite_spi_flash_port(ITE_SUPERIO_PORT2); + return (!it8716f_flashport); +} + /* The IT8716F only supports commands with length 1,2,4,5 bytes including command byte and can not read more than 3 bytes from the device. This function expects writearr[0] to be the first byte sent to the device, @@ -162,31 +170,30 @@ return 0; } -static int it8716f_serial_rdid(uint16_t port, unsigned char *readarr) +static int generic_spi_command(unsigned char writecnt, unsigned char readcnt, const unsigned char *writearr, unsigned char *readarr) { + if (it8716f_flashport) + return it8716f_spi_command(it8716f_flashport, writecnt, readcnt, writearr, readarr); + printf("%s called, but no SPI chipset detected\n", __FUNCTION__); + return 1; +} + +static int generic_spi_rdid(unsigned char *readarr) +{ const unsigned char cmd[] = JEDEC_RDID; - if (it8716f_spi_command(port, JEDEC_RDID_OUTSIZE, JEDEC_RDID_INSIZE, cmd, readarr)) + if (generic_spi_command(JEDEC_RDID_OUTSIZE, JEDEC_RDID_INSIZE, cmd, readarr)) return 1; printf("RDID returned %02x %02x %02x\n", readarr[0], readarr[1], readarr[2]); return 0; } -int it87xx_probe_serial_flash(const char *name) -{ - it8716f_flashport = find_ite_serial_flash_port(ITE_SUPERIO_PORT1); - if (!it8716f_flashport) - it8716f_flashport = find_ite_serial_flash_port(ITE_SUPERIO_PORT2); - return (!it8716f_flashport); -} - int probe_spi(struct flashchip *flash) { unsigned char readarr[3]; uint8_t manuf_id; uint16_t model_id; - if (it8716f_flashport) { - it8716f_serial_rdid(it8716f_flashport, readarr); + if (!generic_spi_rdid(readarr)) { manuf_id = readarr[0]; model_id = (readarr[1] << 8) | readarr[2]; printf_debug("%s: id1 0x%x, id2 0x%x\n", __FUNCTION__, manuf_id, model_id);

1 0

[LinuxBIOS] r507 - LinuxBIOSv3/device
by svn＠openbios.org 16 Oct '07

16 Oct '07

Author: hailfinger Date: 2007-10-16 21:29:34 +0200 (Tue, 16 Oct 2007) New Revision: 507 Modified: LinuxBIOSv3/device/device_util.c Log: Add resource size and resource granularity reporting to device_util.c. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: LinuxBIOSv3/device/device_util.c =================================================================== --- LinuxBIOSv3/device/device_util.c 2007-10-16 18:59:36 UTC (rev 506) +++ LinuxBIOSv3/device/device_util.c 2007-10-16 19:29:34 UTC (rev 507) @@ -601,11 +601,11 @@ sprintf(buf, "bus %02x ", dev->link[0].secondary); #endif } - printk(BIOS_DEBUG, - "%s %02lx <- [0x%010llx - 0x%010llx] %s%s%s\n", - dev_path(dev), - resource->index, - base, end, buf, resource_type(resource), comment); + printk(BIOS_DEBUG, "%s %02lx <- [0x%010llx - 0x%010llx] " + "size 0x%08Lx gran 0x%02x %s%s%s\n", + dev_path(dev), resource->index, base, end, + resource->size, resource->gran, buf, + resource_type(resource), comment); } }

1 0

[LinuxBIOS] r2861 build service
by LinuxBIOS information 16 Oct '07

16 Oct '07

Dear LinuxBIOS readers! This is the automated build check service of LinuxBIOS. The developer "uwe" checked in revision 2861 to the LinuxBIOS source repository and caused the following changes: Change Log: Fix the detection for the Winbond W83697SF. Unfortunately the revision has a slightly different format than that of the W83697UF/UG so we have to hack around it a bit. This patch has been verified to work on real hardware by Idwer Vollering <idwer_v(a)hotmail.com> on IRC (thanks!). Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Ronald G. Minnich <rminnich(a)gmail.com> Build Log: Compilation of arima:hdama is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2861&device=hdama&vendor=… Configuration of bcom:winnet100 is still broken Compilation of ibm:e325 is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2861&device=e325&vendor=i… Compilation of ibm:e326 is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2861&device=e326&vendor=i… Compilation of iei:juki-511p is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2861&device=juki-511p&ven… Compilation of iwill:dk8s2 is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2861&device=dk8s2&vendor=… Compilation of iwill:dk8x is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2861&device=dk8x&vendor=i… Compilation of newisys:khepri is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2861&device=khepri&vendor… If something broke during this checkin please be a pain in uwe's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, LinuxBIOS automatic build system

1 0

[LinuxBIOS] r506 - in LinuxBIOSv3: arch/x86 include lib util/lar
by svn＠openbios.org 16 Oct '07

16 Oct '07

Author: hailfinger Date: 2007-10-16 20:59:36 +0200 (Tue, 16 Oct 2007) New Revision: 506 Modified: LinuxBIOSv3/arch/x86/stage1.c LinuxBIOSv3/include/lar.h LinuxBIOSv3/lib/lar.c LinuxBIOSv3/util/lar/lar.h Log: Fix a corner case access to uninitialized memory (NULL pointer dereference or worse) in case the archive length is exactly sizeof(struct lar_header). Such an archive is invalid because the filename directly after the LAR header is always dereferenced and has to be at least 1 byte in the "empty filename" case (only terminating \0). Improve LAR code documentation and reorder variables in one assignment to make the code more obvious and readable. This will help people understand what the code does when they look at it half a year from now. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: LinuxBIOSv3/arch/x86/stage1.c =================================================================== --- LinuxBIOSv3/arch/x86/stage1.c 2007-10-11 16:13:12 UTC (rev 505) +++ LinuxBIOSv3/arch/x86/stage1.c 2007-10-16 18:59:36 UTC (rev 506) @@ -69,7 +69,7 @@ } /* - * This function is called from assembler code whith its argument on the + * This function is called from assembler code with its argument on the * stack. Force the compiler to generate always correct code for this case. */ void __attribute__((stdcall)) stage1_main(u32 bist) @@ -140,7 +140,7 @@ } else { printk(BIOS_DEBUG, "Choosing fallback boot.\n"); ret = execute_in_place(&archive, "fallback/initram"); - /* Try a normal boot if fallback doesn't exists in the lar. + /* Try a normal boot if fallback doesn't exist in the lar. * TODO: There are other ways to do this. * It could be ifdef or the boot flag could be forced. */ Modified: LinuxBIOSv3/include/lar.h =================================================================== --- LinuxBIOSv3/include/lar.h 2007-10-11 16:13:12 UTC (rev 505) +++ LinuxBIOSv3/include/lar.h 2007-10-16 18:59:36 UTC (rev 506) @@ -52,10 +52,9 @@ #include <types.h> -/* see note in lib/lar.c as to why this is ARCHIVE and not LARCHIVE */ #define MAGIC "LARCHIVE" #define MAX_PATHLEN 1024 -/* NOTE -- This and the user-mode lar.h are NOT IN SYNC. Be careful. */ +/* NOTE -- This and the user-mode lar.h may NOT be in sync. Be careful. */ struct lar_header { char magic[8]; u32 len; Modified: LinuxBIOSv3/lib/lar.c =================================================================== --- LinuxBIOSv3/lib/lar.c 2007-10-11 16:13:12 UTC (rev 505) +++ LinuxBIOSv3/lib/lar.c 2007-10-16 18:59:36 UTC (rev 506) @@ -49,7 +49,7 @@ * Given a file name in the LAR , search for it, and fill out a return struct with the * result. * @param archive A descriptor for current archive. This is actually a mem_file type, - * which is a machine-dependent representation of hte actual archive. In particular, + * which is a machine-dependent representation of the actual archive. In particular, * things like u32 are void * in the mem_file struct. * @param filename filename to find * @param result pointer to mem_file struct which is filled in if the file is found @@ -65,30 +65,43 @@ printk(BIOS_SPEW, "LAR: Start %p len 0x%x\n", archive->start, archive->len); - if (archive->len < sizeof(struct lar_header)) - printk(BIOS_ERR, "Error: truncated archive (%d bytes); minimum possible size is %d bytes\n", - archive->len, sizeof(struct lar_header)); + /* Why check for sizeof(struct lar_header) + 1? The code below expects + * a filename to follow directly after the LAR header and will + * dereference the address directly after the header. However, if + * archive->len == sizeof(struct lar_header), printing the filename + * will dereference memory outside the archive. Without looking at the + * filename, the only thing we can check is that there is at least room + * for an empty filename (only the terminating \0). + */ + if (archive->len < sizeof(struct lar_header) + 1) + printk(BIOS_ERR, "Error: truncated archive (%d bytes); minimum" + " possible size is %d bytes\n", + archive->len, sizeof(struct lar_header) + 1); - /* Getting this for loop right is harder than it looks. All quantities are - * unsigned. The LAR stretches from (e.g.) 0xfff0000 for 0x100000 - * bytes, i.e. to address ZERO. - * As a result, 'walk', can wrap to zero and keep going (this has been - * seen in practice). Recall that these are unsigned; walk can - * wrap to zero; so, question, when is walk less than any of these: - * archive->start - * Answer: once walk wraps to zero, it is < archive->start - * archive->start + archive->len - * archive->start + archive->len - 1 - * Answer: In the case that archive->start + archive->len == 0, ALWAYS! - * A lot of expressions have been tried and all have been wrong. - * So what would work? Simple: - * test for walk < archive->start + archive->len - 1 to cover the case - * that the archive does NOT occupy ALL of the top of memory and - * wrap to zero; - * and test for walk >= archive->start, - * to cover the case that you wrapped to zero. - * Unsigned pointer arithmetic that wraps to zero can be messy. - */ + /* Getting this for loop right is harder than it looks. All quantities + * are unsigned. The LAR stretches from (e.g.) 0xfff0000 for 0x100000 + * bytes, i.e. to address ZERO. + * As a result, 'walk', can wrap to zero and keep going (this has been + * seen in practice). Recall that these are unsigned; walk can + * wrap to zero; so, question, when is walk less than any of these: + * archive->start + * Answer: once walk wraps to zero, it is < archive->start + * archive->start + archive->len + * archive->start + archive->len - 1 + * Answer: In the case that archive->start + archive->len == 0, ALWAYS! + * A lot of expressions have been tried and all have been wrong. + * So what would work? Simple: + * test for walk < archive->start + archive->len - sizeof(lar_header) + * to cover the case that the archive does NOT occupy ALL of the + * top of memory and wrap to zero; RESIST the temptation to change + * that comparison to <= because if a header did terminate the + * archive, the filename (stored directly after the header) would + * be outside the archive and you'd get a nice NULL pointer for + * the filename + * and test for walk >= archive->start, + * to cover the case that you wrapped to zero. + * Unsigned pointer arithmetic that wraps to zero can be messy. + */ for (walk = archive->start; (walk < (char *)(archive->start + archive->len - sizeof(struct lar_header))) && (walk >= (char *)archive->start); walk += 16) { @@ -98,7 +111,7 @@ header = (struct lar_header *)walk; fullname = walk + sizeof(struct lar_header); - printk(BIOS_SPEW, "LAR: search for %s\n", fullname); + printk(BIOS_SPEW, "LAR: seen member %s\n", fullname); // FIXME: check checksum if (strcmp(fullname, filename) == 0) { @@ -115,11 +128,20 @@ result->compression, result->entry, result->loadaddress); return 0; } - // skip file - walk += (ntohl(header->len) + ntohl(header->offset) - - 1) & 0xfffffff0; + /* skip file: + * The next iteration of the for loop will add 16 to walk, so + * we now add offset (from header start to data start) and len + * (member length), subtract 1 (to get the address of the last + * byte of the member) and round this down to the next 16 byte + * boundary. + * In the case of consecutive archive members with header- + * before-member structure, the next iteration of the loop will + * start exactly at the beginning of the next header. + */ + walk += (ntohl(header->offset) + ntohl(header->len) - 1) + & 0xfffffff0; } - printk(BIOS_SPEW, "NO FILE FOUND\n"); + printk(BIOS_SPEW, "LAR: NO FILE FOUND!\n"); return 1; } @@ -157,7 +179,7 @@ * the loadaddress pointer in the mem_file struct. * @param archive A descriptor for current archive. * @param filename filename to find - * returns 0 on success, -1 otherwise + * returns entry on success, (void*)-1 otherwise */ void *load_file(struct mem_file *archive, const char *filename) Modified: LinuxBIOSv3/util/lar/lar.h =================================================================== --- LinuxBIOSv3/util/lar/lar.h 2007-10-11 16:13:12 UTC (rev 505) +++ LinuxBIOSv3/util/lar/lar.h 2007-10-16 18:59:36 UTC (rev 506) @@ -61,13 +61,15 @@ typedef uint32_t u32; typedef uint8_t u8; -/* NOTE -- This and the linuxbios lar.h are NOT IN SYNC. Be careful. */ +/* NOTE -- This and the user-mode lar.h may NOT be in sync. Be careful. */ struct lar_header { char magic[8]; u32 len; u32 reallen; u32 checksum; u32 compchecksum; + /* Filenames are limited to 2^31-1-sizeof(lar_header)-1 bytes. + * "Nobody will ever need more than 640k" */ u32 offset; /* Compression: * 0 = no compression

1 0

Re: [LinuxBIOS] r2862 - trunk/LinuxBIOSv2/src/devices
by Stefan Reinauer 16 Oct '07

16 Oct '07

* svn(a)openbios.org <svn(a)openbios.org> [071016 20:21]: > Author: uwe > Date: 2007-10-16 20:21:22 +0200 (Tue, 16 Oct 2007) > New Revision: 2862 > > Modified: > trunk/LinuxBIOSv2/src/devices/device_util.c > Log: > Add resource size and resource granularity reporting to device_util.c. > > Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> > Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Carl-Daniel, Uwe, can you add this to v3, too, please? > Modified: trunk/LinuxBIOSv2/src/devices/device_util.c > =================================================================== > --- trunk/LinuxBIOSv2/src/devices/device_util.c 2007-10-16 18:15:25 UTC (rev 2861) > +++ trunk/LinuxBIOSv2/src/devices/device_util.c 2007-10-16 18:21:22 UTC (rev 2862) > @@ -467,10 +467,11 @@ > #endif > } > printk_debug( > - "%s %02x <- [0x%010Lx - 0x%010Lx] %s%s%s\n", > + "%s %02x <- [0x%010Lx - 0x%010Lx] size 0x%08Lx gran 0x%02x %s%s%s\n", > dev_path(dev), > resource->index, > base, end, > + resource->size, resource->gran, > buf, > resource_type(resource), > comment); > > > -- > linuxbios mailing list > linuxbios(a)linuxbios.org > http://www.linuxbios.org/mailman/listinfo/linuxbios > -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info(a)coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

2 1

[LinuxBIOS] Supertek ST-3ET
by Markus Boas 16 Oct '07

16 Oct '07

Hi Volks, the ST-3WT boots but it dosn't load the rtl8139.elf oder zelf image for pxe. There is the boot log: Sep 19:08:00 CEST 2007 starting... Setting up default parameters for memory Sizing memory Probing for DIMM0 Found DIMM0 Page Size: 00002000 Component Banks: 4 Module Banks: 1 DIMM size: 08000000 Probing for DIMM1 MC_BANK_CFG = 00701530 Copying LinuxBIOS to RAM. Jumping to LinuxBIOS. LinuxBIOS-2.0.0.0Normal So 30. Sep 19:08:00 CEST 2007 booting... clocks_per_usec: 360 Enumerating buses... Finding PCI configuration type. PCI: Using configuration type 1 PCI_DOMAIN: 0000 enabled PCI: pci_scan_bus for bus 00 PCI: 00:00.0 [1078/0001] enabled PCI: 00:0f.0 [10ec/8139] enabled PCI: 00:12.0 [1078/0100] enabled PCI: 00:12.1 [1078/0101] enabled PCI: 00:12.2 [1078/0102] enabled PCI: 00:12.3 [1078/0103] enabled PCI: 00:12.4 [1078/0104] enabled PCI: 00:13.0 [0e11/a0f8] enabled PNP: 002e.0 enabled PNP: 002e.1 enabled PNP: 002e.2 enabled PNP: 002e.3 disabled PNP: 002e.4 enabled PNP: 002e.5 enabled PNP: 002e.6 enabled PNP: 002e.7 enabled PNP: 002e.8 enabled PCI: 00:12.1 disabled PCI: 00:12.2 enabled PCI: 00:12.3 disabled PCI: 00:12.4 disabled PCI: pci_scan_bus returning with max=000 done Allocating resources... Reading resources... Done reading resources. Setting resources... BC_DRAM_TOP = 0x07bfffff MC_GBASE_ADD = 0x000000f8 I would set ram size to 124 Mbytes PCI: 00:0f.0 10 <- [0x0000001000 - 0x00000010ff] io PCI: 00:0f.0 14 <- [0x00febfd000 - 0x00febfd0ff] mem PCI: 00:12.1 10 <- [0x00febfe000 - 0x00febfe0ff] mem PCI: 00:12.2 20 <- [0x0000001400 - 0x000000147f] io PCI: 00:12.3 10 <- [0x00febff000 - 0x00febff07f] mem PCI: 00:12.4 10 <- [0x00febfb000 - 0x00febfbfff] mem PCI: 00:13.0 10 <- [0x00febfc000 - 0x00febfcfff] mem Done setting resources. Done allocating resources. Enabling resources... PCI: 00:00.0 cmd <- 07 PCI: 00:0f.0 cmd <- 03 PCI: 00:12.0 cmd <- 0f PCI: 00:12.2 missing enable_resources PCI: 00:12.1 cmd <- 02 PCI: 00:12.2 cmd <- 01 PCI: 00:12.3 cmd <- 02 PCI: 00:12.4 cmd <- 02 PCI: 00:13.0 cmd <- 02 done. Initializing devices... Root Device init PCI: 00:00.0 init northbridge: northbridge_init() PCI: 00:12.0 init PNP: 002e.0 init PNP: 002e.1 init PNP: 002e.2 init PNP: 002e.4 init PNP: 002e.5 init PNP: 002e.6 init PNP: 002e.7 init PNP: 002e.8 init PCI: 00:0f.0 init PCI: 00:12.1 init PCI: 00:12.2 init Primary IDE interface disabled Secondary IDE interface enabled PCI: 00:12.3 init PCI: 00:12.4 init PCI: 00:13.0 init Devices initialized Copying IRQ routing tables to 0xf0000...done. Verifing copy of IRQ routing tables at 0xf0000...done Checking IRQ routing table consistency... check_pirq_routing_table() - irq_routing_table located at: 0x000f0000 done. Moving GDT to 0x500...ok Adjust low_table_end from 0x00000530 to 0x00001000 Adjust rom_table_end from 0x000f0400 to 0x00100000 Wrote linuxbios table at: 00000530 - 0000068c checksum 7000 Welcome to elfboot, the open sourced starter. January 2002, Eric Biederman. Version 1.3 rom_stream: 0xfffc0000 - 0xfffcffff No header at 0 ... ... ... No header at 8096 header_offset is -1 Can not load ELF The Config.lb # Config file for the Eaglelion 5BCM motherboard # This will make a target directory of 5bcm target 5bcm mainboard eaglelion/5bcm option ROM_SIZE=512*1024 romimage "normal" option USE_FALLBACK_IMAGE=0 option ROM_IMAGE_SIZE=0x10000 option LINUXBIOS_EXTRA_VERSION=".0Normal" # payload /usr/share/etherboot/5.1.9pre2-lnxi-lb/tg3--ide_disk.zelf # payload ../../../../tg3--ide_disk.zelf # payload ../../../../../lnxieepro100.ebi # payload /etc/hosts payload /home/ryven/hardware/Linuxbios/payload/rtl8139.elf end romimage "fallback" option USE_FALLBACK_IMAGE=1 option ROM_IMAGE_SIZE=0x10000 option LINUXBIOS_EXTRA_VERSION=".0Fallback" # payload /usr/share/etherboot/5.1.9pre2-lnxi-lb/tg3--ide_disk.zelf # payload ../../../../tg3--ide_disk.zelf # payload ../../../../../lnxieepro100.ebia # payload /etc/hosts payload /home/ryven/hardware/Linuxbios/payload/rtl8139.elf end buildrom ./linuxbios.rom ROM_SIZE "normal" "fallback" The lspci -vv Geode:~# lspci -vv 0000:00:00.0 Host bridge: Cyrix Corporation PCI Master Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- Latency: 0 0000:00:0f.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8139/8139C/8139C+ (rev 10) Subsystem: Realtek Semiconductor Co., Ltd. RT8139 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- Latency: 32 (8000ns min, 16000ns max) Interrupt: pin A routed to IRQ 11 Region 0: I/O ports at e000 [size=256] Region 1: Memory at d0000000 (32-bit, non-prefetchable) [size=256] Capabilities: [50] Power Management version 2 Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA PME(D0-,D1+,D2+,D3hot+,D3cold+) Status: D0 PME-Enable- DSel=0 DScale=0 PME- 0000:00:12.0 ISA bridge: Cyrix Corporation 5530 Legacy [Kahlua] (rev 30) Control: I/O+ Mem+ BusMaster+ SpecCycle+ MemWINV+ VGASnoop- ParErr- Stepping- SERR- FastB2B- Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- Latency: 64, Cache Line Size: 0x04 (16 bytes) 0000:00:12.1 Bridge: Cyrix Corporation 5530 SMI [Kahlua] Control: I/O- Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- Region 0: Memory at 40012000 (32-bit, non-prefetchable) [size=256] 0000:00:12.2 IDE interface: Cyrix Corporation 5530 IDE [Kahlua] (prog-if 80 [Master]) Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- Latency: 0 Region 4: I/O ports at f000 [size=16] 0000:00:12.3 Multimedia audio controller: Cyrix Corporation 5530 Audio [Kahlua] Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- Latency: 0 Region 0: Memory at 40011000 (32-bit, non-prefetchable) [size=128] 0000:00:12.4 VGA compatible controller: Cyrix Corporation 5530 Video [Kahlua] (prog-if 00 [VGA]) Subsystem: Cyrix Corporation: Unknown device 0001 Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- Region 0: Memory at 40800000 (32-bit, non-prefetchable) [size=8M] 0000:00:13.0 USB Controller: Compaq Computer Corporation ZFMicro Chipset USB (rev 06) (prog-if 10 [OHCI]) Subsystem: Compaq Computer Corporation ZFMicro Chipset USB Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- Latency: 32 (20000ns max), Cache Line Size: 0x08 (32 bytes) Interrupt: pin A routed to IRQ 15 Region 0: Memory at d0004000 (32-bit, non-prefetchable) [size=4K] Can say me somebody what i make wrong? Greeding Markus

4 7

[LinuxBIOS] [PATCH] v2: improve debugging in device_util.c
by Carl-Daniel Hailfinger 16 Oct '07

16 Oct '07

Add resource size and resource granularity reporting to device_util.c Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> --- Index: LinuxBIOSv2/src/devices/device_util.c =================================================================== --- LinuxBIOSv2/src/devices/device_util.c (Revision 2849) +++ LinuxBIOSv2/src/devices/device_util.c (Arbeitskopie) @@ -467,10 +467,11 @@ #endif } printk_debug( - "%s %02x <- [0x%010Lx - 0x%010Lx] %s%s%s\n", + "%s %02x <- [0x%010Lx - 0x%010Lx] size 0x%08Lx gran 0x%02x %s%s%s\n", dev_path(dev), resource->index, base, end, + resource->size, resource->gran, buf, resource_type(resource), comment);

2 1

[LinuxBIOS] r2862 - trunk/LinuxBIOSv2/src/devices
by svn＠openbios.org 16 Oct '07

16 Oct '07

Author: uwe Date: 2007-10-16 20:21:22 +0200 (Tue, 16 Oct 2007) New Revision: 2862 Modified: trunk/LinuxBIOSv2/src/devices/device_util.c Log: Add resource size and resource granularity reporting to device_util.c. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/LinuxBIOSv2/src/devices/device_util.c =================================================================== --- trunk/LinuxBIOSv2/src/devices/device_util.c 2007-10-16 18:15:25 UTC (rev 2861) +++ trunk/LinuxBIOSv2/src/devices/device_util.c 2007-10-16 18:21:22 UTC (rev 2862) @@ -467,10 +467,11 @@ #endif } printk_debug( - "%s %02x <- [0x%010Lx - 0x%010Lx] %s%s%s\n", + "%s %02x <- [0x%010Lx - 0x%010Lx] size 0x%08Lx gran 0x%02x %s%s%s\n", dev_path(dev), resource->index, base, end, + resource->size, resource->gran, buf, resource_type(resource), comment);

1 0

← Newer
1
...
23
24
25
26
27
28
29
...
49
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot October 2007