-----Original Message----- From: Carl-Daniel Hailfinger [mailto:c-d.hailfinger.devel.2006@gmx.net] Sent: Thursday, December 06, 2007 9:40 AM To: myles@mouselemur.cs.byu.edu Cc: 'Linuxbios' Subject: Re: [LinuxBIOS] r77 - in buildrom-devel: . config/payloads config/platforms packages/linuxbios
On 06.12.2007 17:33, Myles Watson wrote:
Modified: buildrom-devel/Config.in
--- buildrom-devel/Config.in 2007-12-05 23:27:08 UTC (rev 76) +++ buildrom-devel/Config.in 2007-12-06 16:18:18 UTC (rev 77) @@ -43,6 +43,23 @@
menu "LinuxBIOS configuration"
+config LINUXBIOS_V3
- bool "Use LinuxBIOSv3"
- depends ADVANCED
- default n
- help
- Use the v3 tree. LinuxBIOSv3 doesn't support all platforms yet.
+config LINUXBIOS_V3_LGDT_PATCH
- bool "Avoid an error in stage0_i586 with some compilers"
- depends LINUXBIOS_V3
- default n
- help
- Say 'y' here to use the patch from the mailing list to replace
- "data32 lgdt %cs:gdtptr" with
- "movl $gdtptr"
"%ebx lgdt %cs:(%bx)"config USE_LZMA bool "Enable LZMA compression" depends !PAYLOAD_OFW
While I welcome almost everything in that patch, I dislike that part. Either we agree on some code sequence that works for everyone or we
mark
some compilers "broken".
I like the "code sequence that works for everyone" thought. That's more
of
a LinuxBIOSv3 issue than a buildrom issue, though. I'd hoped to make
people
happy by not applying the patch by default.
Can you send it in as a patch with a short description? If comments are positive, we should just commit.
It was submitted (but not in patch form) by Brendan Trotter http://www.mail-archive.com/linuxbios@linuxbios.org/msg08771.html
Here it is in patch form. - data32 lgdt %cs:gdtptr + movl $gdtptr, %ebx + lgdt %cs:(%bx)
It removes the first line, which causes some compilers to give a "truncated gdtptr" error, and replaces it with an intermediate load step. I think it should be tested by someone with the "working" compiler, to compare the output.
Myles
On Thu, Dec 06, 2007 at 10:14:41AM -0700, Myles Watson wrote:
It was submitted (but not in patch form) by Brendan Trotter http://www.mail-archive.com/linuxbios@linuxbios.org/msg08771.html
Here it is in patch form.
- data32 lgdt %cs:gdtptr
- movl $gdtptr, %ebx
- lgdt %cs:(%bx)
It removes the first line, which causes some compilers to give a "truncated gdtptr" error, and replaces it with an intermediate load step. I think it should be tested by someone with the "working" compiler, to compare the output.
Please repost with a Signed-off-by.
Uwe.
On Thu, Dec 06, 2007 at 10:14:41AM -0700, Myles Watson wrote:
It was submitted (but not in patch form) by Brendan Trotter http://www.mail-archive.com/linuxbios@linuxbios.org/msg08771.html
Here it is in patch form.
- data32 lgdt %cs:gdtptr
- movl $gdtptr, %ebx
- lgdt %cs:(%bx)
It removes the first line, which causes some compilers to give a "truncated gdtptr" error, and replaces it with an intermediate load step. I think it should be tested by someone with the "working" compiler, to compare the output.
Please repost with a Signed-off-by.
I was hoping Brendan Trotter would supply that, since it was his work. It could be considered trivial, though, if the compiler output is the same.
Myles
On Thu, Dec 06, 2007 at 03:08:58PM -0700, Myles Watson wrote:
On Thu, Dec 06, 2007 at 10:14:41AM -0700, Myles Watson wrote:
It was submitted (but not in patch form) by Brendan Trotter http://www.mail-archive.com/linuxbios@linuxbios.org/msg08771.html
Here it is in patch form.
- data32 lgdt %cs:gdtptr
- movl $gdtptr, %ebx
- lgdt %cs:(%bx)
It removes the first line, which causes some compilers to give a "truncated gdtptr" error, and replaces it with an intermediate load step. I think it should be tested by someone with the "working" compiler, to compare the output.
Please repost with a Signed-off-by.
I was hoping Brendan Trotter would supply that, since it was his work. It could be considered trivial, though, if the compiler output is the same.
Yes, I guess this is trivial enough so you can post it with your Signed-off-by, but if Brendan (CC'd) can re-send with a Signed-off-by that's fine too, of course.
Uwe.
It was submitted (but not in patch form) by Brendan Trotter http://www.mail-archive.com/linuxbios@linuxbios.org/msg08771.html
Here it is in patch form.
- data32 lgdt %cs:gdtptr
- movl $gdtptr, %ebx
- lgdt %cs:(%bx)
It removes the first line, which causes some compilers to give a "truncated gdtptr" error, and replaces it with an intermediate load step. I think it should be tested by someone with the "working" compiler, to compare the output.
Please repost with a Signed-off-by.
I was hoping Brendan Trotter would supply that, since it was his work.
It
could be considered trivial, though, if the compiler output is the same.
Yes, I guess this is trivial enough so you can post it with your Signed-off-by, but if Brendan (CC'd) can re-send with a Signed-off-by that's fine too, of course.
I tried it on a different compiler (4.1.1) and the patch builds, but won't boot on qemu. Without the patch it builds and boots.
I'll just upgrade my compiler.
Myles
-
Myles Watson -
Uwe Hermann