Error building cache_as_ram.inc

[Joseph Smith]

Anyone seen this error before?

/home/joe/coreboot/src/cpu/intel/model_6ex/cache_as_ram.inc: Assembler 
messages:
/home/joe/coreboot/src/cpu/intel/model_6ex/cache_as_ram.inc:43: Error: 
unbalanced parenthesis in operand 1.
/home/joe/coreboot/src/cpu/intel/model_6ex/cache_as_ram.inc:93: Error: 
unbalanced parenthesis in operand 1.
make: *** 
[/home/joe/coreboot/build/mainboard/kontron/986lcd-m/crt0.initobj.o] Error 1
[joe@smitty2m coreboot]$

gcc (GCC) 4.4.3 20100127 (Red Hat 4.4.3-4)
binutils-2.19.51.0.14-37.fc12.x86_64

[Patrick Georgi]

Am 25.02.2010 06:14, schrieb Joseph Smith:
> Anyone seen this error before?
>
> /home/joe/coreboot/src/cpu/intel/model_6ex/cache_as_ram.inc: Assembler
> messages:
> /home/joe/coreboot/src/cpu/intel/model_6ex/cache_as_ram.inc:43: Error:
> unbalanced parenthesis in operand 1.
> /home/joe/coreboot/src/cpu/intel/model_6ex/cache_as_ram.inc:93: Error:
> unbalanced parenthesis in operand 1.
> make: ***
> [/home/joe/coreboot/build/mainboard/kontron/986lcd-m/crt0.initobj.o]
> Error 1
> [joe@smitty2m coreboot]$
>
> gcc (GCC) 4.4.3 20100127 (Red Hat 4.4.3-4)
> binutils-2.19.51.0.14-37.fc12.x86_64

That's a classic: some assembler variants consider "/" in assembler code
to be the start of a comment. Use crossgcc.

Patrick

[Joseph Smith]

On 02/25/2010 02:57 AM, Patrick Georgi wrote:
> Am 25.02.2010 06:14, schrieb Joseph Smith:
> > Anyone seen this error before?
> >
> > /home/joe/coreboot/src/cpu/intel/model_6ex/cache_as_ram.inc: Assembler
> > messages:
> > /home/joe/coreboot/src/cpu/intel/model_6ex/cache_as_ram.inc:43: Error:
> > unbalanced parenthesis in operand 1.
> > /home/joe/coreboot/src/cpu/intel/model_6ex/cache_as_ram.inc:93: Error:
> > unbalanced parenthesis in operand 1.
> > make: ***
> > [/home/joe/coreboot/build/mainboard/kontron/986lcd-m/crt0.initobj.o]
> > Error 1
> > [joe@smitty2m coreboot]$
> >
> > gcc (GCC) 4.4.3 20100127 (Red Hat 4.4.3-4)
> > binutils-2.19.51.0.14-37.fc12.x86_64
>
> That's a classic: some assembler variants consider "/" in assembler code
> to be the start of a comment. Use crossgcc.

Ok, thanks. Come to think of it I do have crossgcc in my PATH:

export PATH=$PATH:/home/joe/crossgcc/xgcc/bin

I just have it running outside the coreboot directory, does that make a 
difference?

[Patrick Georgi]

Am 25.02.2010 11:50, schrieb Joseph Smith:
> I just have it running outside the coreboot directory, does that make a
> difference?

Is it used by coreboot? (see .xcompile)

Were the patches applied? (We specifically fix the /-as-comment
"feature" in our version), but I know of some cases where patching
failed, and buildgcc didn't stop there.

Patrick

[Joseph Smith]

On 02/25/2010 05:52 AM, Patrick Georgi wrote:
> Am 25.02.2010 11:50, schrieb Joseph Smith:
> > I just have it running outside the coreboot directory, does that make a
> > difference?
>
> Is it used by coreboot? (see .xcompile)
>
> Were the patches applied? (We specifically fix the /-as-comment
> "feature" in our version), but I know of some cases where patching
> failed, and buildgcc didn't stop there.

Yes, it appears to be using crossgcc:

# elf32-i386 toolchain
AS:=i386-elf-as
CC:=i386-elf-gcc -fno-stack-protector -Wl,--build-id=none
CPP:=i386-elf-cpp
AR:=i386-elf-ar
LD:=i386-elf-ld
STRIP:=i386-elf-strip
NM:=i386-elf-nm
OBJCOPY:=i386-elf-objcopy
OBJDUMP:=i386-elf-objdump

# native toolchain
HOSTCC:=gcc

[Joseph Smith]

On Thu, 25 Feb 2010 05:54:46 -0500, Joseph Smith 
wrote:
> On 02/25/2010 05:52 AM, Patrick Georgi wrote:
> > Am 25.02.2010 11:50, schrieb Joseph Smith:
> > > I just have it running outside the coreboot directory, does that make a
> > > difference?
> >
> > Is it used by coreboot? (see .xcompile)
> >
> > Were the patches applied? (We specifically fix the /-as-comment
> > "feature" in our version), but I know of some cases where patching
> > failed, and buildgcc didn't stop there.
>
> Yes, it appears to be using crossgcc:
>
> # elf32-i386 toolchain
> AS:=i386-elf-as
> CC:=i386-elf-gcc -fno-stack-protector -Wl,--build-id=none
> CPP:=i386-elf-cpp
> AR:=i386-elf-ar
> LD:=i386-elf-ld
> STRIP:=i386-elf-strip
> NM:=i386-elf-nm
> OBJCOPY:=i386-elf-objcopy
> OBJDUMP:=i386-elf-objdump
>
> # native toolchain
> HOSTCC:=gcc

So am I looking at this correctly?
It is using crossgcc correct?

[Patrick Georgi]

Am 25.02.2010 13:38, schrieb Joseph Smith:
> So am I looking at this correctly?
> It is using crossgcc correct?

Think so.
Maybe your crossgcc build failed on patching, too...

Patrick

[Joseph Smith]

On Thu, 25 Feb 2010 13:39:40 +0100, Patrick Georgi 
wrote:
> Am 25.02.2010 13:38, schrieb Joseph Smith:
> > So am I looking at this correctly?
> > It is using crossgcc correct?
>
> Think so.
> Maybe your crossgcc build failed on patching, too...

ok I will try re-building it, thanks.