Asrock e350m1: sata disks not recognized

[Valentin]

Hello,

I've built coreboot for a asrock e350m1 mainboard before the weekend and 
with the current version SATA disks were not detected. Neither by 
SeaBIOS nor in a current Linux system booted from USB.

As previos versions worked just fine i narrowed it down to the commit 
94c47c0 [https://review.coreboot.org/c/coreboot/+/37703], it's the first 
commit that shows this problem.
It seems to me that the rrot cause is that since this commit
sb_Poweron_Init() for the sb800 isn't called anywhere, but I'm not sure 
about the right way to include it.
Could anyone help with that?

Thanks,
Valentin

[Michal Zygowski]

On 04.02.2020 12:17, Valentin wrote:
> Hello,

Hi,
> I've built coreboot for a asrock e350m1 mainboard before the weekend
> and with the current version SATA disks were not detected. Neither by
> SeaBIOS nor in a current Linux system booted from USB.
>
> As previos versions worked just fine i narrowed it down to the commit
> 94c47c0 [https://review.coreboot.org/c/coreboot/+/37703], it's the
> first commit that shows this problem.
> It seems to me that the rrot cause is that since this commit
> sb_Poweron_Init() for the sb800 isn't called anywhere, but I'm not
> sure about the right way to include it.
> Could anyone help with that?

sb_Poweron_Init is called in platform_BeforeInitReset in agesa family 14
state machine. Also by looking at latest board status, the SATA was working:
https://review.coreboot.org/cgit/board-status.git/tree/asrock/e350m1/4.11-90...

Line 1180:

|AHCI/0: Set transfer mode to UDMA-6 Searching bios-geometry for:
/pci@i0cf8/*@11/drive@0/disk@0 AHCI/0: registering: "AHCI/0: SanDisk
SDSSDP064G ATA-9 Hard-Disk (61057 MiBytes)"|

Don't know exactly what could cause it. I would try to build with the
same config and repo revision as in the board status.
> Thanks,
> Valentin

Regards,

[Peter Stuge]

Michal Zygowski wrote:
> Also by looking at latest board status, the SATA was working:
> https://review.coreboot.org/cgit/board-status.git/tree/asrock/e350m1/4.11-90...
>
> Line 1180:
>
> |AHCI/0: Set transfer mode to UDMA-6 Searching bios-geometry for:
> /pci@i0cf8/*@11/drive@0/disk@0 AHCI/0: registering: "AHCI/0: SanDisk
> SDSSDP064G ATA-9 Hard-Disk (61057 MiBytes)"|
>
> Don't know exactly what could cause it. I would try to build with the
> same config and repo revision as in the board status.

This is a very good suggestion. If it still doesn't work, then maybe
there is a difference between flash (SSD) and metal (HDD) SATA devices...

//Peter

[Valentin]

Hi,
> > Don't know exactly what could cause it. I would try to build with the
> > same config and repo revision as in the board status.
>
> This is a very good suggestion. If it still doesn't work, then maybe
> there is a difference between flash (SSD) and metal (HDD) SATA devices...

It was a good suggestion indeed, with this version (and actually also 
with every version after it) everything works as expected.

Thank you for your help,
Valentin