Re: [coreboot] [RFH] Status of the Lenovo X201

[Nicola Corna]

April 26, 2018 7:21 PM, "Kyösti Mälkki"  wrote:
> Well, smashed stack in romstage -error is no longer in the log,
> possibly because this boot used MRC cache now.

Could be, unfortunately I don't have first boot log, I'll grab it in the next
test.
> With config PARALLEL_CPU_INIT=y so SMP / SMM init in initialize_cpus()
> will never call wait_other_cpus() at all. That actually regressed in
> my commit 0cc2ce4 [1] but I can't test if reverting it solves this for
> you. I'll push a regression fix soonish for review.
>
> [1] https://review.coreboot.org/c/coreboot/+/21088
>
> Kyösti

I'm going to test https://review.coreboot.org/#/c/coreboot/+/25874 soon and
report back, thanks for your help.

Nicola

[RFH] Status of the Lenovo X201

[Nicola Corna]

April 27, 2018 12:29 PM, "Nicola Corna"  wrote:
> > With config PARALLEL_CPU_INIT=y so SMP / SMM init in initialize_cpus()
> > will never call wait_other_cpus() at all. That actually regressed in
> > my commit 0cc2ce4 [1] but I can't test if reverting it solves this for
> > you. I'll push a regression fix soonish for review.
> >
> > [1] https://review.coreboot.org/c/coreboot/+/21088
> >
> > Kyösti
>
> I'm going to test https://review.coreboot.org/#/c/coreboot/+/25874 soon and
> report back, thanks for your help.

Unfortunately that patch dont't fix the issue (log attached).
I've also tried 0cc2ce4 but with that revision it works correctly
(log and config attached).

If needed I can run a git bisect to find which commit broke the boot.

Nicola

[RFH] Status of the Lenovo X201

[Kyösti Mälkki]

On Sat, Apr 28, 2018 at 3:41 PM, Nicola Corna  wrote:
> April 27, 2018 12:29 PM, "Nicola Corna"  wrote:
> > > With config PARALLEL_CPU_INIT=y so SMP / SMM init in initialize_cpus()
> > > will never call wait_other_cpus() at all. That actually regressed in
> > > my commit 0cc2ce4 [1] but I can't test if reverting it solves this for
> > > you. I'll push a regression fix soonish for review.
> > >
> > > [1] https://review.coreboot.org/c/coreboot/+/21088
> > >
> > > Kyösti
> >
> > I'm going to test https://review.coreboot.org/#/c/coreboot/+/25874 soon and
> > report back, thanks for your help.
>
> Unfortunately that patch dont't fix the issue (log attached).
> I've also tried 0cc2ce4 but with that revision it works correctly
> (log and config attached).
>
> If needed I can run a git bisect to find which commit broke the boot.

I thought I had seen some other message [1] on the list regarding
X201(i) not booting or resuming. Looking at your boot log ending on
"0:1f.0 final", it appears we are looking at the same commit which
adds INTEL_CHIPSET_LOCKDOWN implementation in lpc_final(). The commit
message tells it was not tested for ibexpeak so you may want to try
revert that one before going for full bisect.

[1] https://mail.coreboot.org/pipermail/coreboot/2018-April/086564.html
[2] https://review.coreboot.org/c/coreboot/+/21129

Kyösti