This is an obvious bug which I overlooked when I worked on the AM2r2 modules.
Zheng
Signed-off-by: Zheng Bao zheng.bao@amd.com
Index: src/northbridge/amd/amdmct/mct/mctardk4.c =================================================================== --- src/northbridge/amd/amdmct/mct/mctardk4.c (revision 4427) +++ src/northbridge/amd/amdmct/mct/mctardk4.c (working copy) @@ -121,7 +121,7 @@ *AddrTmgCTL = 0x002F2F00; else if (Speed == 4) *AddrTmgCTL = 0x00202520; - else if (Speed == 4) + else if (Speed == 5) *AddrTmgCTL = 0x002F2020; else *AddrTmgCTL = 0x002F2F2F; @@ -130,7 +130,7 @@ *CMDmode = 2; *AddrTmgCTL = 0x00202520; *ODC_CTL = 0x00113222; - } else if(Speed == 4) { + } else if(Speed == 5) { *CMDmode = 2; *AddrTmgCTL = 0x002F2020; *ODC_CTL = 0x00113222;
Committed, r4430.
Zheng
-----Original Message----- From: ron minnich [mailto:rminnich@gmail.com] Sent: Friday, July 17, 2009 1:33 PM To: Bao, Zheng Cc: Coreboot Subject: Re: [coreboot] [patch] A bug in AMD fam10 am2r2 module
Acked-by: Ronald G. Minnich rminnich@gmail.com