Intel P35/Q35/G33/Q33/G31/P31

[Loïc Grenié]

Here is a patch for inteltool to print the registers values
  for the P31..Q35 chipset. The registers are (as far as I
  can tell) unchanged with respect to those of the PM965.
  I've no strong ideas on the names: I've chosen
  PCI_DEVICE_ID_INTEL_82G33 as Northbridge name, it
  can obviously be changed to anything else. I've given
  "P35/Q35/G33/Q33/G31/P31" as description, it can also
  be freely changed.

Please consider for applying,

Thanks,

Loïc

[Paul Menzel]

Dear Loïc,

Am Sonntag, den 01.11.2009, 15:11 +0100 schrieb Loïc Grenié:
> Here is a patch for inteltool to print the registers values
> for the P31..Q35 chipset.

I did not receive an attachment and it looks like the list did not too
[1].

Could you resend it please, so that the developers can review it.

Thanks,

Paul

[1] http://www.coreboot.org/pipermail/coreboot/2009-November/054010.html

[Loïc Grenié]

Sorry for the forgotten patch !

Here is a patch for inteltool to print the registers values
 for the P31..Q35 chipset. The registers are (as far as I
 can tell) unchanged with respect to those of the PM965.
 I've no strong ideas on the names: I've chosen
 PCI_DEVICE_ID_INTEL_82G33 as Northbridge name, it
 can obviously be changed to anything else. I've given
 "P35/Q35/G33/Q33/G31/P31" as description, it can also
 be freely changed.

Please consider for applying,

Thanks,

Loïc

[Paul Menzel]

Am Sonntag, den 01.11.2009, 21:24 +0100 schrieb Loïc Grenié:

[…]
> Please consider for applying,

One more thing. Could you add your Signed-off-by line as explained in
the Sign-off Procedure [1]. So that the developers can acknowledge and
commit your patch.

Thanks,

Paul

[1] http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure

[Loïc Grenié]

Here is a patch for inteltool to print the registers values
 for the P31..Q35 chipset. The registers are (as far as I
 can tell) unchanged with respect to those of the PM965.
 I've no strong ideas on the names: I've chosen
 PCI_DEVICE_ID_INTEL_82[PQG]3[135] as Northbridge
 names, they can obviously be changed to anything else. I've
 given "Q35", "P35/G33/G31/P31" and "Q33" as descriptions,
 they can also be freely changed.

Signed-off-by: Loïc Grenié 
Description: adds 82Q35/P35/Q33/G33/G31/P31 capability.

Please consider for applying,

Thanks,

Loïc

[Carl-Daniel Hailfinger]

On 02.11.2009 10:12, Loïc Grenié wrote:
> Here is a patch for inteltool to print the registers values
>  for the P31..Q35 chipset. The registers are (as far as I
>  can tell) unchanged with respect to those of the PM965.
>  I've no strong ideas on the names: I've chosen
>  PCI_DEVICE_ID_INTEL_82[PQG]3[135] as Northbridge
>  names, they can obviously be changed to anything else. I've
>  given "Q35", "P35/G33/G31/P31" and "Q33" as descriptions,
>  they can also be freely changed.
>
> Signed-off-by: Loïc Grenié 
> Description: adds 82Q35/P35/Q33/G33/G31/P31 capability.

Thanks for your patch!

Acked-by: Carl-Daniel Hailfinger 
and committed in r4905.

Regards,
Carl-Daniel