Compiling flashrom on x86_64

[Sergei Antonov]

Hi!
Flashrom fails to compile on x86_64 with these errors:
cc1: warnings being treated as errors
layout.c: In function 'show_id':
layout.c:68: warning: cast from pointer to integer of different size
layout.c:70: warning: cast from pointer to integer of different size

The corresponding lines of code:
68:		(!isprint((const char *)(bios + size - *(walk - 1))) &&
69:		((const char *)(bios + size - *(walk - 1)))) ||
70:		(!isprint((const char *)(bios + size - *(walk - 2))) &&
71:		((const char *)(bios + size - *(walk - 2))))) {

Can someone check-in a fix? (Indirection omitted?)

[Peter Stuge]

Dear Sergei,

On Wed, Jul 09, 2008 at 10:30:48AM +0400, Sergei Antonov wrote:
> Flashrom fails to compile on x86_64 with these errors:

This is a known problem.
> Can someone check-in a fix? (Indirection omitted?)

Please apply the workaround patch attached to the ticket for now:
http://tracker.coreboot.org/trac/coreboot/attachment/ticket/102/fr.idheur.kl...

I am very sorry about this inconvenience.

//Peter

[Sergei Antonov]

On Wed, Jul 9, 2008 at 6:50 PM, Peter Stuge  wrote:
> > Can someone check-in a fix? (Indirection omitted?)
>
> Please apply the workaround patch attached to the ticket for now:
> http://tracker.coreboot.org/trac/coreboot/attachment/ticket/102/fr.idheur.kl...

Why not fix the problem in svn?
Passing const char* to isprint() is apparently an error.

[Tiago Marques]

I've compiled flashrom on x86_64 not too long ago, without any
problem. It worked fine out of the box.
Used Gentoo Linux AMD64 packages.

Best regards

On 7/9/08, Peter Stuge  wrote:
> Dear Sergei,
>
> On Wed, Jul 09, 2008 at 10:30:48AM +0400, Sergei Antonov wrote:
> > Flashrom fails to compile on x86_64 with these errors:
>
> This is a known problem.
> > Can someone check-in a fix? (Indirection omitted?)
>
> Please apply the workaround patch attached to the ticket for now:
>  http://tracker.coreboot.org/trac/coreboot/attachment/ticket/102/fr.idheur.kl...
>
> I am very sorry about this inconvenience.
>
> //Peter

[Peter Stuge]

On Wed, Jul 09, 2008 at 07:21:56PM +0400, Sergei Antonov wrote:
> > Please apply the workaround patch attached to the ticket for now:
> > http://tracker.coreboot.org/trac/coreboot/attachment/ticket/102/fr.idheur.kl...
>
> Why not fix the problem in svn?

A different approach to image identification is being worked on.
> Passing const char* to isprint() is apparently an error.

Yes, but the heuristic is broken anyway. The new approach isn't ready
yet.

On Wed, Jul 09, 2008 at 07:53:48PM +0100, Tiago Marques wrote:
> I've compiled flashrom on x86_64 not too long ago, without any
> problem.

Yes, r3408 that breaks x86_64 was committed a week ago.

//Peter

[Carl-Daniel Hailfinger]

On 10.07.2008 13:46, Peter Stuge wrote:
> On Wed, Jul 09, 2008 at 07:21:56PM +0400, Sergei Antonov wrote:
> > > Please apply the workaround patch attached to the ticket for now:
> > > http://tracker.coreboot.org/trac/coreboot/attachment/ticket/102/fr.idheur.kl...
> >
> > Why not fix the problem in svn?
>
> A different approach to image identification is being worked on.
> > Passing const char* to isprint() is apparently an error.
>
> Yes, but the heuristic is broken anyway. The new approach isn't ready
> yet.
>
> On Wed, Jul 09, 2008 at 07:53:48PM +0100, Tiago Marques wrote:
> > I've compiled flashrom on x86_64 not too long ago, without any
> > problem.
>
> Yes, r3408 that breaks x86_64 was committed a week ago.

I posted a complete rewrite of image identification with greatly
improved readability a few days ago. The code is IMHO even more readable
than the original.

Regards,
Carl-Daniel