the following patch was just integrated into master: commit b403fdfcb1e44dddee30be9820e7e1db5a41764c Author: Rudolf Marek r.marek@assembler.cz Date: Sun Oct 30 18:06:58 2011 +0100
Fix slow CAR execution introduced by 7c7d87182feb78cb2bc02fb3558bef56a41682c9
It is meant to be a address and not a dereference. Otherwise MTRR is filled with code and not with the address.
This is what I hate at most on the AT&T syntax. Instead of taking the address, it was a dereference. Not greatly visible, except I wondered why opcode is not 0xb4 but 0xa1 and it took another half an our to see it.
Change-Id: I6b339656024de8f6e6b3cde63b16b7ff5562d055 Signed-off-by: Rudolf Marek r.marek@assembler.cz
Build-Tested: build bot (Jenkins) at Sun Oct 30 21:25:01 2011, giving +1 Reviewed-By: Stefan Reinauer stefan.reinauer@coreboot.org at Sun Oct 30 21:02:23 2011, giving +2 Reviewed-By: Rudolf Marek r.marek@assembler.cz at Sun Oct 30 21:24:13 2011, giving +2 See http://review.coreboot.org/358 for details.
-gerrit