[PATCH] Enable or disable the power button in Kconfig

[Peter Stuge]

Please see the attached patch. I would like to especially ask those
who have worked on boards which use the 5536 to check if maybe their
board should select a different POWER_BUTTON_* now. Again, existing
behavior should be unchanged from previous except on ALIX.1.

Jens, please confirm if my understanding of the old vs. new
hurricane-lx board version vs. power button behavior is correct.

Thanks!

//Peter

[Aurélien]

On Fri, Oct 1, 2010 at 9:46 PM, Peter Stuge  wrote:
> Please see the attached patch. I would like to especially ask those
> who have worked on boards which use the 5536 to check if maybe their
> board should select a different POWER_BUTTON_* now. Again, existing
> behavior should be unchanged from previous except on ALIX.1.

Hi Peter,

I just run-tested this version, with power button disabled, on ALIX.1d, and
with the power jumper present on the board (factory default). It works
perfectly.

Thanks for this patch :)

Acked-by: Aurelien Guillaume

Best regards,

[Nathan Williams]

Peter Stuge wrote:
> Please see the attached patch. I would like to especially ask those
> who have worked on boards which use the 5536 to check if maybe their
> board should select a different POWER_BUTTON_* now. Again, existing
> behavior should be unchanged from previous except on ALIX.1.

Please make traverse/geos use POWER_BUTTON_DEFAULT_DISABLE.  There's a jumper like the Alix1.

Also, there's a typo in src/Kconfig:

+# The four POWER_BUTTON_DEFAULT_ENABLE, POWER_BUTTON_DEFAULT_DISABLE,
+# POWER_BUTTON_FORCE_ENABLE and POWER_BUTTON_FORCE_DISBALE options are

Regards,
Nathan

[PATCH] Enable or disable the power button in Kconfig

[Peter Stuge]

Nathan Williams wrote:
> make traverse/geos use POWER_BUTTON_DEFAULT_DISABLE
>
> typo

Thanks! Both are fixed locally.

//Peter

[Jens Rottmann]

Hi Peter,

sorry for the delay, was on vacation.

Nice new feature!  :)
> please confirm if my understanding of the old vs. new
> hurricane-lx board version vs. power button behavior is correct.

Yes, your patch correctly preserves current behavior.

However, I'd like to make use of your nice new feature and give the user
the option to enable the button after they have removed the jumper -
patch attached.

Thanks a lot!!
Jens

--- src/mainboard/lippert/hurricane-lx/Kconfig	(rev 5911 + Peter)
+++ src/mainboard/lippert/hurricane-lx/Kconfig	(working copy)
@@ -29,15 +29,16 @@
 config BOARD_OLD_REVISION
    bool "Board is old pre-3.0 revision"
    default n
-	select POWER_BUTTON_FORCE_DISABLE
+	select POWER_BUTTON_DEFAULT_DISABLE
    help
      Look on the bottom side for a number like 406-0001-30.  The last 2
      digits state the PCB revision (3.0 in this example).  For 2.0 or older
      boards choose Y, for 3.0 and newer say N.

-	  Old revision boards need a jumper shorting the power button to
-	  power on automatically. So we must disable the button's fail-safe
-	  function, or the board will shut down after 4 s.
+	  Old revision boards need a jumper shorting the power button to power on
+	  automatically.  You may enable the button only after this jumper has
+	  been removed.  New revision boards are not restricted in this way, the
+	  button is always enabled.

config POWER_BUTTON_FORCE_ENABLE
    def_bool y if !BOARD_OLD_REVISION

[Nils]

Hi Peter,
Op vrijdag 1 oktober 2010 21:46:10 schreef Peter Stuge:
> Please see the attached patch. I would like to especially ask those
> who have worked on boards which use the 5536 to check if maybe their
> board should select a different POWER_BUTTON_* now. Again, existing
> behavior should be unchanged from previous except on ALIX.1.

I tested your patch on the Wyse S50 (r5901) and it seems to work ok.
So:
Acked-by: Nils Jacobs

Thanks, Nils.

[PATCH] Enable or disable the power button in Kconfig

[Peter Stuge]

Jens Rottmann wrote:
> I'd like to make use of your nice new feature and give the user
> the option to enable the button after they have removed the jumper
> patch attached.

Thanks. I included your chane.

Nils wrote:
> I tested your patch on the Wyse S50 (r5901) and it seems to work ok.
> So:
> Acked-by: Nils Jacobs

Thanks! Commited as r5948

//Peter