Fix initial printk buffer address initialization. This was broken in r785 (move from explicit asm to implicit C) and unfortunately qemu never triggered the bug, only real hardware did.
Thanks to Ron for bisecting this.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Index: corebootv3-printk_buffer_addr_init/lib/console.c =================================================================== --- corebootv3-printk_buffer_addr_init/lib/console.c (Revision 856) +++ corebootv3-printk_buffer_addr_init/lib/console.c (Arbeitskopie) @@ -82,7 +82,9 @@
void printk_buffer_init(void) { - struct printk_buffer *buf = printk_buffer_addr(); + struct printk_buffer *buf = (struct printk_buffer *)PRINTK_BUF_ADDR_CAR; + global_vars()->printk_buffer = buf; + buf = printk_buffer_addr(); buf->len = PRINTK_BUF_SIZE_CAR - sizeof(struct printk_buffer); buf->readoffset = 0; buf->writeoffset = 0;
On 04.09.2008 16:42, ron minnich wrote:
Acked-by: Ronald G. Minnich rminnich@gmail.com
Not yet tested but it can't make it worse :-)
Thanks, r857.
Regards, Carl-Daniel
On Thu, Sep 4, 2008 at 8:36 AM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
On 04.09.2008 16:42, ron minnich wrote:
Acked-by: Ronald G. Minnich rminnich@gmail.com
Not yet tested but it can't make it worse :-)
Thanks, r857.
tested and working on dbe62!
ron
On 04.09.2008 18:16, ron minnich wrote:
On Thu, Sep 4, 2008 at 8:36 AM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
On 04.09.2008 16:42, ron minnich wrote:
Acked-by: Ronald G. Minnich rminnich@gmail.com
Not yet tested but it can't make it worse :-)
Thanks, r857.
tested and working on dbe62!
Thanks for testing this!
Regards, Carl-Daniel