[PATCH]kconfig

[Patrick Georgi]

Hi,

more changes to make kconfig's configs more similar to newconfig's:

DIMM_SUPPORT
APIC_ID_OFFSET
ACPI_SSDTX_NUM
IRQ_SLOT_COUNT
MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
    (msi/ms9185 has a device id of 0x1022, which would be AMD, but we
have a global vendor ID set for msi. which one is right? MSI's or AMD's?)
MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
MEM_TRAIN_SEQ
HAVE_ACPI_RESUME

It also removes HAVE_MOVNTI and IOAPIC from the compareboards report
(which also ends up on the list) as we deliberately diverged from
newconfig there (they're per-CPU or per-chipset now, so we can assume
that newconfig is incorrect there), and also MMX (a kconfig-only symbol)

Signed-off-by: Patrick Georgi

[Stefan Reinauer]

On 1/25/10 10:36 AM, Patrick Georgi wrote:
> --- src/mainboard/Kconfig	(revision 5050)
> +++ src/mainboard/Kconfig	(working copy)
> @@ -287,6 +287,11 @@
>    default "Roda"
>    depends on VENDOR_RODA
>
> +config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
> hex
> default 0x4352
> depends on VENDOR_RODA
>
> config MAINBOARD_VENDOR
>    string
>    default "Soyo"
> @@ -302,6 +307,11 @@
>    default "Supermicro"
>    depends on VENDOR_SUPERMICRO
>
> +config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
> hex
> default 0x15d9
> depends on VENDOR_SUPERMICRO
>
> config MAINBOARD_VENDOR
>    string
>    default "Technexion"

Is there a reason this is in mainboard/Kconfig?

It seems this would better go to the mainboard's Kconfig files... (and
for some mainboards, it does...)
> Index: src/mainboard/supermicro/h8dmr_fam10/Kconfig
>
> --- src/mainboard/supermicro/h8dmr_fam10/Kconfig	(revision 5050)
> +++ src/mainboard/supermicro/h8dmr_fam10/Kconfig	(working copy)
> @@ -136,3 +136,8 @@
>    bool
>    default n
>    depends on BOARD_SUPERMICRO_H8DMR_FAM10
>
> +config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
> hex
> default 0x1511
> depends on BOARD_SUPERMICRO_H8DMR_FAM10

I think we should stay consistent here.

Otherwise:

Acked-by: Stefan Reinauer

[Patrick Georgi]

Am 25.01.2010 11:31, schrieb Stefan Reinauer:
> > +config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
> > hex
> > default 0x15d9
> > depends on VENDOR_SUPERMICRO
> >
> > config MAINBOARD_VENDOR
> >    string
> >    default "Technexion"
>
> Is there a reason this is in mainboard/Kconfig?

VENDOR_ID appears for various vendors in that file. One could argue that
VENDOR_IDs don't belong in mainboard Kconfig files (that was the
intention behind moving them to src/mainboard/Kconfig, I guess), but
then, we have msi/ms9185 (with AMD vendor id)
> > Index: src/mainboard/supermicro/h8dmr_fam10/Kconfig
> >
> > --- src/mainboard/supermicro/h8dmr_fam10/Kconfig	(revision 5050)
> > +++ src/mainboard/supermicro/h8dmr_fam10/Kconfig	(working copy)
> > @@ -136,3 +136,8 @@
> >    bool
> >    default n
> >    depends on BOARD_SUPERMICRO_H8DMR_FAM10
> >
> > +config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
> > hex
> > default 0x1511
> > depends on BOARD_SUPERMICRO_H8DMR_FAM10
>
> I think we should stay consistent here.

This is the DEVICE_ID, those belong in the mainboard's Kconfig.

Patrick