[PATCH] Factor out common mptable code to mptable_init()

[Uwe Hermann]

See patch.

Uwe.

[PATCH] Factor out common mptable code to mptable_init()

[Stefan Reinauer]

On 10/23/10 3:34 PM, Uwe Hermann wrote:
> w.
>
> Fix a few productid entries, they were (partially) incorrect:
> DK8S2 (was "DK8X", copypaste)
> 939A785GMH (was "MAHOGANY", copypaste)
> X6DHE-G (was "X6DHE", incomplete board name)
> H8DME-2 (was "H8DMR", copypaste)
> H8QME-2+ (was "H8QME", incomplete board name)
> X6DHE-G2 (was "X6DHE", incomplete board name)
> X6DHR-iG2 (was "X6DHR-iG", incomplete board name)
> GA-M57SLI-S4 (was "M57SLI", incomplete board name)
> KINO-780AM2 (was "KINO", incomplete board name)
> DL145 G1 (was "DL145G1", small fix as per vendor website)
> DL145 G3 (was "TREX", wrong board name)
> DL165 G6 (was "HP DL165 G6", drop vendor)
> S2912 (was "S2895", copypaste)
> VT8454c (was "VIA VT8454C", drop vendor, lower-case "c")
> EPIA-N (was "P4DPE", copypaste)
> pc2500e (was "PC2500", incorrect name)
> S1850 (was "S2850", copy-paste)
> MS-7135 (was "MS7135")
> MS-9282 (was "MS9282")
> MS-9185 (was "MS9185")
> MS-9652 (was "K9ND MS-9652")
> Ultra 40 (was "ultra40")
> E326 (was "E325", copypaste)
> M4A785-M (was "TILAPIA", copypaste)
> P2B-D (was "ASUS P2B-D", drop vendor)
> P2B-DS (was "ASUS P2B-DS", drop vendor)

Can you use the coreboot mainboard name instead (truncated)? It would be
nice to get rid of those hardcodes and get some consistency instead

Stefan

[Uwe Hermann]

On Sat, Oct 23, 2010 at 04:54:21PM -0700, Stefan Reinauer wrote:
> > P2B-DS (was "ASUS P2B-DS", drop vendor)
>
> Can you use the coreboot mainboard name instead (truncated)? It would be
> nice to get rid of those hardcodes and get some consistency instead

Yes, I agree, but that's another patch. I should have probably left the
broken names in there for now, but I already started fixing them so I
included the fixes in the patch anyway.

Using the kconfig variable board name is definately the way to go, but
needs some more code and possibly some changes in board names, e.g.
we should probably drop the "(Fam10h)" suffix from board names for the
mptable, and also maybe drop any generic prefixes such as "ProLiant"
so that the actually useful part of the boardname ends up in the
mptable field.

Anyway, will take a look at that once this patch is merged.

Uwe.

[PATCH] Factor out common mptable code to mptable_init()

[Peter Stuge]

Uwe Hermann wrote:
> VT8454c (was "VIA VT8454C", drop vendor, lower-case "c")

VIA boards have names printed on them with all caps.

//Peter

[Uwe Hermann]

On Sun, Oct 24, 2010 at 05:08:01AM +0200, Peter Stuge wrote:
> Uwe Hermann wrote:
> > VT8454c (was "VIA VT8454C", drop vendor, lower-case "c")
>
> VIA boards have names printed on them with all caps.

Yeah, I know, vendors are inconsistent with their own board names even.
So far I've always gone with the names listed on their websites (but
even there they sometimes screw up. i.e. list multiple spellings).

Hm, I cannot even find this board listed on the VIA site right now, but
IIRC I saw it spelled as "VT8454c" at some point. Either way, I can also
leave the capital C if that's preferred. What about the actual patch?

Uwe.

[PATCH] Factor out common mptable code to mptable_init()

[Patrick Georgi]

Am 24.10.2010 00:34, schrieb Uwe Hermann:
> See patch.
>
> Uwe.

Acked-by: Patrick Georgi