New patch to review for coreboot: 471903a smsc/lpc47n227: Make early_serial usable

[Patrick Georgi]

Patrick Georgi ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1686

-gerrit

commit 471903aa259484c00043306a3ede818653189a4d
Author: Patrick Georgi 
Date:   Fri May 18 12:47:02 2012 +0200

smsc/lpc47n227: Make early_serial usable

It's used as #include "early_serial.c", but that's how all
    SuperIOs are done for now. This is the smallest necessary
    change to get things to run.

Change-Id: I90ee66b43c9677b86b1b5d6fcc8febfbe58d80dd
    Signed-off-by: Patrick Georgi 
---
 src/superio/smsc/lpc47n227/early_serial.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/superio/smsc/lpc47n227/early_serial.c b/src/superio/smsc/lpc47n227/early_serial.c
index 32bd3e3..a60dc48 100644
--- a/src/superio/smsc/lpc47n227/early_serial.c
+++ b/src/superio/smsc/lpc47n227/early_serial.c
@@ -41,10 +41,13 @@ static void pnp_exit_conf_state(device_t dev)
  * @param dev High 8 bits = Super I/O port, low 8 bits = logical device number.
  * @param iobase Base I/O port for the logical device.
  */
-void lpc47n227_pnp_set_iobase(device_t dev, u16 iobase)
+static void lpc47n227_pnp_set_iobase(device_t dev, u16 iobase)
 {
    /* LPC47N227 requires base ports to be a multiple of 4. */
+	/* it's not very useful to do an ASSERT here: if it trips,
+	 * there's no console to report it.
    ASSERT(!(iobase & 0x3));
+	*/

switch (dev & 0xFF) {
    case LPC47N227_PP:
@@ -73,7 +76,7 @@ void lpc47n227_pnp_set_iobase(device_t dev, u16 iobase)
  * @param dev High 8 bits = Super I/O port, low 8 bits = logical device number.
  * @param enable 0 to disable, anythig else to enable.
  */
-void lpc47n227_pnp_set_enable(device_t dev, int enable)
+static void lpc47n227_pnp_set_enable(device_t dev, int enable)
 {
    u8 power_register = 0, power_mask = 0, current_power, new_power;