Hi,
Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.
1 new defect(s) introduced to coreboot found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s)
** CID 1393458: (DEADCODE) /src/northbridge/intel/x4x/raminit_ddr23.c: 1685 in set_dradrb() /src/northbridge/intel/x4x/raminit_ddr23.c: 1720 in set_dradrb() /src/northbridge/intel/x4x/raminit_ddr23.c: 1743 in set_dradrb()
________________________________________________________________________________________________________ *** CID 1393458: (DEADCODE) /src/northbridge/intel/x4x/raminit_ddr23.c: 1685 in set_dradrb() 1679 1680 if (s->stacked_mode) { 1681 dual_channel_size = 0; 1682 } else if (size_me == 0) { 1683 dual_channel_size = MIN(size_ch0, size_ch1) * 2; 1684 } else {
CID 1393458: (DEADCODE) Execution cannot reach this statement: "if (size_ch0 == 0U) {
siz...". 1685 if (size_ch0 == 0) { 1686 /* ME needs ram on CH0 */ 1687 size_me = 0; 1688 /* TOTEST: bailout? */ 1689 } else { 1690 /* Set ME UMA size in MiB */ /src/northbridge/intel/x4x/raminit_ddr23.c: 1720 in set_dradrb() 1714 if (!(s->stacked_mode && size_ch0 != 0 && size_ch1 != 0)) { 1715 map |= 0x04; 1716 if (size_ch0 <= size_ch1) 1717 map |= 0x01; 1718 } 1719 } else {
CID 1393458: (DEADCODE) Execution cannot reach this statement: "if (s->stacked_mode == 0 &&...".
1720 if (s->stacked_mode == 0 && size_ch0 - size_me < size_ch1) 1721 map |= 0x04; 1722 } 1723 1724 MCHBAR8(0x110) = map; 1725 MCHBAR16(0x10e) = 0; /src/northbridge/intel/x4x/raminit_ddr23.c: 1743 in set_dradrb() 1737 if (size_ch0 > size_ch1) 1738 single_channel_offset = dual_channel_size / 2 1739 + single_channel_size; 1740 else 1741 single_channel_offset = dual_channel_size / 2; 1742 } else {
CID 1393458: (DEADCODE) Execution cannot reach this statement: "if (size_ch0 > size_ch1 && ...".
1743 if ((size_ch0 > size_ch1) && ((map & 0x7) == 4)) 1744 single_channel_offset = dual_channel_size / 2 1745 + single_channel_size; 1746 else 1747 single_channel_offset = dual_channel_size / 2 1748 + size_me;
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...