Re: [LinuxBIOS] r46 - in buildrom-devel: config/platforms packages/filo/conf packages/kernel packages/kernel/conf packages/linuxbios scripts
On Wed, Oct 24, 2007 at 04:56:47PM +0200, svn@openbios.org wrote:
Modified: buildrom-devel/config/platforms/Config.in
--- buildrom-devel/config/platforms/Config.in 2007-10-18 00:10:57 UTC (rev 45) +++ buildrom-devel/config/platforms/Config.in 2007-10-24 14:56:47 UTC (rev 46) @@ -34,5 +34,8 @@ bool "Tyan S2891" select PLATFORM
+config PLATFORM_SERENGETI_CHEETAH
bool "AMD Serengeti_Cheetah"
No underscore needed here, I think.
Added: buildrom-devel/config/platforms/serengeti_cheetah.conf
--- buildrom-devel/config/platforms/serengeti_cheetah.conf (rev 0) +++ buildrom-devel/config/platforms/serengeti_cheetah.conf 2007-10-24 14:56:47 UTC (rev 46) @@ -0,0 +1,39 @@ +# Support for the AMD Serengeti_Cheetah Platform
Ditto.
Modified: buildrom-devel/packages/linuxbios/generic-linuxbios.mk
--- buildrom-devel/packages/linuxbios/generic-linuxbios.mk 2007-10-18 00:10:57 UTC (rev 45) +++ buildrom-devel/packages/linuxbios/generic-linuxbios.mk 2007-10-24 14:56:47 UTC (rev 46) @@ -9,9 +9,18 @@ LINUXBIOS_BASE_DIR=svn LINUXBIOS_URL=svn://openbios.org/repos/trunk/LinuxBIOSv2 LINUXBIOS_TARBALL=linuxbios-svn-$(LINUXBIOS_TAG).tar.gz -LINUXBIOS_PAYLOAD_TARGET=/tmp/payload.elf +LINUXBIOS_PAYLOAD_TARGET=$(LINUXBIOS_BUILD_DIR)/payload.elf TARGET_ROM = $(LINUXBIOS_VENDOR)-$(LINUXBIOS_BOARD).rom
+# Make sure we have the tools we need to accomplish this +HAVE_IASL:=$(call find-tool,iasl)
+ifeq ($(HAVE_IASL),n) +$(error To build LinuxBIOS, you need to install the 'iasl' tool) +endif
This is not true for all boards, maybe we should make this a requirement only for those boards which actually require it.
Another tool to check for might be bzip2 btw, it's not guaranteed to be installed by default everywhere.
Uwe.
On 24/10/07 17:27 +0200, Uwe Hermann wrote:
On Wed, Oct 24, 2007 at 04:56:47PM +0200, svn@openbios.org wrote:
Modified: buildrom-devel/config/platforms/Config.in
--- buildrom-devel/config/platforms/Config.in 2007-10-18 00:10:57 UTC (rev 45) +++ buildrom-devel/config/platforms/Config.in 2007-10-24 14:56:47 UTC (rev 46) @@ -34,5 +34,8 @@ bool "Tyan S2891" select PLATFORM
+config PLATFORM_SERENGETI_CHEETAH
bool "AMD Serengeti_Cheetah"No underscore needed here, I think.
Thats what its called in LinuxBIOS, so we tried to stick with the same names. I agree thats not always the best policy, but the Serengeti-Cheetah name is confusing anyway, so we went with this.
Added: buildrom-devel/config/platforms/serengeti_cheetah.conf
--- buildrom-devel/config/platforms/serengeti_cheetah.conf (rev 0) +++ buildrom-devel/config/platforms/serengeti_cheetah.conf 2007-10-24 14:56:47 UTC (rev 46) @@ -0,0 +1,39 @@ +# Support for the AMD Serengeti_Cheetah Platform
Ditto.
Modified: buildrom-devel/packages/linuxbios/generic-linuxbios.mk
--- buildrom-devel/packages/linuxbios/generic-linuxbios.mk 2007-10-18 00:10:57 UTC (rev 45) +++ buildrom-devel/packages/linuxbios/generic-linuxbios.mk 2007-10-24 14:56:47 UTC (rev 46) @@ -9,9 +9,18 @@ LINUXBIOS_BASE_DIR=svn LINUXBIOS_URL=svn://openbios.org/repos/trunk/LinuxBIOSv2 LINUXBIOS_TARBALL=linuxbios-svn-$(LINUXBIOS_TAG).tar.gz -LINUXBIOS_PAYLOAD_TARGET=/tmp/payload.elf +LINUXBIOS_PAYLOAD_TARGET=$(LINUXBIOS_BUILD_DIR)/payload.elf TARGET_ROM = $(LINUXBIOS_VENDOR)-$(LINUXBIOS_BOARD).rom
+# Make sure we have the tools we need to accomplish this +HAVE_IASL:=$(call find-tool,iasl)
+ifeq ($(HAVE_IASL),n) +$(error To build LinuxBIOS, you need to install the 'iasl' tool) +endif
This is not true for all boards, maybe we should make this a requirement only for those boards which actually require it.
This target is only built by those targets that do require it.
Another tool to check for might be bzip2 btw, it's not guaranteed to be installed by default everywhere.
There is actually a long list of tools we should check for by default, but that belongs somewhere else. I put this check in because this is a very specific tool that most people don't have by default.
But thats also why I made find-cool a function - if we find other tools we need, then we should not be afraid to add them.
Jordan
On Wed, Oct 24, 2007 at 09:50:25AM -0600, Jordan Crouse wrote:
On 24/10/07 17:27 +0200, Uwe Hermann wrote:
On Wed, Oct 24, 2007 at 04:56:47PM +0200, svn@openbios.org wrote:
Modified: buildrom-devel/config/platforms/Config.in
--- buildrom-devel/config/platforms/Config.in 2007-10-18 00:10:57 UTC (rev 45) +++ buildrom-devel/config/platforms/Config.in 2007-10-24 14:56:47 UTC (rev 46) @@ -34,5 +34,8 @@ bool "Tyan S2891" select PLATFORM
+config PLATFORM_SERENGETI_CHEETAH
bool "AMD Serengeti_Cheetah"No underscore needed here, I think.
Thats what its called in LinuxBIOS, so we tried to stick with the same names. I agree thats not always the best policy, but the Serengeti-Cheetah name is confusing anyway, so we went with this.
I think this depends where the name is used. In C struct names or as variable names, directory names etc. some adaptations might be necessary. For use in comments or README or other texts we should, in general, use the "official" correct name as per vendor (website etc).
This is not true for all boards, maybe we should make this a requirement only for those boards which actually require it.
This target is only built by those targets that do require it.
OK, that's no problem then.
But thats also why I made find-cool a function - if we find other tools we need, then we should not be afraid to add them.
Yep.
Uwe.
Uwe Hermann wrote:
+# Make sure we have the tools we need to accomplish this +HAVE_IASL:=$(call find-tool,iasl)
+ifeq ($(HAVE_IASL),n) +$(error To build LinuxBIOS, you need to install the 'iasl' tool) +endif
This is not true for all boards, maybe we should make this a requirement only for those boards which actually require it.
It will be true pretty soon though I guess.
Stefan
-
Jordan Crouse -
Stefan Reinauer -
Uwe Hermann