v3 \r\n

[Myles Watson]

Is there any time when we really want \r\n?

I found some \r in halt and catch fire that seemed on purpose, but all of
the \r\n locations seem to be mistakes (they are mixed with \n in the same
file.)

It seems like a trivial patch to remove them all so that we're consistent,
but If there's a good reason for them ...

Thanks,
Myles

[ron minnich]

On Tue, Oct 28, 2008 at 10:08 AM, Myles Watson  wrote:
> Is there any time when we really want \r\n?
>
> I found some \r in halt and catch fire that seemed on purpose, but all of
> the \r\n locations seem to be mistakes (they are mixed with \n in the same
> file.)

no, that is romcc legacy. Kill it.

ron

[Carl-Daniel Hailfinger]

On 28.10.2008 18:08, Myles Watson wrote:
> Is there any time when we really want \r\n?
>
> I found some \r in halt and catch fire that seemed on purpose, but all of
> the \r\n locations seem to be mistakes (they are mixed with \n in the same
> file.)
>
> It seems like a trivial patch to remove them all so that we're consistent,
> but If there's a good reason for them ...

Please kill them all.

Regards,
Carl-Daniel

[Jordan Crouse]

On 28/10/08 11:08 -0600, Myles Watson wrote:
> Is there any time when we really want \r\n?
>
> I found some \r in halt and catch fire that seemed on purpose, but all of
> the \r\n locations seem to be mistakes (they are mixed with \n in the same
> file.)
>
> It seems like a trivial patch to remove them all so that we're consistent,
> but If there's a good reason for them ...

I think they should all be \n.  If we need the \r for the debug output,
then the extra character should be added in the output function.

Jordan

[Myles Watson]

Rev 958.

Thanks,
Myles