[LinuxBIOS] [PATCH] flashrom: Move code into C files

[Uwe Hermann]

This is the first in a row of many cleanup patches for flashrom.

Step 1: Move all code into *.c files, not *.h files. I don't see a
reason to have them in header files.

Uwe.

[Stefan Reinauer]

* Uwe Hermann  [070823 09:47]:
> This is the first in a row of many cleanup patches for flashrom.
>
> Step 1: Move all code into *.c files, not *.h files. I don't see a
> reason to have them in header files.

I like this a lot!
> Signed-off-by: Uwe Hermann

Acked-by: Stefan Reinauer

[Uwe Hermann]

On Thu, Aug 23, 2007 at 10:22:13AM +0200, Stefan Reinauer wrote:
> > Signed-off-by: Uwe Hermann
>
> Acked-by: Stefan Reinauer

Thanks, r2745.

Uwe.

[Peter Stuge]

On Thu, Aug 23, 2007 at 09:47:54AM +0200, Uwe Hermann wrote:
> Step 1: Move all code into *.c files, not *.h files. I don't see a
> reason to have them in header files.

Good stuff - but what about the inline? Might be nice to keep that
for some functions that are called frequently while programming?

//Peter

[Uwe Hermann]

On Thu, Aug 23, 2007 at 10:35:21AM +0200, Peter Stuge wrote:
> On Thu, Aug 23, 2007 at 09:47:54AM +0200, Uwe Hermann wrote:
> > Step 1: Move all code into *.c files, not *.h files. I don't see a
> > reason to have them in header files.
>
> Good stuff - but what about the inline? Might be nice to keep that
> for some functions that are called frequently while programming?

Hm, good question. In general I think the inline is not really needed.
Do you think this might be important for the time-critical parts in
flashrom? Could be, but I doubt this code is _that_ time-critical.

Uwe.

[ron minnich]

On 8/23/07, Uwe Hermann  wrote:
> On Thu, Aug 23, 2007 at 10:35:21AM +0200, Peter Stuge wrote:
> > Good stuff - but what about the inline? Might be nice to keep that
> > for some functions that are called frequently while programming?
>
> Hm, good question. In general I think the inline is not really needed.
> Do you think this might be important for the time-critical parts in
> flashrom? Could be, but I doubt this code is _that_ time-critical.

inline is really getting over-used nowadays.  I doubt we need it here.

thanks

ron

[Stefan Reinauer]

* ron minnich  [070826 05:31]:
> > Hm, good question. In general I think the inline is not really needed.
> > Do you think this might be important for the time-critical parts in
> > flashrom? Could be, but I doubt this code is _that_ time-critical.
>
> inline is really getting over-used nowadays.  I doubt we need it here.

In fact, if the compiler sees fit, it will inline without an additional
keyword. Otoh, the inline keyword does not guarantee you at all that
anything is inlined.

Stefan