Infinite loop in cbfstool

[Myles Watson]

If you try to add a payload that is larger than the available space, and not
at a specific location (location == 0), it hangs in an infinite loop.  It's
something like:

if contentsize <= length or location is right {
    insert record
}
if location == 0
    continue.

I wasn't sure where the best place to put the increment of current was.  Do
you have any suggestions?

Thanks,
Myles

[Patrick Georgi]

Am Freitag, den 18.09.2009, 11:36 -0600 schrieb Myles Watson:
> If you try to add a payload that is larger than the available space, and not
> at a specific location (location == 0), it hangs in an infinite loop.  It's
> something like:

Good find, thanks!
> if contentsize <= length or location is right {
>    insert record
> }
> if location == 0
>    continue.
>
> I wasn't sure where the best place to put the increment of current was.  Do
> you have any suggestions?

Primitive solution: duplicate the increment? (see patch)

Signed-off-by: Patrick Georgi

[Myles Watson]

> > I wasn't sure where the best place to put the increment of current was.
>
> Do
> > you have any suggestions?
>
> Primitive solution: duplicate the increment? (see patch)

That stops the infinite loop, but silently fails to add the payload.  That's
where I first thought of putting it too.

Thanks,
Myles