PCI tree topology regression

[Michal Zygowski]

Hello coreboot community,

It seems like recent changes to PCI introduced regression. Building
coreboot for PC Engines apu2 results in unbootable image halting at:

get_pbus: dev is NULL!

occuring in dev_finalize_chips during boot state machine write_table
entry. I suspect it may be related to devicetree structure which is
slightly different than on mainboards with Intel processors.

Latest known working commit for me was cd26f08. Bisecting mentioned
commit against current master (afe15f0) led me towards:

```
8712aa107f4a4a0f64684e00c03eb2ec0d8baf6b

device/pci_device: Do not break tree topology
   
    Fix regression introduced with commit
       ad7674e device: Introduce pcidev_on_root() and friends
...
```

Any ideas what can I do to fix it, or what is the cause? I would
appreciate Your help.

Best regards,

[Kyösti Mälkki]

On Mon, Jan 21, 2019 at 1:49 PM Michal Zygowski 
wrote:
> Hello coreboot community,
>
> It seems like recent changes to PCI introduced regression. Building
> coreboot for PC Engines apu2 results in unbootable image halting at:
>
> get_pbus: dev is NULL!

Oh my, sorry about this. I had the incomplete fix in my local tree already,
but have not extended it yet to cover all AGESA/binaryPI. I'll go through
the various places where NULL check is required. The error is harsh, but we
wan't to track down the places where caller is ignoring the cases where PCI
devices are disabled runtime.
> Any ideas what can I do to fix it, or what is the cause? I would
> appreciate Your help.

https://review.coreboot.org/c/coreboot/+/31026

Kyösti

[Michal Zygowski]

Thank You Kyösti for Your immediate response and help.

Your patch fixes the issue. Many thanks.

Best regards,
Michał

On 21.01.2019 13:32, Kyösti Mälkki wrote:
> On Mon, Jan 21, 2019 at 1:49 PM Michal Zygowski
> <[e-mail] > wrote:
> Hello coreboot community,
>
> It seems like recent changes to PCI introduced regression. Building
> coreboot for PC Engines apu2 results in unbootable image halting at:
>
> get_pbus: dev is NULL!
>
>
> Oh my, sorry about this. I had the incomplete fix in my local tree
> already, but have not extended it yet to cover all AGESA/binaryPI.
> I'll go through the various places where NULL check is required. The
> error is harsh, but we wan't to track down the places where caller is
> ignoring the cases where PCI devices are disabled runtime.
> Any ideas what can I do to fix it, or what is the cause? I would
> appreciate Your help.
>
>
> https://review.coreboot.org/c/coreboot/+/31026
>
> Kyösti
>
> coreboot mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]