Re: [coreboot] [v2] r4360 - in trunk/coreboot-v2/src/mainboard: a-trend/atc-6220 a-trend/atc-6240 abit/be6-ii_v2_0 advantech/pcm-5820 amd/db800 amd/norwich amd/rumba artecgroup/dbe61 asi/mb_5blgp asi/mb_5blmp asus/mew-am asus/mew-vm asus/p2b asus/p2b
Modified: trunk/coreboot-v2/src/mainboard/a-trend/atc-6220/Options.lb
=================================================================== --- trunk/coreboot-v2/src/mainboard/a-trend/atc-6220/Options.lb 2009-06-17 15:33:57 UTC (rev 4359) +++ trunk/coreboot-v2/src/mainboard/a-trend/atc-6220/Options.lb 2009-06-17 16:38:43 UTC (rev 4360) @@ -20,6 +20,7 @@
uses HAVE_MP_TABLE uses CONFIG_CBFS +uses CONFIG_USE_INIT uses HAVE_PIRQ_TABLE uses USE_FALLBACK_IMAGE uses HAVE_FALLBACK_BOOT
Modified: trunk/coreboot-v2/src/mainboard/a-trend/atc-6240/Options.lb
--- trunk/coreboot-v2/src/mainboard/a-trend/atc-6240/Options.lb 2009-06-17 15:33:57 UTC (rev 4359) +++ trunk/coreboot-v2/src/mainboard/a-trend/atc-6240/Options.lb 2009-06-17 16:38:43 UTC (rev 4360) @@ -20,6 +20,7 @@
uses HAVE_MP_TABLE uses CONFIG_CBFS +uses CONFIG_USE_INIT uses HAVE_PIRQ_TABLE uses USE_FALLBACK_IMAGE uses HAVE_FALLBACK_BOOT
This patch made me want include files for uses clauses. There is a lot of repitition.
Thanks, Myles
the whole uses thing was something that seemed a good idea at the time. I've come to the conclusion that it is likely a bad idea. Maybe we want a patch that just eliminates the need for uses.
ron
the whole uses thing was something that seemed a good idea at the time. I've come to the conclusion that it is likely a bad idea. Maybe we want a patch that just eliminates the need for uses.
Since I wasn't around for the discussion, could you help me understand why it was a good idea at the time?
Thanks, Myles
On Wed, Jun 17, 2009 at 9:48 AM, Myles Watsonmylesgw@gmail.com wrote:
the whole uses thing was something that seemed a good idea at the time. I've come to the conclusion that it is likely a bad idea. Maybe we want a patch that just eliminates the need for uses.
Since I wasn't around for the discussion, could you help me understand why it was a good idea at the time?
in v1 we had a huge number of overlapping, identical options because it was so easy to just define and use one. It was a mess. We decided to shoot for a bit more discipline in v2. We overshot the mark.
ron
-
Myles Watson -
ron minnich