See patch
On 3/21/10 11:17 PM, Stefan Reinauer wrote:
This patch makes util/vgabios use the coreboot version of x86emu and allows
svn rm util/vgabios/x86emu
The next step would be to make it use YABEL, too.
The benefit of this first step is that we reduce code duplication by 17k lines (and get all the x86emu fixes that made it into coreboot's x86emu but not into vgabios' copy)
Stefan
On 3/21/10 11:17 PM, Stefan Reinauer wrote:
This patch makes util/vgabios use the coreboot version of x86emu and allows
svn rm util/vgabios/x86emu
The next step would be to make it use YABEL, too.
Signed-off-by: Stefan Reinauer stepan@coresystems.de
It also needs this guard added to the coreboot x86emu copy to make sure the printf redefine only occurs in coreboot:
--- src/devices/oprom/x86emu/debug.h (revision 5263) +++ src/devices/oprom/x86emu/debug.h (working copy) @@ -42,8 +42,10 @@
/*---------------------- Macros and type definitions ----------------------*/
+#ifdef CONFIG_DEFAULT_CONSOLE_LOGLEVEL /* printf is not available in coreboot... use printk */ #define printf(x...) printk(BIOS_DEBUG, x) +#endif
/* checks to be enabled for "runtime" */
On Sun, 21 Mar 2010 23:17:08 +0100, Stefan Reinauer stepan@coresystems.de wrote:
See patch
Always good to get rid of code duplication.
Acked-by: Joseph Smith joe@settoplinux.org