[PATCH] Kconfig HT

[mylesgw]

There's no reason for a board without HyperTransport to compile it in.  This
patch removes it (saving 1K after compression.)

I would have liked to set HYPERTRANSPORT_PLUGIN_SUPPORT the same way, but
couldn't figure out how.  I don't think plugin support for HT makes sense...

kbuildall tested.

Signed-off-by: Myles Watson

Thanks,
Myles

[Patrick Georgi]

Am Donnerstag, den 24.09.2009, 08:19 -0600 schrieb mylesgw:
> There's no reason for a board without HyperTransport to compile it in.
> This patch removes it (saving 1K after compression.)
>
> I would have liked to set HYPERTRANSPORT_PLUGIN_SUPPORT the same way,

which way?
would adding "select HYPERTRANSPORT_PLUGIN_SUPPORT" to all HT aware
northbridges work for you?

--- svn.orig/src/devices/Makefile.inc
+++ svn/src/devices/Makefile.inc
@@ -2,7 +2,9 @@ obj-y += device.o
 obj-y += root_device.o
 obj-y += device_util.o
 obj-y += pci_device.o
-obj-y += hypertransport.o
+ifdef CONFIG_HT_CHAIN_UNITID_BASE
+       obj-y += hypertransport.o
+endif

maybe replace that with
obj-$(CONFIG_HT_CHAIN_UNITID_BASE) += hypertransport.o?
or rather use HYPERTRANSPORT_PLUGIN_SUPPORT, once it's defined, but the
pattern still applies..?
> Signed-off-by: Myles Watson

Acked-by: Patrick Georgi

[mylesgw]

On Thu, Sep 24, 2009 at 8:32 AM, Patrick Georgi wrote:
> would adding "select HYPERTRANSPORT_PLUGIN_SUPPORT" to all HT aware
> northbridges work for you?

It did after I switched the order of the Kconfig files in src/Kconfig.  If
devices came before northbridge I couldn't get it to work.
> +ifdef CONFIG_HT_CHAIN_UNITID_BASE
>   obj-y += hypertransport.o
>
> +endif
>
> maybe replace that with
> obj-$(CONFIG_HT_CHAIN_UNITID_BASE) += hypertransport.o?
> or rather use HYPERTRANSPORT_PLUGIN_SUPPORT, once it's defined, but the
> pattern still applies..?

Yes.  I couldn't do it with HT_CHAIN_UNITID_BASE since it wasn't boolean.
> > Signed-off-by: Myles Watson
>
> Acked-by: Patrick Georgi

Rev. 4670.

Thanks,
Myles