[LinuxBIOS] [PATCH] Add K8T890CE support

[Rudolf Marek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello again,

I fixed what Uwe suggested. Many thanks. Here comes updated version.
The ROM strap code moved to northbridge, where it belongs.

Question is where to put the vt8237r_bridge.c file. Correy suggest that it
belongs to NB, perhaps this device is some kind of CPU-PCI bridge...

I dont know...

This patch adds support for K8T890CE northbridge.

Signed-off-by: Rudolf Marek

Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHER8T3J9wPJqZRNURAsnWAJ9pK4HXfQcuMXTvxq/TwKsiMJAYBACgiUEa
RTo+uJJ+YKSHea/LG1VAUjg=
=U38i
-----END PGP SIGNATURE-----

[Stefan Reinauer]

* Rudolf Marek  [071013 21:40]:

which directory should these files go into?
> Index: romstrap.inc
>
> --- romstrap.inc	(revision 0)
> +++ romstrap.inc	(revision 0)
> @@ -0,0 +1,60 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2004 Tyan Computer
> Written by Yinghai Lu  for Tyan Computer.
> (C) 2007 Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by
> the Free Software Foundation; either version 2 of the License, or
> (at your option) any later version.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +/* this file constructs the ROM strap table for K8T890 */
>
> +.section ".romstrap", "a", @progbits
>
> +.globl __romstrap_start 
> +.globl __romstrap_end
>
> +__romstrap_start:
>
> +/* Bellow are some Dev0 Func2 HT control registers values,
> depending on strap pin, one of bellow line is used */
>
> +tblpointer:
> +.long 0x504400AA, 0x61970FC2	//;200M
> +.long 0x504400AA, 0x61970FC2	//;400M
> +.long 0x504400AA, 0x61970FC2	//;600M
> +.long 0x504400AA, 0x61970FC2	//;800M
> +.long 0x504400AA, 0x61970FC2	//;1000M
> +.long 0x0
> +.long 0x0
> +.long 0x0
> +.long 0x0
> +.long 0x0
> +.long 0x0
> +.long 0x0
> +.long 0x0
> +.long 0x0
> +.long 0x0
>
> +/* the pointer to above table should be at 0xffffd,
> the table itself MUST be aligned to 128B it seems! */
>
> +.long tblpointer - 0xFFF00000
>
> +__romstrap_end:
>
> +.previous
> Index: Config.lb
> ===================================================================
> --- Config.lb	(revision 0)
> +++ Config.lb	(revision 0)
> @@ -0,0 +1,6 @@
> +driver k8t890_ctrl.o
> +driver k8t890_dram.o
> +driver k8t890_host.o
> +driver k8t890_host_ctrl.o
> +driver k8t890_pcie.o
> +driver k8t890_traf_ctrl.o
> Index: k8t890_host.c
> ===================================================================
> --- k8t890_host.c	(revision 0)
> +++ k8t890_host.c	(revision 0)
> @@ -0,0 +1,46 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2007 Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License v2 as published by
> the Free Software Foundation.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +#include <device/device.h>
> +#include <device/pci.h>
> +#include <device/pci_ops.h>
> +#include <device/pci_ids.h>
> +#include <console/console.h>
>
> +#include "k8t890.h"
>
> +static void host_enable(struct device *dev)
> +{
> /* multiple function control */
> pci_write_config8(dev, K8T890_MULTIPLE_FN_EN, 0x01);
>
> +}
>
> +static struct device_operations host_ops = {
> .read_resources = pci_dev_read_resources,
> .set_resources = pci_dev_set_resources,
> .enable_resources = pci_dev_enable_resources,
> .enable = host_enable,
> .ops_pci = 0,
>
> +};
>
> +static struct pci_driver northbridge_driver __pci_driver = {
> .ops = &host_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_0,
>
> +};
> Index: k8t890_pcie.c
> ===================================================================
> --- k8t890_pcie.c	(revision 0)
> +++ k8t890_pcie.c	(revision 0)
> @@ -0,0 +1,167 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2007 Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License v2 as published by
> the Free Software Foundation.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +#include <console/console.h>
> +#include <device/device.h>
> +#include <device/pci.h>
> +#include <device/pciexp.h>
> +#include <device/pci_ops.h>
> +#include <device/pci_ids.h>
>
> +void peg_init(struct device *dev)
> +{
> u8 reg;
> printk_debug("Configuring PCIe PEG\n");
> dump_south(dev);
> /* disable link */
> reg = pci_read_config8(dev, 0x50);
> pci_write_config8(dev, 0x50, reg | 0x10);
> /* award has 0xb VIA recomends 0x4 */
> pci_write_config8(dev, 0xe1, 0xb);
> /*
>   pci_write_config8(dev, 0xe2, 0x0);
>   pci_write_config8(dev, 0xe3, 0x92);
> */
> /* disable scrambling bit 6 to 1 */
> pci_write_config8(dev, 0xc0, 0x43);
> /* set replay timer limit */
> pci_write_config8(dev, 0xb1, 0xf0);
> /* bit0=1 SDP (Start DLLP) always at Lane0. */
> reg = pci_read_config8(dev, 0xb8);
> pci_write_config8(dev, 0xb8, reg | 0x1);
> /*  downstream wait and Upstream Checking Malformed TLP through
>   "Byte Enable Rule" And "Over 4K Boundary Rule" */
> reg = pci_read_config8(dev, 0xa4);
> pci_write_config8(dev, 0xa4, reg | 0x30);
> /* enable link */
> reg = pci_read_config8(dev, 0x50);
> pci_write_config8(dev, 0x50, reg & ~0x10);
> /* retrain link */
> reg = pci_read_config8(dev, 0x50);
> pci_write_config8(dev, 0x50, reg | 0x20);
> reg = pci_read_config8(dev, 0x3e);
> reg |= 0x40;
> /* bus reset */
> pci_write_config8(dev, 0x3e, reg);
> reg = pci_read_config8(dev, 0x3e);
> reg &= ~0x40;
> /* clear reset */
> pci_write_config8(dev, 0x3e, reg);
> dump_south(dev);
>
> +}
>
> +void pcie_init(struct device *dev)
> +{
> u8 reg;
> printk_debug("Configuring PCIe PEXs\n");
> dump_south(dev);
> /* disable link */
> reg = pci_read_config8(dev, 0x50);
> pci_write_config8(dev, 0x50, reg | 0x10);
> /* award has 0xb VIA recomends 0x4 */
> pci_write_config8(dev, 0xe1, 0xb);
> /* set replay timer limit */
> pci_write_config8(dev, 0xb1, 0xf0);
> /* enable link */
> reg = pci_read_config8(dev, 0x50);
> pci_write_config8(dev, 0x50, reg & ~0x10);
> /* retrain */
> reg = pci_read_config8(dev, 0x50);
> pci_write_config8(dev, 0x50, reg | 0x20);
> reg = pci_read_config8(dev, 0x3e);
> reg |= 0x40;
> /* bus reset */
> pci_write_config8(dev, 0x3e, reg);
> reg = pci_read_config8(dev, 0x3e);
> reg &= ~0x40;
> /* clear reset */
> pci_write_config8(dev, 0x3e, reg);
> dump_south(dev);
>
> +}
>
> +static struct device_operations peg_ops = {
> .read_resources = pci_bus_read_resources,
> .set_resources = pci_dev_set_resources,
> .enable_resources = pci_bus_enable_resources,
> .enable = peg_init,
> .scan_bus = pciexp_scan_bridge,
> .reset_bus = pci_bus_reset,
> .ops_pci = 0,
>
> +};
>
> +static struct device_operations pcie_ops = {
> .read_resources = pci_bus_read_resources,
> .set_resources = pci_dev_set_resources,
> .enable_resources = pci_bus_enable_resources,
> .enable = pcie_init,
> .scan_bus = pciexp_scan_bridge,
> .reset_bus = pci_bus_reset,
> .ops_pci = 0,
>
> +};
>
> +static struct pci_driver northbridge_driver __pci_driver = {
> .ops = &peg_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_PEG,
>
> +};
>
> +static struct pci_driver pcie_drvd3f0 __pci_driver = {
> .ops = &pcie_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_PEX0,
>
> +};
>
> +static struct pci_driver pcie_drvd3f1 __pci_driver = {
> .ops = &pcie_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_PEX1,
>
> +};
>
> +static struct pci_driver pcie_drvd3f2 __pci_driver = {
> .ops = &pcie_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_PEX2,
>
> +};
>
> +static struct pci_driver pcie_drvd3f3 __pci_driver = {
> .ops = &pcie_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_PEX3,
>
> +};
> Index: k8t890_traf_ctrl.c
> ===================================================================
> --- k8t890_traf_ctrl.c	(revision 0)
> +++ k8t890_traf_ctrl.c	(revision 0)
> @@ -0,0 +1,124 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2007 Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License v2 as published by
> the Free Software Foundation.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +#include <device/device.h>
> +#include <device/pci.h>
> +#include <device/pci_ops.h>
> +#include <device/pci_ids.h>
> +#include <console/console.h>
>
> +#include "k8t890.h"
>
> +void mmconfig_set_resources(device_t dev)
> +{
> struct resource *resource;
> u8 reg;
> resource = find_resource(dev, K8T890_MMCONFIG_MBAR);
> if (resource) {
> report_resource_stored(dev, resource, "<mmconfig>");
> /* Remember this resource has been stored */
> resource->flags |= IORESOURCE_STORED;
> pci_write_config8(dev, K8T890_MMCONFIG_MBAR,
> 		  (resource->base >> 28));
> reg = pci_read_config8(dev, 0x60);
> reg |= 0x3;
> /* enable MMCONFIG decoding */
> pci_write_config8(dev, 0x60, reg);
> }
> pci_dev_set_resources(dev);
>
> +}
>
> +static void apic_mmconfig_read_resources(device_t dev)
> +{
> struct resource *res;
> pci_dev_read_resources(dev);
> res = new_resource(dev, 0x40);
> /* NB APIC fixed to this addr */
> res->base = K8T890_APIC_BASE;
> res->size = 256;
> res->limit = res->base + res->size - 1;
> res->align = 8;
> res->gran = 8;
> res->flags = IORESOURCE_MEM | IORESOURCE_FIXED |
>    IORESOURCE_STORED | IORESOURCE_ASSIGNED;
> /* Add a MMCONFIG resource */
> res = new_resource(dev, K8T890_MMCONFIG_MBAR);
> res->size = 256 * 1024 * 1024;
> res->align = log2(res->size);
> res->gran = log2(res->size);
> res->limit = 0xffffffff;	/* 4G */
> res->flags = IORESOURCE_MEM;
>
> +}
>
> +static void traf_ctrl_enable(struct device *dev)
> +{
> volatile u32 *apic;
> u32 data;
> /* enable D3F1-D3F3, no device2 redirect, enable just one device behind
>   bridge device 2 and device 3) */
> pci_write_config8(dev, 0x60, 0x88);
> /* will enable MMCONFIG later */
> pci_write_config8(dev, 0x64, 0x23);
> /* no extended RCRB Base Address */
> pci_write_config8(dev, 0x62, 0x00);
> /*offset80 ->95 bit 4 in 1 in award */
> /* enable APIC, to K8T890_APIC_BASE */
> pci_write_config8(dev, 0x41, 0x00);
> pci_write_config8(dev, 0x40, 0x8c);
> /* BT_INTR  enable, APIC Nonshare Mode Enable */
> pci_write_config8(dev, 0x42, 0x5);
> apic = (u32 *) K8T890_APIC_BASE;
> /* set APIC to FSB transported messages */
> apic[0] = 3;
> data = apic[4];
> apic[4] = (data & 0xFFFFFE) | 1;
> /* set APIC ID */
> apic[0] = 0;
> data = apic[4];
> apic[4] = (data & 0xF0FFFF) | (K8T890_APIC_ID << 24);
>
> +}
>
> +static struct device_operations traf_ctrl_ops = {
> .read_resources = apic_mmconfig_read_resources,
> .set_resources = mmconfig_set_resources,
> .enable_resources = pci_dev_enable_resources,
> .enable = traf_ctrl_enable,
> .ops_pci = 0,
>
> +};
>
> +static struct pci_driver northbridge_driver __pci_driver = {
> .ops = &traf_ctrl_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_5,
>
> +};
> Index: romstrap.lds
> ===================================================================
> --- romstrap.lds	(revision 0)
> +++ romstrap.lds	(revision 0)
> @@ -0,0 +1,30 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2007 AMD
> Written by Yinghai Lu  for AMD.
> Modified for K8T890 ROM strap by Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by
> the Free Software Foundation; either version 2 of the License, or
> (at your option) any later version.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +SECTIONS {
> . = (_ROMBASE + ROM_IMAGE_SIZE - 0x2c) - (__romstrap_end - __romstrap_start);
> .romstrap (.): {
> *(.romstrap)
> }
>
> +}
> Index: k8t890_host_ctrl.c
> ===================================================================
> --- k8t890_host_ctrl.c	(revision 0)
> +++ k8t890_host_ctrl.c	(revision 0)
> @@ -0,0 +1,65 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2007 Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License v2 as published by
> the Free Software Foundation.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +#include <device/device.h>
> +#include <device/pci.h>
> +#include <device/pci_ops.h>
> +#include <device/pci_ids.h>
> +#include <console/console.h>
>
> +/* this fine tunes the HT link settings,
> which were loaded by ROM strap */
>
> +static void host_ctrl_enable(struct device *dev)
> +{
> dump_south(dev);
> /* bit 4 is reserved but set by AW
>   set PCI to HT outstanding requests to 3 */
> pci_write_config8(dev, 0xa0, 0x13);
> /* disable NVRAM and enable non-posted PCI writes */
> pci_write_config8(dev, 0xa1, 0x8e);
> /* nvram IO base 0xe00-0xeff but it is disabled
>   some bits are set and reserved */
> pci_write_config8(dev, 0xa2, 0x0e);
> /* Arbitration control, some bits are reserved */
> pci_write_config8(dev, 0xa5, 0x3c);
> /* Arbitration control 2 */
> pci_write_config8(dev, 0xa6, 0x80);
> dump_south(dev);
>
> +}
>
> +static struct device_operations host_ctrl_ops = {
> .read_resources = pci_dev_read_resources,
> .set_resources = pci_dev_set_resources,
> .enable_resources = pci_dev_enable_resources,
> .enable = host_ctrl_enable,
> .ops_pci = 0,
>
> +};
>
> +static struct pci_driver northbridge_driver __pci_driver = {
> .ops = &host_ctrl_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_2,
>
> +};
> Index: k8t890_early_car.c
> ===================================================================
> --- k8t890_early_car.c	(revision 0)
> +++ k8t890_early_car.c	(revision 0)
> @@ -0,0 +1,54 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2007 Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License v2 as published by
> the Free Software Foundation.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +/* seems the link and width of HT link needs to be setup too,
> you need to generate PCI reset or LDTSTOP to apply */
>
> +u8 k8t890_early_setup_car(u8 width, u8 speed)
> +{
> u8 awidth, aspeed;
> print_debug("LDT width and speed for K8T890 was");
> awidth = pci_read_config8(PCI_DEV(0, 0x0, 0), 0x67);
> print_debug_hex8(awidth);
> aspeed = pci_read_config8(PCI_DEV(0, 0x0, 0), 0x6d);
> print_debug_hex8(aspeed);
> if ((aspeed == speed) && (((width == 16) && (awidth == 0x11)) ||
> 		  ((width == 8) && (awidth == 0x00))))
> return 0;
> /* Update the desired HT LNK caps in NB too */
> pci_write_config8(PCI_DEV(0, 0x0, 0), 0x67,
> 	  (width == 16) ? 0x11 : 0x00);
> pci_write_config8(PCI_DEV(0, 0x0, 0), 0x6d, speed);
> print_debug(" and will after HT reset: ");
> awidth = pci_read_config8(PCI_DEV(0, 0x0, 0), 0x67);
> print_debug_hex8(awidth);
> aspeed = pci_read_config8(PCI_DEV(0, 0x0, 0), 0x6d);
> print_debug_hex8(aspeed);
> print_debug("\n");
> return 1;
>
> +}
> Index: k8t890_dram.c
> ===================================================================
> --- k8t890_dram.c	(revision 0)
> +++ k8t890_dram.c	(revision 0)
> @@ -0,0 +1,73 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2007 Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License v2 as published by
> the Free Software Foundation.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +#include <device/device.h>
> +#include <device/pci.h>
> +#include <device/pci_ops.h>
> +#include <device/pci_ids.h>
> +#include <console/console.h>
> +#include <cpu/x86/msr.h>
> +#include <cpu/amd/mtrr.h>
>
> +static void dram_enable(struct device *dev)
> +{
> msr_t msr;
> u16 reg;
> /* enable Lowest Interrupt arbitration for APIC,
>   enable NB APIC decoding, MSI support,?no SMRAM,
>   compatible SMM */
> pci_write_config8(dev, 0x86, 0x39);
> /* we want to use the 0xC0000-0xEFFFF as RAM
>   mark area as RW, even if memory is doing K8
>   the DMA from SB will fail if we have it wrong,
>   AND even we have it here, we must later copy it
>   to SB to make it work :/ */
> pci_write_config8(dev, 0x80, 0xff);
> pci_write_config8(dev, 0x81, 0xff);
> pci_write_config8(dev, 0x82, 0xff);
> pci_write_config8(dev, 0x83, 0x30);
> msr = rdmsr(TOP_MEM);
> reg = pci_read_config16(dev, 0x84);
> reg &= 0xf;
> pci_write_config16(dev, 0x84, (msr.lo >> 16) | reg);
> reg = pci_read_config16(dev, 0x88);
> reg &= 0xf800;
> pci_write_config16(dev, 0x88, (msr.lo >> 24) | reg);
>
> +}
>
> +static struct device_operations dram_ops = {
> .read_resources = pci_dev_read_resources,
> .set_resources = pci_dev_set_resources,
> .enable_resources = pci_dev_enable_resources,
> .enable = dram_enable,
> .ops_pci = 0,
>
> +};
>
> +static struct pci_driver northbridge_driver __pci_driver = {
> .ops = &dram_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_3,
>
> +};
> Index: k8t890_ctrl.c
> ===================================================================
> --- k8t890_ctrl.c	(revision 0)
> +++ k8t890_ctrl.c	(revision 0)
> @@ -0,0 +1,110 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2007 Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License v2 as published by
> the Free Software Foundation.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +#include <device/device.h>
> +#include <device/pci.h>
> +#include <device/pci_ops.h>
> +#include <device/pci_ids.h>
> +#include <console/console.h>
>
> +static void ctrl_enable(struct device *dev)
> +{
> u8 regm, regm2, regm3;
> device_t devfun3 =
>    dev_find_device(PCI_VENDOR_ID_VIA,
> 	    PCI_DEVICE_ID_VIA_K8T890CE_3, 0);
> /* TODO fix some ordering issue fo V-link set Rx77[6] and PCI1_Rx4F[0]
>   should to 1 */
> /* C2P Read ACK Return Priority */
> /* PCI CFG Address bits[27:24] are used as extended register address
>   bit[11:8] */
> pci_write_config8(dev, 0x47, 0x30);
> /* FIXME: Program V-link 8X 16bit full duplex, this needs to be fixed
>   for other than VT8237R SB */
> pci_write_config8(dev, 0x48, 0x23);
> /* magic init this not well documented :/ */
> pci_write_config8(dev, 0x70, 0xc2);
> /* PCI Control */
> pci_write_config8(dev, 0x72, 0xee);
> pci_write_config8(dev, 0x73, 0x01);
> pci_write_config8(dev, 0x74, 0x24);
> pci_write_config8(dev, 0x75, 0x0f);
> pci_write_config8(dev, 0x76, 0x50);
> pci_write_config8(dev, 0x77, 0x08);
> pci_write_config8(dev, 0x78, 0x01);
> /* APIC on HT */
> pci_write_config8(dev, 0x7c, 0x7f);
> pci_write_config8(dev, 0x7f, 0x02);
> /* WARNING NEED to copy some registers from NB (D0F3) to SB (D0F7) */
> /* shadow mem CTRL */
> regm = pci_read_config8(devfun3, 0x88);
> pci_write_config8(dev, 0x57, regm);
> /* shadow page C */
> regm = pci_read_config8(devfun3, 0x80);
> pci_write_config8(dev, 0x61, regm);
> /* shadow page D */
> regm = pci_read_config8(devfun3, 0x81);
> pci_write_config8(dev, 0x62, regm);
> /* SMM and APIC decoding */
> regm = pci_read_config8(devfun3, 0x86);
> pci_write_config8(dev, 0xe6, regm);
> /* shadow page E */
> regm3 = pci_read_config8(devfun3, 0x82);
> /* all access bits for 0xE0000-0xEFFFF encode as just 2 bits!
>   so the NB reg is quite inconsistent, we expect there only 0xff or 0x00,
>   and write them to 0x63 7-6 but! VIA 8237A has the mirror at 0x64! */
> if (regm3 == 0xff)
> regm3 = 0xC0;
> else
> regm3 = 0x0;
> /* page F + Memhole copy */
> regm = pci_read_config8(devfun3, 0x83);
> pci_write_config8(dev, 0x63, regm3 | (regm & 0x3F));
>
> +}
>
> +static struct device_operations ctrl_ops = {
> .read_resources = pci_dev_read_resources,
> .set_resources = pci_dev_set_resources,
> .enable_resources = pci_dev_enable_resources,
> .enable = ctrl_enable,
> .ops_pci = 0,
>
> +};
>
> +static struct pci_driver northbridge_driver __pci_driver = {
> .ops = &ctrl_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_7,
>
> +};
> Index: k8t890.h
> ===================================================================
> --- k8t890.h	(revision 0)
> +++ k8t890.h	(revision 0)
> @@ -0,0 +1,32 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2007 Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License v2 as published by
> the Free Software Foundation.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +#ifndef SOUTHBRIDGE_VIA_K8T890_H
> +#define SOUTHBRIDGE_VIA_K8T890_H
>
> +/* static resources for K8T890 */
> +#define K8T890_APIC_ID 0x3
>
> +/* please check the datasheet and traf_ctrl_enable before change! */
> +#define K8T890_APIC_BASE 0xfecc0000
>
> +#define K8T890_MMCONFIG_MBAR 0x61
> +#define K8T890_MULTIPLE_FN_EN 0x4f
>
> +#endif
>

[Rudolf Marek]

Whoops sorry,

I generated the patch from the current directory. It should go to
src/southbridge/via/k8t890

I can generate new patch tomorrow if you need it.

Thanks,
Rudolf

[Stefan Reinauer]

* Rudolf Marek  [071014 19:01]:
> Whoops sorry,
>
> I generated the patch from the current directory. It should go to
> src/southbridge/via/k8t890
>
> I can generate new patch tomorrow if you need it.

I guess its fine. Just wanted to make sure.

[Uwe Hermann]

On Sat, Oct 13, 2007 at 09:40:03PM +0200, Rudolf Marek wrote:
> Index: romstrap.inc
>
> --- romstrap.inc	(revision 0)
> +++ romstrap.inc	(revision 0)
> @@ -0,0 +1,60 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2004 Tyan Computer
> Written by Yinghai Lu  for Tyan Computer.
> (C) 2007 Rudolf Marek

Minor nitpick:

Copyright (C) 2007 Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by
> the Free Software Foundation; either version 2 of the License, or
> (at your option) any later version.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +/* this file constructs the ROM strap table for K8T890 */
>
> +.section ".romstrap", "a", @progbits
>
> +.globl __romstrap_start 
> +.globl __romstrap_end
>
> +__romstrap_start:
>
> +/* Bellow are some Dev0 Func2 HT control registers values,

Below
> depending on strap pin, one of bellow line is used */

lines
> +tblpointer:
> +.long 0x504400AA, 0x61970FC2	//;200M
> +.long 0x504400AA, 0x61970FC2	//;400M
> +.long 0x504400AA, 0x61970FC2	//;600M
> +.long 0x504400AA, 0x61970FC2	//;800M
> +.long 0x504400AA, 0x61970FC2	//;1000M
> +.long 0x0
> +.long 0x0
> +.long 0x0
> +.long 0x0
> +.long 0x0
> +.long 0x0
> +.long 0x0
> +.long 0x0
> +.long 0x0
> +.long 0x0
>
> +/* the pointer to above table should be at 0xffffd,
> the table itself MUST be aligned to 128B it seems! */

Please start all sentences with capital letter in the comments.
> +.long tblpointer - 0xFFF00000
>
> +__romstrap_end:
>
> +.previous
> Index: Config.lb
> ===================================================================
> --- Config.lb	(revision 0)
> +++ Config.lb	(revision 0)

Missing license header.
> @@ -0,0 +1,6 @@
> +driver k8t890_ctrl.o
> +driver k8t890_dram.o
> +driver k8t890_host.o
> +driver k8t890_host_ctrl.o
> +driver k8t890_pcie.o
> +driver k8t890_traf_ctrl.o
> Index: k8t890_host.c
> ===================================================================
> --- k8t890_host.c	(revision 0)
> +++ k8t890_host.c	(revision 0)
> @@ -0,0 +1,46 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2007 Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License v2 as published by
> the Free Software Foundation.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +#include <device/device.h>
> +#include <device/pci.h>
> +#include <device/pci_ops.h>
> +#include <device/pci_ids.h>
> +#include <console/console.h>
>
> +#include "k8t890.h"
>
> +static void host_enable(struct device *dev)

Would

const struct device *dev

work? It looks like dev is not being modified(?)
> +{
> /* multiple function control */
> pci_write_config8(dev, K8T890_MULTIPLE_FN_EN, 0x01);
>
> +}
>
> +static struct device_operations host_ops = {
> .read_resources = pci_dev_read_resources,
> .set_resources = pci_dev_set_resources,
> .enable_resources = pci_dev_enable_resources,
> .enable = host_enable,
> .ops_pci = 0,
>
> +};
>
> +static struct pci_driver northbridge_driver __pci_driver = {

Does

const static struct pci_driver northbridge_driver __pci_driver = {

work? Not too important right now, though.
> .ops = &host_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_0,
>
> +};
> Index: k8t890_pcie.c
> ===================================================================
> --- k8t890_pcie.c	(revision 0)
> +++ k8t890_pcie.c	(revision 0)
> @@ -0,0 +1,167 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2007 Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License v2 as published by
> the Free Software Foundation.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +#include <console/console.h>
> +#include <device/device.h>
> +#include <device/pci.h>
> +#include <device/pciexp.h>
> +#include <device/pci_ops.h>
> +#include <device/pci_ids.h>
>
> +void peg_init(struct device *dev)
> +{
> u8 reg;
> printk_debug("Configuring PCIe PEG\n");
> dump_south(dev);
> /* disable link */
> reg = pci_read_config8(dev, 0x50);
> pci_write_config8(dev, 0x50, reg | 0x10);
> /* award has 0xb VIA recomends 0x4 */
> pci_write_config8(dev, 0xe1, 0xb);
> /*
>   pci_write_config8(dev, 0xe2, 0x0);
>   pci_write_config8(dev, 0xe3, 0x92);
> */
> /* disable scrambling bit 6 to 1 */
> pci_write_config8(dev, 0xc0, 0x43);
> /* set replay timer limit */
> pci_write_config8(dev, 0xb1, 0xf0);
> /* bit0=1 SDP (Start DLLP) always at Lane0. */
> reg = pci_read_config8(dev, 0xb8);
> pci_write_config8(dev, 0xb8, reg | 0x1);
> /*  downstream wait and Upstream Checking Malformed TLP through
>   "Byte Enable Rule" And "Over 4K Boundary Rule" */
> reg = pci_read_config8(dev, 0xa4);
> pci_write_config8(dev, 0xa4, reg | 0x30);
> /* enable link */
> reg = pci_read_config8(dev, 0x50);
> pci_write_config8(dev, 0x50, reg & ~0x10);
> /* retrain link */
> reg = pci_read_config8(dev, 0x50);
> pci_write_config8(dev, 0x50, reg | 0x20);
> reg = pci_read_config8(dev, 0x3e);
> reg |= 0x40;
> /* bus reset */
> pci_write_config8(dev, 0x3e, reg);
> reg = pci_read_config8(dev, 0x3e);
> reg &= ~0x40;
> /* clear reset */
> pci_write_config8(dev, 0x3e, reg);
> dump_south(dev);
>
> +}

One empty line only between functions.
> +void pcie_init(struct device *dev)
> +{
> u8 reg;
> printk_debug("Configuring PCIe PEXs\n");

Is the "official" name PCIe or PCI-E?
> dump_south(dev);
> /* disable link */
> reg = pci_read_config8(dev, 0x50);
> pci_write_config8(dev, 0x50, reg | 0x10);
> /* award has 0xb VIA recomends 0x4 */
> pci_write_config8(dev, 0xe1, 0xb);
> /* set replay timer limit */
> pci_write_config8(dev, 0xb1, 0xf0);
> /* enable link */
> reg = pci_read_config8(dev, 0x50);
> pci_write_config8(dev, 0x50, reg & ~0x10);
> /* retrain */
> reg = pci_read_config8(dev, 0x50);
> pci_write_config8(dev, 0x50, reg | 0x20);
> reg = pci_read_config8(dev, 0x3e);
> reg |= 0x40;
> /* bus reset */
> pci_write_config8(dev, 0x3e, reg);
> reg = pci_read_config8(dev, 0x3e);
> reg &= ~0x40;
> /* clear reset */
> pci_write_config8(dev, 0x3e, reg);
> dump_south(dev);

Looks very similar to above. Does it make sense to merge it somehow?
Probably not, but I figured I should ask nevertheless, just in case.
> +}
>
> +static struct device_operations peg_ops = {
> .read_resources = pci_bus_read_resources,
> .set_resources = pci_dev_set_resources,
> .enable_resources = pci_bus_enable_resources,
> .enable = peg_init,
> .scan_bus = pciexp_scan_bridge,
> .reset_bus = pci_bus_reset,
> .ops_pci = 0,
>
> +};
>
> +static struct device_operations pcie_ops = {
> .read_resources = pci_bus_read_resources,
> .set_resources = pci_dev_set_resources,
> .enable_resources = pci_bus_enable_resources,
> .enable = pcie_init,
> .scan_bus = pciexp_scan_bridge,
> .reset_bus = pci_bus_reset,
> .ops_pci = 0,
>
> +};
>
> +static struct pci_driver northbridge_driver __pci_driver = {
> .ops = &peg_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_PEG,
>
> +};
>
> +static struct pci_driver pcie_drvd3f0 __pci_driver = {
> .ops = &pcie_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_PEX0,
>
> +};
>
> +static struct pci_driver pcie_drvd3f1 __pci_driver = {
> .ops = &pcie_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_PEX1,
>
> +};
>
> +static struct pci_driver pcie_drvd3f2 __pci_driver = {
> .ops = &pcie_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_PEX2,
>
> +};
>
> +static struct pci_driver pcie_drvd3f3 __pci_driver = {
> .ops = &pcie_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_PEX3,

Do you have the device ID for non-CE K8T890, too? Are they different?
Would it make sense to add them, i.e. do you expect the code to
(more or less) work in that case, too?
> +};
> Index: k8t890_traf_ctrl.c
> ===================================================================
> --- k8t890_traf_ctrl.c	(revision 0)
> +++ k8t890_traf_ctrl.c	(revision 0)
> @@ -0,0 +1,124 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2007 Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License v2 as published by
> the Free Software Foundation.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +#include <device/device.h>
> +#include <device/pci.h>
> +#include <device/pci_ops.h>
> +#include <device/pci_ids.h>
> +#include <console/console.h>
>
> +#include "k8t890.h"
>
> +void mmconfig_set_resources(device_t dev)
> +{

Empty line not needed.
> struct resource *resource;
> u8 reg;
> resource = find_resource(dev, K8T890_MMCONFIG_MBAR);
> if (resource) {
> report_resource_stored(dev, resource, "<mmconfig>");
> /* Remember this resource has been stored */
> resource->flags |= IORESOURCE_STORED;
> pci_write_config8(dev, K8T890_MMCONFIG_MBAR,
> 		  (resource->base >> 28));
> reg = pci_read_config8(dev, 0x60);
> reg |= 0x3;
> /* enable MMCONFIG decoding */
> pci_write_config8(dev, 0x60, reg);
> }
> pci_dev_set_resources(dev);
>
> +}

One empty line only.
> +static void apic_mmconfig_read_resources(device_t dev)
> +{
> struct resource *res;
> pci_dev_read_resources(dev);
> res = new_resource(dev, 0x40);
> /* NB APIC fixed to this addr */
> res->base = K8T890_APIC_BASE;
> res->size = 256;
> res->limit = res->base + res->size - 1;
> res->align = 8;
> res->gran = 8;
> res->flags = IORESOURCE_MEM | IORESOURCE_FIXED |
>    IORESOURCE_STORED | IORESOURCE_ASSIGNED;
> /* Add a MMCONFIG resource */
> res = new_resource(dev, K8T890_MMCONFIG_MBAR);
> res->size = 256 * 1024 * 1024;

Why hardcoded? Is it configurable or _must_ it be hardcoded this way?
(sorry if I already asked that)
> res->align = log2(res->size);
> res->gran = log2(res->size);
> res->limit = 0xffffffff;	/* 4G */
> res->flags = IORESOURCE_MEM;
>
> +}
>
> +static void traf_ctrl_enable(struct device *dev)
> +{
> volatile u32 *apic;
> u32 data;
> /* enable D3F1-D3F3, no device2 redirect, enable just one device behind
>   bridge device 2 and device 3) */
> pci_write_config8(dev, 0x60, 0x88);
> /* will enable MMCONFIG later */
> pci_write_config8(dev, 0x64, 0x23);
> /* no extended RCRB Base Address */
> pci_write_config8(dev, 0x62, 0x00);
> /*offset80 ->95 bit 4 in 1 in award */
> /* enable APIC, to K8T890_APIC_BASE */
> pci_write_config8(dev, 0x41, 0x00);
> pci_write_config8(dev, 0x40, 0x8c);
> /* BT_INTR  enable, APIC Nonshare Mode Enable */
> pci_write_config8(dev, 0x42, 0x5);
> apic = (u32 *) K8T890_APIC_BASE;
> /* set APIC to FSB transported messages */
> apic[0] = 3;
> data = apic[4];
> apic[4] = (data & 0xFFFFFE) | 1;
> /* set APIC ID */
> apic[0] = 0;
> data = apic[4];
> apic[4] = (data & 0xF0FFFF) | (K8T890_APIC_ID << 24);
>
> +}
>
> +static struct device_operations traf_ctrl_ops = {
> .read_resources = apic_mmconfig_read_resources,
> .set_resources = mmconfig_set_resources,
> .enable_resources = pci_dev_enable_resources,
> .enable = traf_ctrl_enable,
> .ops_pci = 0,
>
> +};
>
> +static struct pci_driver northbridge_driver __pci_driver = {
> .ops = &traf_ctrl_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_5,
>
> +};
> Index: romstrap.lds
> ===================================================================
> --- romstrap.lds	(revision 0)
> +++ romstrap.lds	(revision 0)
> @@ -0,0 +1,30 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2007 AMD
> Written by Yinghai Lu  for AMD.
> Modified for K8T890 ROM strap by Rudolf Marek

Uh, "trivial" (well, let say "short" ;-) file, so (C) Rudolf Marek should
suffice, IMHO.
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by
> the Free Software Foundation; either version 2 of the License, or
> (at your option) any later version.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +SECTIONS {
> . = (_ROMBASE + ROM_IMAGE_SIZE - 0x2c) - (__romstrap_end - __romstrap_start);
> .romstrap (.): {
> *(.romstrap)
> }
>
> +}
> Index: k8t890_host_ctrl.c
> ===================================================================
> --- k8t890_host_ctrl.c	(revision 0)
> +++ k8t890_host_ctrl.c	(revision 0)
> @@ -0,0 +1,65 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2007 Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License v2 as published by
> the Free Software Foundation.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +#include <device/device.h>
> +#include <device/pci.h>
> +#include <device/pci_ops.h>
> +#include <device/pci_ids.h>
> +#include <console/console.h>
>
> +/* this fine tunes the HT link settings,
> which were loaded by ROM strap */
>
> +static void host_ctrl_enable(struct device *dev)
> +{
> dump_south(dev);
> /* bit 4 is reserved but set by AW
>   set PCI to HT outstanding requests to 3 */
> pci_write_config8(dev, 0xa0, 0x13);
> /* disable NVRAM and enable non-posted PCI writes */
> pci_write_config8(dev, 0xa1, 0x8e);
> /* nvram IO base 0xe00-0xeff but it is disabled
>   some bits are set and reserved */
> pci_write_config8(dev, 0xa2, 0x0e);
> /* Arbitration control, some bits are reserved */

Can you specify exactly which bits mean what and which are reversed? As
ost of us will never see the datasheets, this is going to be important
some day, I guess.
> pci_write_config8(dev, 0xa5, 0x3c);
> /* Arbitration control 2 */
> pci_write_config8(dev, 0xa6, 0x80);
> dump_south(dev);
>
> +}
>
> +static struct device_operations host_ctrl_ops = {
> .read_resources = pci_dev_read_resources,
> .set_resources = pci_dev_set_resources,
> .enable_resources = pci_dev_enable_resources,
> .enable = host_ctrl_enable,
> .ops_pci = 0,
>
> +};
>
> +static struct pci_driver northbridge_driver __pci_driver = {
> .ops = &host_ctrl_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_2,
>
> +};
> Index: k8t890_early_car.c
> ===================================================================
> --- k8t890_early_car.c	(revision 0)
> +++ k8t890_early_car.c	(revision 0)
> @@ -0,0 +1,54 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2007 Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License v2 as published by
> the Free Software Foundation.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +/* seems the link and width of HT link needs to be setup too,
> you need to generate PCI reset or LDTSTOP to apply */
>
> +u8 k8t890_early_setup_car(u8 width, u8 speed)
> +{
> u8 awidth, aspeed;
> print_debug("LDT width and speed for K8T890 was");
> awidth = pci_read_config8(PCI_DEV(0, 0x0, 0), 0x67);
> print_debug_hex8(awidth);
> aspeed = pci_read_config8(PCI_DEV(0, 0x0, 0), 0x6d);
> print_debug_hex8(aspeed);
> if ((aspeed == speed) && (((width == 16) && (awidth == 0x11)) ||
> 		  ((width == 8) && (awidth == 0x00))))
> return 0;
> /* Update the desired HT LNK caps in NB too */

caps = capabilities?
> pci_write_config8(PCI_DEV(0, 0x0, 0), 0x67,
> 	  (width == 16) ? 0x11 : 0x00);
> pci_write_config8(PCI_DEV(0, 0x0, 0), 0x6d, speed);
> print_debug(" and will after HT reset: ");
> awidth = pci_read_config8(PCI_DEV(0, 0x0, 0), 0x67);
> print_debug_hex8(awidth);
> aspeed = pci_read_config8(PCI_DEV(0, 0x0, 0), 0x6d);
> print_debug_hex8(aspeed);
> print_debug("\n");
> return 1;
>
> +}
> Index: k8t890_dram.c
> ===================================================================
> --- k8t890_dram.c	(revision 0)
> +++ k8t890_dram.c	(revision 0)
> @@ -0,0 +1,73 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2007 Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License v2 as published by
> the Free Software Foundation.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +#include <device/device.h>
> +#include <device/pci.h>
> +#include <device/pci_ops.h>
> +#include <device/pci_ids.h>
> +#include <console/console.h>
> +#include <cpu/x86/msr.h>
> +#include <cpu/amd/mtrr.h>
>
> +static void dram_enable(struct device *dev)
> +{
> msr_t msr;
> u16 reg;
> /* enable Lowest Interrupt arbitration for APIC,
>   enable NB APIC decoding, MSI support,?no SMRAM,
>   compatible SMM */
> pci_write_config8(dev, 0x86, 0x39);
> /* we want to use the 0xC0000-0xEFFFF as RAM
>   mark area as RW, even if memory is doing K8
>   the DMA from SB will fail if we have it wrong,
>   AND even we have it here, we must later copy it
>   to SB to make it work :/ */
> pci_write_config8(dev, 0x80, 0xff);
> pci_write_config8(dev, 0x81, 0xff);
> pci_write_config8(dev, 0x82, 0xff);
> pci_write_config8(dev, 0x83, 0x30);

Please list the registers and which bits mean what, so we can later
modify if needed without requiring the datasheet.
> msr = rdmsr(TOP_MEM);
> reg = pci_read_config16(dev, 0x84);
> reg &= 0xf;
> pci_write_config16(dev, 0x84, (msr.lo >> 16) | reg);
> reg = pci_read_config16(dev, 0x88);
> reg &= 0xf800;
> pci_write_config16(dev, 0x88, (msr.lo >> 24) | reg);
>
> +}
>
> +static struct device_operations dram_ops = {
> .read_resources = pci_dev_read_resources,
> .set_resources = pci_dev_set_resources,
> .enable_resources = pci_dev_enable_resources,
> .enable = dram_enable,
> .ops_pci = 0,
>
> +};
>
> +static struct pci_driver northbridge_driver __pci_driver = {
> .ops = &dram_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_3,
>
> +};
> Index: k8t890_ctrl.c
> ===================================================================
> --- k8t890_ctrl.c	(revision 0)
> +++ k8t890_ctrl.c	(revision 0)
> @@ -0,0 +1,110 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2007 Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License v2 as published by
> the Free Software Foundation.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +#include <device/device.h>
> +#include <device/pci.h>
> +#include <device/pci_ops.h>
> +#include <device/pci_ids.h>
> +#include <console/console.h>
>
> +static void ctrl_enable(struct device *dev)
> +{
> u8 regm, regm2, regm3;
> device_t devfun3 =
>    dev_find_device(PCI_VENDOR_ID_VIA,
> 	    PCI_DEVICE_ID_VIA_K8T890CE_3, 0);
> /* TODO fix some ordering issue fo V-link set Rx77[6] and PCI1_Rx4F[0]
>   should to 1 */
> /* C2P Read ACK Return Priority */
> /* PCI CFG Address bits[27:24] are used as extended register address
>   bit[11:8] */
> pci_write_config8(dev, 0x47, 0x30);
> /* FIXME: Program V-link 8X 16bit full duplex, this needs to be fixed
>   for other than VT8237R SB */
> pci_write_config8(dev, 0x48, 0x23);
> /* magic init this not well documented :/ */
> pci_write_config8(dev, 0x70, 0xc2);
> /* PCI Control */
> pci_write_config8(dev, 0x72, 0xee);
> pci_write_config8(dev, 0x73, 0x01);
> pci_write_config8(dev, 0x74, 0x24);
> pci_write_config8(dev, 0x75, 0x0f);
> pci_write_config8(dev, 0x76, 0x50);
> pci_write_config8(dev, 0x77, 0x08);
> pci_write_config8(dev, 0x78, 0x01);
> /* APIC on HT */
> pci_write_config8(dev, 0x7c, 0x7f);
> pci_write_config8(dev, 0x7f, 0x02);
> /* WARNING NEED to copy some registers from NB (D0F3) to SB (D0F7) */
> /* shadow mem CTRL */
> regm = pci_read_config8(devfun3, 0x88);
> pci_write_config8(dev, 0x57, regm);
> /* shadow page C */
> regm = pci_read_config8(devfun3, 0x80);
> pci_write_config8(dev, 0x61, regm);
> /* shadow page D */
> regm = pci_read_config8(devfun3, 0x81);
> pci_write_config8(dev, 0x62, regm);
> /* SMM and APIC decoding */
> regm = pci_read_config8(devfun3, 0x86);
> pci_write_config8(dev, 0xe6, regm);
> /* shadow page E */
> regm3 = pci_read_config8(devfun3, 0x82);
> /* all access bits for 0xE0000-0xEFFFF encode as just 2 bits!
>   so the NB reg is quite inconsistent, we expect there only 0xff or 0x00,
>   and write them to 0x63 7-6 but! VIA 8237A has the mirror at 0x64! */
> if (regm3 == 0xff)
> regm3 = 0xC0;
> else
> regm3 = 0x0;
> /* page F + Memhole copy */

"Shadow page F" ?
> regm = pci_read_config8(devfun3, 0x83);
> pci_write_config8(dev, 0x63, regm3 | (regm & 0x3F));
>
> +}
>
> +static struct device_operations ctrl_ops = {
> .read_resources = pci_dev_read_resources,
> .set_resources = pci_dev_set_resources,
> .enable_resources = pci_dev_enable_resources,
> .enable = ctrl_enable,
> .ops_pci = 0,
>
> +};
>
> +static struct pci_driver northbridge_driver __pci_driver = {
> .ops = &ctrl_ops,
> .vendor = PCI_VENDOR_ID_VIA,
> .device = PCI_DEVICE_ID_VIA_K8T890CE_7,
>
> +};
> Index: k8t890.h
> ===================================================================
> --- k8t890.h	(revision 0)
> +++ k8t890.h	(revision 0)
> @@ -0,0 +1,32 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright (C) 2007 Rudolf Marek
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License v2 as published by
> the Free Software Foundation.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
>
> +#ifndef SOUTHBRIDGE_VIA_K8T890_H
> +#define SOUTHBRIDGE_VIA_K8T890_H

SOUTHBRIDGE_VIA_K8T890_K8T890_H
> +/* static resources for K8T890 */

K8T890CE or all versions of it?
> +#define K8T890_APIC_ID 0x3
>
> +/* please check the datasheet and traf_ctrl_enable before change! */
> +#define K8T890_APIC_BASE 0xfecc0000

Um, "please check datasheet" is not going to happen without NDA, so
please explain it here.
> +#define K8T890_MMCONFIG_MBAR 0x61
> +#define K8T890_MULTIPLE_FN_EN 0x4f
>
> +#endif

Cool stuff. With the above fixes this looks committable to me. If there
are no further reviews or remarks, I'll commit later this evening or so.

Thanks, Uwe.

[Rudolf Marek]

Thanks, I will try to fix it ASAP. I got some problem with data integrity of my
computer. It is not LinuxBIOS fault it seems - it happens with award too ;) I
think my harddrive produces 1bit changes to the data sometimes. Effectively
making mess in / FS. I have my data on RAID5 (except /) and those are 100% ok,
so perhaps this looks like a problem of one particular device in the system.

I checked with debsums -c and I got random errors (checksum failure) on fixed
set of files. This leads me to conclusion that it is not a memory or some other
problem, but limited to the HDD. I will try to move root fs to other disk and I
will check if it will be OK.

Thanks so far for the review,

Rudolf

[Rudolf Marek]

Hi all,

I fiddled bit more of the data corruption problem and it seems to be RAM related 
problem. It only occurs if the RAM is in dual channel mode (DDR400 auto settings).

I have some other dimms that are same size (512MB) but with CL3, it works fine 
with them. What is bit strange, that there seems to be problem with both 
"original" memory modules. Enough is to plug one "original" and one "spare" 
together. Wtf is going on? I used award BIOS for the tests but LB has same 
problems too.

Any ideas?

Thanks,
Rudolf

[Rudolf Marek]

> > ===================================================================
> > --- Config.lb	(revision 0)
> > +++ Config.lb	(revision 0)
>
> Missing license header.

Fixed
> > +static void host_enable(struct device *dev)
>
> Would
>
> const struct device *dev
>
> work? It looks like dev is not being modified(?)

Perhaps yes, but lets change that later.
> One empty line only between functions.

fixed.
> > +void pcie_init(struct device *dev)
> > +{
> > u8 reg;
> > printk_debug("Configuring PCIe PEXs\n");
>
> Is the "official" name PCIe or PCI-E?

Both.
> Looks very similar to above. Does it make sense to merge it somehow?
> Probably not, but I figured I should ask nevertheless, just in case.

Well some bits are different. I will need to fix the init when Training fails so
this will be rewritten later.
> > +static struct pci_driver pcie_drvd3f3 __pci_driver = {
> > .ops = &pcie_ops,
> > .vendor = PCI_VENDOR_ID_VIA,
> > .device = PCI_DEVICE_ID_VIA_K8T890CE_PEX3,
>
> Do you have the device ID for non-CE K8T890, too? Are they different?
> Would it make sense to add them, i.e. do you expect the code to
> (more or less) work in that case, too?

You mean for the CF? this IDs are 100% same.
> Empty line not needed.

fixed.
> One empty line only.

fixed.
> > res->base = K8T890_APIC_BASE;
> > res->size = 256;
> > res->limit = res->base + res->size - 1;
> > res->align = 8;
> > res->gran = 8;
> > res->flags = IORESOURCE_MEM | IORESOURCE_FIXED |
> >    IORESOURCE_STORED | IORESOURCE_ASSIGNED;
> > /* Add a MMCONFIG resource */
> > res = new_resource(dev, K8T890_MMCONFIG_MBAR);
> > res->size = 256 * 1024 * 1024;
>
> Why hardcoded? Is it configurable or _must_ it be hardcoded this way?
> (sorry if I already asked that)

What exactly? The BAR addr is computed dynamically.
> > Modified for K8T890 ROM strap by Rudolf Marek
>
> Uh, "trivial" (well, let say "short" ;-) file, so (C) Rudolf Marek should
> suffice, IMHO.

Ok. But I will leave it as it is ;)
> > dump_south(dev);
> > /* bit 4 is reserved but set by AW
> >   set PCI to HT outstanding requests to 3 */
> > pci_write_config8(dev, 0xa0, 0x13);
> > /* disable NVRAM and enable non-posted PCI writes */
> > pci_write_config8(dev, 0xa1, 0x8e);
> > /* nvram IO base 0xe00-0xeff but it is disabled
> >   some bits are set and reserved */
> > pci_write_config8(dev, 0xa2, 0x0e);
> > /* Arbitration control, some bits are reserved */
>
> Can you specify exactly which bits mean what and which are reversed? As
> ost of us will never see the datasheets, this is going to be important
> some day, I guess.

I have in plan to somehow document the code one day. "some bits reserved" means
the the some bits which are not documented are set to 1.
> > /* Update the desired HT LNK caps in NB too */
>
> caps = capabilities?

Ok
> > pci_write_config8(dev, 0x80, 0xff);
> > pci_write_config8(dev, 0x81, 0xff);
> > pci_write_config8(dev, 0x82, 0xff);
> > pci_write_config8(dev, 0x83, 0x30);
>
> Please list the registers and which bits mean what, so we can later
> modify if needed without requiring the datasheet.

Ok I tried to document it somehow.
> > regm3 = 0x0;
> > /* page F + Memhole copy */
>
> "Shadow page F" ?

yep fixed.
> > regm = pci_read_config8(devfun3, 0x83);
> > pci_write_config8(dev, 0x63, regm3 | (regm & 0x3F));
> >
> > +}
> >
> > +static struct device_operations ctrl_ops = {
> > .read_resources = pci_dev_read_resources,
> > .set_resources = pci_dev_set_resources,
> > .enable_resources = pci_dev_enable_resources,
> > .enable = ctrl_enable,
> > .ops_pci = 0,
> >
> > +};
> >
> > +static struct pci_driver northbridge_driver __pci_driver = {
> > .ops = &ctrl_ops,
> > .vendor = PCI_VENDOR_ID_VIA,
> > .device = PCI_DEVICE_ID_VIA_K8T890CE_7,
> >
> > +};
> > Index: k8t890.h
> > ===================================================================
> > --- k8t890.h	(revision 0)
> > +++ k8t890.h	(revision 0)
> > @@ -0,0 +1,32 @@
> > +/*
> > This file is part of the LinuxBIOS project.
> > Copyright (C) 2007 Rudolf Marek
> > This program is free software; you can redistribute it and/or modify
> > it under the terms of the GNU General Public License v2 as published by
> > the Free Software Foundation.
> > This program is distributed in the hope that it will be useful,
> > but WITHOUT ANY WARRANTY; without even the implied warranty of
> > MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > GNU General Public License for more details.
> > You should have received a copy of the GNU General Public License
> > along with this program; if not, write to the Free Software
> > Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> > */
> >
> > +#ifndef SOUTHBRIDGE_VIA_K8T890_H
> > +#define SOUTHBRIDGE_VIA_K8T890_H
>
> SOUTHBRIDGE_VIA_K8T890_K8T890_H

fixed.
> > +/* static resources for K8T890 */
>
> K8T890CE or all versions of it?

I support CE, CF should be very similar.
> > +#define K8T890_APIC_ID 0x3
> >
> > +/* please check the datasheet and traf_ctrl_enable before change! */
> > +#define K8T890_APIC_BASE 0xfecc0000
>
> Um, "please check datasheet" is not going to happen without NDA, so
> please explain it here.

Well it cant be changed to arbitrary address, so this is the reason why the reg 
is static.
> Cool stuff. With the above fixes this looks committable to me. If there
> are no further reviews or remarks, I'll commit later this evening or so.

Ok thanks, I'm attaching the fixed version for now. I will do some changes 
later, but all I need now is to have some consistent and working version.

Rudolf

[Rudolf Marek]

Forgot:

Signed-off-by: Rudolf Marek

Rudolf

[Uwe Hermann]

Thanks, patch is committed in r2883.

On Sun, Oct 21, 2007 at 11:20:40PM +0200, Rudolf Marek wrote:
> > > +static void host_enable(struct device *dev)
> >
> > Would
> >   const struct device *dev
> > work? It looks like dev is not being modified(?)
>
> Perhaps yes, but lets change that later.

OK.
> > > res = new_resource(dev, K8T890_MMCONFIG_MBAR);
> > > res->size = 256 * 1024 * 1024;
> >
> > Why hardcoded? Is it configurable or _must_ it be hardcoded this way?
> > (sorry if I already asked that)
>
> What exactly? The BAR addr is computed dynamically.

I meant the "256 * 1024 * 1024". Is this size fixed or configurable?
> > > +/* please check the datasheet and traf_ctrl_enable before change! */
> > > +#define K8T890_APIC_BASE 0xfecc0000
> >
> > Um, "please check datasheet" is not going to happen without NDA, so
> > please explain it here.
>
> Well it cant be changed to arbitrary address, so this is the reason why the 
> reg is static.

Yes, but please document which addresses are possible/valid (and in
which cases).

Uwe.