Re: [coreboot] Geode patch for trunk to fix cache flush and stack jump at copying stage.

[Patrick Georgi]

Thank you for your patch, it's highly appreciated!

As discussed on IRC, please add some comment to each address range in
the array about what kind of configuration is used for it (eg.
"write-back" for 0xa0000-0xbffff).

Also, we need a Sign-off before we can commit it to the repository, with
which you basically state that the work was yours (or taken from "safe"
sources), as some basic legal protection for the project (so we know who
to blame if Award/Phoenix code managed its way into our repository ;-) )
http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure has
the details on that.

Regards,
Patrick

Geode patch for trunk to fix cache flush and stack jump at copying stage.

[Peter Stuge]

Patrick Georgi wrote:
> Thank you for your patch, it's highly appreciated!

Agreed! Maybe they will also help Piotr!
> As discussed on IRC, please add some comment to each address range
> in the array about what kind of configuration is used for it (eg.
> "write-back" for 0xa0000-0xbffff).

Yes. Please also check if you can eliminate any whitespace changes
and/or inconsistencies in the patch. After that and a sign-off it
should be good to go!

//Peter

RESUBMIT: Geode patch for trunk to fix cache flush and stack jump at copying stage.

[Edwin Beasant]

Added the code/cache setup comments and stripped whitespace changes, hope this is to the liking of everyone :)
Edwin

________________________________
From: [e-mail] [mailto:[e-mail]] On Behalf Of Patrick Georgi
Sent: 25 January 2010 17:13
To: [e-mail]
Subject: Re: [coreboot] Geode patch for trunk to fix cache flush and stack jump at copying stage.

Thank you for your patch, it's highly appreciated!

As discussed on IRC, please add some comment to each address range in the array about what kind of configuration is used for it (eg. "write-back" for 0xa0000-0xbffff).

Also, we need a Sign-off before we can commit it to the repository, with which you basically state that the work was yours (or taken from "safe" sources), as some basic legal protection for the project (so we know who to blame if Award/Phoenix code managed its way into our repository ;-) )
http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure has the details on that.

Regards,
Patrick