[LinuxBIOS] Sun Ultra40 patches

[Roman Kononov]

This set of changes makes Sun Ultra40 working. Although not fully.

The working parts are: single CPU and nForce 2200 (CK804 Pro) with
all stuff connected to it. The still-not-working parts are: second
CPU and nForce 2050 with all stuff connected to it.

The changed files contain many things related to the non-working
second CPU and nForce 2050 commented out in order to make the
working system stable.

Thousand thanks to all who made the original Sun Ultra40 sources.

Signed-off-by: Roman Kononov

[LinuxBIOS] Sun Ultra40 patches

[Stefan Reinauer]

Roman Kononov wrote:
> This set of changes makes Sun Ultra40 working. Although not fully.
>
> The working parts are: single CPU and nForce 2200 (CK804 Pro) with
> all stuff connected to it. The still-not-working parts are: second
> CPU and nForce 2050 with all stuff connected to it.
>
> The changed files contain many things related to the non-working
> second CPU and nForce 2050 commented out in order to make the
> working system stable.
>
> Thousand thanks to all who made the original Sun Ultra40 sources.
>
> Signed-off-by: Roman Kononov

Could you please rediff with -w ? Something terribly broke the indenting.

[LinuxBIOS] Sun Ultra40 patches

[Uwe Hermann]

Hi,

On Fri, Feb 02, 2007 at 05:50:04PM +0100, Stefan Reinauer wrote:
> Roman Kononov wrote:
> > This set of changes makes Sun Ultra40 working. Although not fully.
> >
> > The working parts are: single CPU and nForce 2200 (CK804 Pro) with
> > all stuff connected to it. The still-not-working parts are: second
> > CPU and nForce 2050 with all stuff connected to it.
> >
> > The changed files contain many things related to the non-working
> > second CPU and nForce 2050 commented out in order to make the
> > working system stable.
> >
> > Thousand thanks to all who made the original Sun Ultra40 sources.
> >
> > Signed-off-by: Roman Kononov
>
> Could you please rediff with -w ? Something terribly broke the indenting.

I guess this was intended. It looks like Roman fixed the coding style(?)
E.g. replaced spaces with tabs in a number of places...

Such patches should be submitted separately from "real" code changes,
though, to make it easier to review the patches.

Uwe.

[LinuxBIOS] Sun Ultra40 patches

[Roman Kononov]

On 02/02/2007 11:58 AM, Uwe Hermann wrote:
> On Fri, Feb 02, 2007 at 05:50:04PM +0100, Stefan Reinauer wrote:
> > Could you please rediff with -w ? Something terribly broke the indenting.
>
> I guess this was intended. It looks like Roman fixed the coding style(?)
> E.g. replaced spaces with tabs in a number of places...
>
> Such patches should be submitted separately from "real" code changes,
> though, to make it easier to review the patches.

Rediffing with -w will not help. Fixing coding style first will not help
either. This is not as simple as a patch. It is a major re-writing.
The current code in the repository is half-finished and works only
by an accident. Reviewers should apply the patch and try to understand
what is going on there.

Regards, Roman

[LinuxBIOS] Sun Ultra40 patches

[Stefan Reinauer]

Roman Kononov wrote:
> Rediffing with -w will not help. Fixing coding style first will not help
> either. This is not as simple as a patch. It is a major re-writing.
> The current code in the repository is half-finished and works only
> by an accident. Reviewers should apply the patch and try to understand
> what is going on there.

There's pretty much stuff like the following, which is obviously not one
of those parts of the major rewrite ;-)

But let me look into it some more, and get back to it.
> ## Compute the start location and size size of
>  ## The linuxBIOS bootloader.
>  ##
> -default PAYLOAD_SIZE            = ( ROM_SECTION_SIZE - ROM_IMAGE_SIZE )
> +default PAYLOAD_SIZE             = ( ROM_SECTION_SIZE - ROM_IMAGE_SIZE )
>  default CONFIG_ROM_PAYLOAD_START = (0xffffffff - ROM_SIZE + ROM_SECTION_OFFSET + 1)
> -default CONFIG_ROM_PAYLOAD     = 1
> +default CONFIG_ROM_PAYLOAD       = 1
>
> ##
>  ## Compute where this copy of linuxBIOS will start in the boot rom
> @@ -33,7 +33,7 @@ default _ROMBASE      = ( CONFIG_ROM_PAY
>  default XIP_ROM_SIZE=65536
>  default XIP_ROM_BASE = ( _ROMBASE + ROM_IMAGE_SIZE - XIP_ROM_SIZE )
>
> -arch i386 end 
> +arch i386 end
>
> ##

[LinuxBIOS] Sun Ultra40 patches

[Roman Kononov]

On 02/02/2007 10:50 AM, Stefan Reinauer wrote:
> Could you please rediff with -w ? Something terribly broke the indenting.

Yes, indenting is broken. I diffed it with -Bb.
This one is diffed without -Bbw.

Signed-off-by: Roman Kononov