Status AMD64 ram init

[Stefan Reinauer]

Excerpt from current solo build:

LinuxBIOS-1.1.6.0-Fallback Fr Mär 19 14:43:18 CET 2004 starting...              
setting up resource map....done.                                                
ht reset -

LinuxBIOS-1.1.6.0-Fallback Fr Mär 19 14:43:18 CET 2004 starting...              
setting up resource map....done.                                                
Ram1.00                                                                         
Ram2.00                                                                         
Bad SPD value

Using the default hynix PC2100U 256MB DDR 266MHz CL2.5 modules.
I'm building a debug image which dumps the spd roms...

Stefan

[Stefan Reinauer]

* Stefan Reinauer  [040319 15:38]:
> Ram1.00
> Ram2.00
> Bad SPD value

low = spd_read_byte(device, 6); /* (low byte) */
        if (low < 0) goto hw_err;
        value = value | (low & 0xff);
        if ((value != 72) && (value &= 64)) goto val_err;
                              ^^^^^^^^^^^
It seems this should be value != 64 as well?

Stefan

Status AMD64 ram init [resolved]

[Stefan Reinauer]

* Stefan Reinauer  [040319 16:50]:
>     low = spd_read_byte(device, 6); /* (low byte) */
>     if (low < 0) goto hw_err;
>     value = value | (low & 0xff);
>     if ((value != 72) && (value &= 64)) goto val_err;
>                           ^^^^^^^^^^^
>
> It seems this should be value != 64 as well?

works and commited.

Stefan

Status AMD64 ram init [resolved]

Stefan Reinauer  writes:
> Stefan Reinauer  [040319 16:50]:
> >     low = spd_read_byte(device, 6); /* (low byte) */
> >     if (low < 0) goto hw_err;
> >     value = value | (low & 0xff);
> >     if ((value != 72) && (value &= 64)) goto val_err;
> >                           ^^^^^^^^^^^
> >
> > It seems this should be value != 64 as well?
>
> works and commited.

Thanks.  This appears to fix all of Eric's typo's week :)

Eric