Yes, when I looked around for good pci vendor/device ids respectively subsystem ids, I got the impression that are no unambiguous ids.
Identification works perfectly once LinuxBIOS is booted using the LinuxBios supplied vendor/part.
My suggestion then would be to remove matching of the board based on PCI ids for the DK8-HTX. Instead matching should only be done based on the name. If flashrom is used on a system booted by factory BIOS, the flash might fail (actually only if you have flash write protection enbaled in the factory BIOS setup). One need to provide board name on the command line. This seems to be much safer than guessing what board we're on and the fiddling with the GPIOs... Of course, this should also be documented, and maybe a warning message if the board could not be identified should be printed. I could provide a patch in that direction. What do you think?
Mondrian
On Thu, Apr 26, 2007 at 03:04:40PM +0200, Mondrian Nuessle wrote:
Yes, when I looked around for good pci vendor/device ids respectively subsystem ids, I got the impression that are no unambiguous ids.
Identification works perfectly once LinuxBIOS is booted using the LinuxBios supplied vendor/part.
My suggestion then would be to remove matching of the board based on PCI ids for the DK8-HTX. Instead matching should only be done based on the name. If flashrom is used on a system booted by factory BIOS, the flash might fail (actually only if you have flash write protection enbaled in the factory BIOS setup). One need to provide board name on the command line. This seems to be much safer than guessing what board we're on and the fiddling with the GPIOs... Of course, this should also be documented, and maybe a warning message if the board could not be identified should be printed. I could provide a patch in that direction. What do you think?
Mondrian
Provide linuxbios name and only main ids and the matcher will not try to match on pci-ids.
Luc Verhaegen.
Provide linuxbios name and only main ids and the matcher will not try to match on pci-ids.
Yes, that's what I'll do. What about putting a warning message in the code whenever no matching board could be found. Just to be safe :-)
Regards, Mondrian
On Thu, Apr 26, 2007 at 05:41:41PM +0200, Mondrian Nuessle wrote:
Provide linuxbios name and only main ids and the matcher will not try to match on pci-ids.
Yes, that's what I'll do. What about putting a warning message in the code whenever no matching board could be found. Just to be safe :-)
Regards, Mondrian
Many boards often are happy with just the chip enable, so warning about unknown board there would just be intrusive.
Luc Verhaegen.
On Thu, Apr 26, 2007 at 05:41:41PM +0200, Mondrian Nuessle wrote:
Provide linuxbios name and only main ids and the matcher will not try to match on pci-ids.
Yes, that's what I'll do. What about putting a warning message in the code whenever no matching board could be found. Just to be safe :-)
Regards, Mondrian
Many boards often are happy with just the chip enable, so warning about unknown board there would just be intrusive.
hmm. ok. I'll post the patch with these changes...
Mondrian
-
Luc Verhaegen -
Luc Verhaegen.
-
Mondrian Nuessle