[PATCH] Kconfig: string option doesn't work properly inside choice section - coreboot

7 Feb 2013

Kconfig: string option doesn't work properly inside choice section
At least not in menuconfig. Move it after the endchoice.
Signed-off-by: Jens Rottmann JRottmann@LiPPERTembedded.de
---
Hi everyone (in case any still remember me, last time was > 2 years ago),
I prepared / am preparing support for 2 of our new boards (both AMD Fusion
platform, mostly differ in form factor), which I'd like to upstream into the
official repository. Then I'll likely disappear again for years, sorry.  :-(
My boards are based on AMD Persimmon and Inagua.  When trying to compare the two
I noticed lots of differences, most of which are whitespace.  It looks like one
is a copy of the other, but afterwards someone did a cleanup of Inagua only?  As
both are AMD reference designs, I think I have no choice but first try to get
them closer to each other before (re)basing my code on it.
But first of all this little bugfix here.
Best regards and thanks,
Jens Rottmann

--- coreboot-f04e68e/src/cpu/Kconfig
+++ coreboot/src/cpu/Kconfig
@@ -105,13 +105,6 @@
If unsure, select "Generate from tree"
-config CPU_MICROCODE_FILE
-	  string "Path and filename of CPU microcode"
-	  depends on CPU_MICROCODE_CBFS_EXTERNAL
-	  default "cpu_microcode.bin"
-	  help
-	    The path and filename of the file containing the CPU microcode.
-
 config CPU_MICROCODE_CBFS_NONE
    bool "Do not include microcode updates"
    help
@@ -155,3 +148,10 @@
      selecting this option.
endchoice
+
+config CPU_MICROCODE_FILE
+	  string "Path and filename of CPU microcode"
+	  depends on CPU_MICROCODE_CBFS_EXTERNAL
+	  default "cpu_microcode.bin"
+	  help
+	    The path and filename of the file containing the CPU microcode.
_

    