See patch.
Most of the hda_verb.h files can be safely dropped as they're unused (and/or incorrect).
I own the MSI MS-7260 and will provide a working hda_verb.h file for that at some later point, and also for my upcoming ASUS M2N-E port.
Uwe.
Uwe Hermann wrote:
Cleanup up HD audio codec / hda_verb.h files.
..
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de
Acked-by: Peter Stuge peter@stuge.se
On 12/11/10 12:57 PM, Peter Stuge wrote:
Uwe Hermann wrote:
Cleanup up HD audio codec / hda_verb.h files.
..
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de
Acked-by: Peter Stuge peter@stuge.se
However, please refrain from removing the verb adding code from those boards that actually have sound jacks. It makes no sense to remove the codecs and add the same code later on. Instead it should just be fixed as soon as the right information is known for those boards.
Stefan
On Sat, Dec 11, 2010 at 01:29:09PM -0800, Stefan Reinauer wrote:
On 12/11/10 12:57 PM, Peter Stuge wrote:
Uwe Hermann wrote:
Cleanup up HD audio codec / hda_verb.h files.
..
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de
Acked-by: Peter Stuge peter@stuge.se
Thanks, r6180.
However, please refrain from removing the verb adding code from those boards that actually have sound jacks. It makes no sense to remove the codecs and add the same code later on. Instead it should just be fixed as soon as the right information is known for those boards.
OK, I kept the files for now, though we should probably only keep the code in mainboard.c (commented out) and kill the definately useless hda_verb.h files, IMHO.
Uwe.
On 12/15/10 1:05 AM, Uwe Hermann wrote:
However, please refrain from removing the verb adding code from those boards that actually have sound jacks. It makes no sense to remove the codecs and add the same code later on. Instead it should just be fixed as soon as the right information is known for those boards.
OK, I kept the files for now, though we should probably only keep the code in mainboard.c (commented out) and kill the definately useless hda_verb.h files, IMHO.
Alright, go ahead...
On Wed, Dec 15, 2010 at 09:02:16PM -0800, Stefan Reinauer wrote:
On 12/15/10 1:05 AM, Uwe Hermann wrote:
However, please refrain from removing the verb adding code from those boards that actually have sound jacks. It makes no sense to remove the codecs and add the same code later on. Instead it should just be fixed as soon as the right information is known for those boards.
OK, I kept the files for now, though we should probably only keep the code in mainboard.c (commented out) and kill the definately useless hda_verb.h files, IMHO.
Alright, go ahead...
OK, thanks, committed in r6196.
Uwe.