Asus P2-99: PS2 keyboard, time stamps, double logs

[Paul Menzel]

Dear Branden,

Thank you for uploading the results for your ASUS P2-99 to the board
status repository [1].

You configured your board as below.

```
# This image was built using coreboot 4.6-2379-g0cc28d7e61
CONFIG_VENDOR_ASUS=y
CONFIG_BOARD_ASUS_P2B=y
CONFIG_DRIVERS_PS2_KEYBOARD=y
CONFIG_SEABIOS_PS2_TIMEOUT=500
# CONFIG_DRIVERS_INTEL_WIFI is not set
CONFIG_MAINBOARD_SMBIOS_PRODUCT_NAME="P2-99"
CONFIG_SEABIOS_MASTER=y
```

First, if the image built for the different board Asus P2B builds, we
should just add a variant for the Asus P2-99, so that the upload is not
so confusing.

Second, as you use SeaBIOS as a payload you can deselect
`CONFIG_DRIVERS_PS2_KEYBOARD` as SeaBIOS can initialize that on its
own.

I only know the time-out for SeaBIOS to be needed on laptops. Is
SeaBIOS unable to initialize the PS/2 keyboard, when you remove the
time-out?

Despite time stamp collection being enabled
(`CONFIG_COLLECT_TIMESTAMPS=y`), there is no upload of the output
`cbmem -t`. Is that not working?

Also, did your board reboot/reset in between?

```
[…]
SeaBIOS (version rel-1.11.0-4-g844b864)
[…]
Booting from Hard Disk...
Booting from 0000:7c00

coreboot-4.6-2379-g0cc28d7e61 Fri Dec 15 03:32:04 UTC 2017 romstage starting...
[…]
```

Thanks,

Paul

[1] asus/p2b/4.6-2379-g0cc28d7e61/2017-12-15T03_32_04Z

[Branden Waldner]

Hi Paul,

My intention in uploading again to the board status repository was to
do to it with the patches Keith made merged. It's failed though as
make clean and make distclean didn't seem to clean up the old
(external?) acpi code like when I first tested the patch for Keith
(The kernel log shows acpi errors on lines 120 - 123). I might have
ended up just removing everything and running git reset --hard or
something last time to get it to work properly. I don't know how it
ended up not being marked as dirty then, but I figured to was still
okay to upload.

I wasn't sure yet what to do about the board mismatch. I think Keith
had recommended that I originally upload the board status as P2B to
insure that it was marked as being worked on so as not to be removed
by the upcoming coreboot release and clean up (that still hasn't
happened). Although it looks like the P2B and P2-99 use the same PCB
layout and my P2-99 having no problem with the P2B bios, without an
actual P2B to test with it might be best to treat them seperately.
That would basically mean that it would just be a straight copy of the
P2B to P2--99 for now and that the P2B would end up being removed as
not being tested recently.

Does anyone want to make a call on that to clean up the situation? Of
course, these boards are old and probably considered obsolete by alot
of people, so I don't know who would be interested in it.

As for the PS2 keyboard initialization, I had that set intending to
see if the I could avoid SeaBIOS failing to init the keyboard
occasionally. SeaBIOS throws "WARNING - Timeout at ps2_recvbyte:182!"
and then I can't use the keyboard with grub2 (on disk/ not coreboot
payload). I had tried setting a time-out with SeaBIOS before and it
seemed to have just ignored it. It seems to be more of a problem when
only having one ram stick, but all I have to do is hit the reset
switch and it usually works after rebooting. I guess I shouldn't have
had that set when uploading to board status, but alot of other entries
are marked dirty even, so I figured a weird set of options was fine. I
also wasn't really expecting a reply.

The time stamp collection not getting any output is because 'cbmem -t'
errors out with 'Could not open
/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq: No such file or
directory'. I recall reading about other people having problems with
it and noted in one of my mails to Keith when testing the acpi patch
that I was having this issue, but don't know what to do about it. Does
cbmem actually need this, or why does it fail on it? It doesn't really
sound like something critical to it working. Is it part of the acpi
that didn't end up getting setup properly on this build?

As for the double boot log, yes, I did reboot before hand. I'd
forgotten about cbmem/board_status saving multiple boot logs then.

Thanks for the reply,

Branden