[PATCH] flashrom: Add board-enable for Shuttle AK38N

[Uwe Hermann]

See patch.

Thanks to Luc Verhaegen and Peter Stuge for help and suggestions on IRC.

Uwe.

[Luc Verhaegen]

On Thu, Jun 18, 2009 at 04:50:07AM +0200, Uwe Hermann wrote:
> See patch.
>
> Thanks to Luc Verhaegen and Peter Stuge for help and suggestions on IRC.
> Uwe.
>
> http://www.hermann-uwe.de  | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
> Add board-enable code for the Shuttle AK38N.
>
> FYI, this board can only decode 256 KB chips (not 512 KB ones) unfortunately.
>
> The it8705f_write_enable() is kept generic enough so it can be reused for other
> board-enables, possibly in the board_biostar_p4m80_m4() for example, but that
> shouldn't be touched for now, unless someone can test the code.
>
> Signed-off-by: Uwe Hermann
> Index: board_enable.c
>
> --- board_enable.c	(revision 602)
> +++ board_enable.c	(working copy)
> @@ -692,7 +692,25 @@
>    return 0;
>  }
>
> +static int it8705f_write_enable(uint8_t port, const char *name)
> +{
> enter_conf_mode_ite(port);
> sio_mask(port, 0x24, 0x04, 0x04); /* Flash ROM I/F Writes Enable */
> exit_conf_mode_ite(port);
> return 0;
>
> +}
>
> /**
> Suited for Shuttle AK38N: VIA KT333CF + VIA VT8235 + ITE IT8705F
> */
>
> +static int it8705f_write_enable_2e(const char *name)
> +{
> it8705f_write_enable(0x2e, name);
> return 0;
>
> +}
>
> +/**
> We use 2 sets of IDs here, you're free to choose which is which. This
> is to provide a very high degree of certainty when matching a board on
> the basis of subsystem/card IDs. As not every vendor handles
>
> @@ -747,6 +765,7 @@
>    {0x1106, 0x0571, 0x1462, 0x7120,       0,      0,      0,      0, "msi",        "kt4v",        "MSI",         "MS-6712 (KT4V)",     board_msi_kt4v},
>    {0x13f6, 0x0111, 0x1462, 0x5900,  0x1106, 0x3177, 0x1106,      0, "msi",        "kt4ultra",    "MSI",         "MS-6590 (KT4 Ultra)",board_msi_kt4v},
>    {0x8086, 0x2658, 0x1462, 0x7046,  0x1106, 0x3044, 0x1462, 0x046d, NULL,         NULL,          "MSI",         "MS-7046",            ich6_gpio19_raise},
> {0x1106, 0x3177,      0,      0,  0x1106, 0x3199,      0,      0, "shuttle",    "ak38n",       "Shuttle",     "AK38N",              it8705f_write_enable_2e},
> {0x1106, 0x3038, 0x0925, 0x1234,  0x1106, 0x3058, 0x15DD, 0x7609, NULL,         NULL,          "Soyo",        "SY-7VCA",            board_soyo_sy_7vca},
> {0x8086, 0x1076, 0x8086, 0x1176,  0x1106, 0x3059, 0x10f1, 0x2498, NULL,         NULL,          "Tyan",        "S2498 (Tomcat K7M)", board_asus_a7v8x_mx},
> {0x1106, 0x0314, 0x1106, 0xaa08,  0x1106, 0x3227, 0x1106, 0xAA08, NULL,         NULL,          "VIA",         "EPIA-CN",            board_via_epia_sp},

Three things:
* return the value of the it8705f_write_enable in 
it8705f_write_enable_2e
* check whether we can match any board ids there.
* please attach lspci -vnn for future reference.

Once done: Acked-by: Luc Verhaegen

Luc Verhaegen.

[Uwe Hermann]

On Fri, Jun 19, 2009 at 04:42:20PM +0200, Luc Verhaegen wrote:
> > /**
> > Suited for Shuttle AK38N: VIA KT333CF + VIA VT8235 + ITE IT8705F
> > */
> >
> > +static int it8705f_write_enable_2e(const char *name)
> > +{
> > it8705f_write_enable(0x2e, name);
> > return 0;
> >
> > +}
> >
> > +/**
> > We use 2 sets of IDs here, you're free to choose which is which. This
> > is to provide a very high degree of certainty when matching a board on
> > the basis of subsystem/card IDs. As not every vendor handles
> >
> > @@ -747,6 +765,7 @@
> >    {0x1106, 0x0571, 0x1462, 0x7120,       0,      0,      0,      0, "msi",        "kt4v",        "MSI",         "MS-6712 (KT4V)",     board_msi_kt4v},
> >    {0x13f6, 0x0111, 0x1462, 0x5900,  0x1106, 0x3177, 0x1106,      0, "msi",        "kt4ultra",    "MSI",         "MS-6590 (KT4 Ultra)",board_msi_kt4v},
> >    {0x8086, 0x2658, 0x1462, 0x7046,  0x1106, 0x3044, 0x1462, 0x046d, NULL,         NULL,          "MSI",         "MS-7046",            ich6_gpio19_raise},
> > {0x1106, 0x3177,      0,      0,  0x1106, 0x3199,      0,      0, "shuttle",    "ak38n",       "Shuttle",     "AK38N",              it8705f_write_enable_2e},
> > {0x1106, 0x3038, 0x0925, 0x1234,  0x1106, 0x3058, 0x15DD, 0x7609, NULL,         NULL,          "Soyo",        "SY-7VCA",            board_soyo_sy_7vca},
> > {0x8086, 0x1076, 0x8086, 0x1176,  0x1106, 0x3059, 0x10f1, 0x2498, NULL,         NULL,          "Tyan",        "S2498 (Tomcat K7M)", board_asus_a7v8x_mx},
> > {0x1106, 0x0314, 0x1106, 0xaa08,  0x1106, 0x3227, 0x1106, 0xAA08, NULL,         NULL,          "VIA",         "EPIA-CN",            board_via_epia_sp},
>
> Three things:
> return the value of the it8705f_write_enable in
>
> it8705f_write_enable_2e

Done.
> check whether we can match any board ids there.

Done, I've decided to use the USB and audio devices instead of the above,
those seem to have usable subsystem IDs (see lspci). Thus, the board
is now autodetected and doesn't need an -m option.
> please attach lspci -vnn for future reference.

Done.
> Once done: Acked-by: Luc Verhaegen

Thanks, r616.

Uwe.