Remove src/northbridge/amd/amdmct/mct/mct.h, which is not used any more.
No attached patches to reduce confusing.
Signed-off-by: Zheng Bao zheng.bao@amd.com
BTW, I tried to use the following way to create patch. 1. svn delete src/northbridge/amd/amdmct/mct/mct.h 2. svn diff > remove.patch But when I tried to apply the patch, it just makes the mct.h empty instead of deleting it.
How to create a patch in this case?
Zheng
-----Original Message----- From: coreboot-bounces+zheng.bao=amd.com@coreboot.org
[mailto:coreboot-
bounces+zheng.bao=amd.com@coreboot.org] On Behalf Of Bao, Zheng Sent: Saturday, October 09, 2010 10:37 AM To: Coreboot Subject: [coreboot] [patch]: Remove
src/northbridge/amd/amdmct/mct/mct.h
Remove src/northbridge/amd/amdmct/mct/mct.h, which is not used any
more.
No attached patches to reduce confusing.
Signed-off-by: Zheng Bao zheng.bao@amd.com
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
On Fri, Oct 8, 2010 at 11:29 PM, Bao, Zheng Zheng.Bao@amd.com wrote:
BTW, I tried to use the following way to create patch.
- svn delete src/northbridge/amd/amdmct/mct/mct.h
- svn diff > remove.patch
But when I tried to apply the patch, it just makes the mct.h empty instead of deleting it.
How to create a patch in this case?
How did you apply the patch?
See the -E option of patch(1) for more info.
wt
On Sat, Oct 09, 2010 at 10:37:22AM +0800, Bao, Zheng wrote:
Remove src/northbridge/amd/amdmct/mct/mct.h, which is not used any more.
No attached patches to reduce confusing.
Signed-off-by: Zheng Bao zheng.bao@amd.com
Looks like that file was never used or #included at all, indeed. But what is the difference to mct_d.h (which _is_ used)? The latter is pretty similar to mct.h, but not quite the same. What does the "_d" suffix stand for? Can mct.h be safely removed and is it not needed later?
If yes:
Acked-by: Uwe Hermann uwe@hermann-uwe.de
Uwe.
]> Remove src/northbridge/amd/amdmct/mct/mct.h, which is not used any more. ]> ]> No attached patches to reduce confusing. ]> ]> Signed-off-by: Zheng Bao zheng.bao@amd.com ] ]Looks like that file was never used or #included at all, indeed. But ]what is the difference to mct_d.h (which _is_ used)? The latter is ]pretty similar to mct.h, but not quite the same. What does the "_d" ]suffix stand for? Can mct.h be safely removed and is it not needed later?
The suffix "_d" is for Deerhound, a family10 processor. I believe the agesa team originally added _d to files to distinguish between files for family 0Fh and filers for family 10h. A newer naming convention embeds into the file name characters such as F10, F12, or 0x10, x12.
Thanks, Scott
]If yes: ] ]Acked-by: Uwe Hermann uwe@hermann-uwe.de ] ] ]Uwe. ]-- ]http://hermann-uwe.de | http://sigrok.org ]http://randomprojects.org | http://unmaintained-free-software.org