On 11/02/08 19:10 -0800, Chris Kilgour wrote:
[openvsa] provide default pointer initializer to avoid compiler warning
Signed-off by: Chris Kilgour techie@whiterocker.com
Acked-by: Jordan Crouse jordan.crouse@amd.com
Index: sysmgr/timeout.c
--- sysmgr/timeout.c (revision 4) +++ sysmgr/timeout.c (working copy) @@ -369,7 +369,7 @@ UCHAR i, j, k; MBIU_INFO *MbiuPtr; register DESCRIPTOR *Descr = (DESCRIPTOR *) 0;
- register PHYSICAL_COUNTERS *PhysPtr;
register PHYSICAL_COUNTERS *PhysPtr = (PHYSICAL_COUNTERS *) 0; register LOGICAL_COUNTERS *LogicalPtr;
Flags = (ULONG) Attr << 16;
-- coreboot mailing list coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Chris Kilgour wrote:
provide default pointer initializer to avoid compiler warning
Signed-off by: Chris Kilgour techie@whiterocker.com
Acked-by: Marc Jones marc.jones@amd.com
On Mon, Feb 11, 2008 at 07:10:07PM -0800, Chris Kilgour wrote:
[openvsa] provide default pointer initializer to avoid compiler warning
Signed-off by: Chris Kilgour techie@whiterocker.com
Acked-by: Peter Stuge peter@stuge.se
Hello! If it helps, Peter, everybody else, I can safely state that the patch that Chris submitted to the group worked here on my tree.
I have successfully checked out the tree and applied the patch to it. It then compiled properly and without even a complaint. I was able to do this both under the root user, which Chris believes takes a lot of trust, and I agree with that. And it also compiles properly under a regular user.
Since this confirms both his theories and my perceptions of the current series of trees for the Geode processor: I shall probably within a number of days, perhaps within weeks be able to supply both an image for the flash memory for the Coreboot stage, and of course the OpenVSA component as well, to be tested on randomly available examples of hardware as my units are going to be on a very lengthy order cycle.
I now am going to request suggestions for making these items available. I do not want to send them out via the list interface. -- Gregg C Levine hansolofalcon@worldnet.att.net "The Force will be with you always." Obi-Wan Kenobi
-----Original Message----- From: coreboot-bounces@coreboot.org [mailto:coreboot-bounces@coreboot.org]
On
Behalf Of Peter Stuge Sent: Tuesday, February 12, 2008 2:16 PM To: coreboot@coreboot.org Subject: Re: [coreboot] [openvsa] patch: pointer init to avoid
compilerwarning
On Mon, Feb 11, 2008 at 07:10:07PM -0800, Chris Kilgour wrote:
[openvsa] provide default pointer initializer to avoid compiler warning
Signed-off by: Chris Kilgour techie@whiterocker.com
Acked-by: Peter Stuge peter@stuge.se
-- coreboot mailing list coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
On Tue, Feb 12, 2008 at 08:15:46PM +0100, Peter Stuge wrote:
Signed-off by: Chris Kilgour techie@whiterocker.com
'Signed-off-by' please. The commit hook is not in place yet, which is why this didn't abort the commit with a warning, but we should still try to be consistent.
Acked-by: Peter Stuge peter@stuge.se
This is r5 btw.
Chris, please post a reply to all patches you commit saying something like "Comitted in r123" (where 123 is the svn revision of the commit), so we can easily keep track of committed and non-committed patches on the mailing list.
Thanks! Uwe.