[LinuxBIOS] Adding STMicroelectronics and Atmel 256k parts to FlashRom?

[roger]

Is it possible to add these parts to FlashRom?
Atmel AT29C020 256k
STMicroelectronics M29F002 256k

I can read through the bios socket with l440gx module after "enabling
write" with FlashRom, but performing write operations to these parts
using gives me a permission denied error with mtd utils.

Currently, I'm just rebooting using a FreeDOS livecd and using UniFlash.
Tedious, but it works. :-/

Thu Apr 19 18:17:08 PDT 2007

[Uwe Hermann]

On Thu, Apr 19, 2007 at 06:17:10PM -0700, roger wrote:
> Is it possible to add these parts to FlashRom?
> Atmel AT29C020 256k
> STMicroelectronics M29F002 256k

Sure, please try attached patch and report whether it works (if so,
please send an Acked-By).

Note: this is just a random guess, I have no idea whether it'll really work!

Uwe.

[LinuxBIOS] Adding STMicroelectronics and Atmel 256k parts to FlashRom?

[roger]

On Fri, 2007-04-20 at 11:11 +0200, Uwe Hermann wrote:
> On Thu, Apr 19, 2007 at 06:17:10PM -0700, roger wrote:
> > Is it possible to add these parts to FlashRom?
> > Atmel AT29C020 256k

Read & Write seems ok for this Atmel.  I've checked using a factory
bios.bin and also writing a linuxbios.rom file.  Boots with flashing
with a factory bios.bin.  So this chip is probably well tested here. :-)
> > STMicroelectronics M29F002 256k

Problematic.  I see the patch provides addresses for this chip instead
of using the jedec_probe for probe/read/write functions.

Altering the addresses for teh MDF002* chips to use the jedec_probe
functions seems to work.

I have test read the MDF002T chip here.  I don't want to write to it
because it's the chip that came with this board.

On a side note, both of these chips, I do

# ./flashrom -r test.bin

# diff /dev/mtd0ro ./test.bin 
or
# cmp /dev/mtd0ro ./test.bin

Both tests state the files differ or EOF.

But if I do:
# dd if=/dev/mtd0ro of=./test.bin

#diff /dev/mtd0ro ./test.bin

diff states the files are the same.

<shrugs> I'm probably doing something wrong here. :-/
> Sure, please try attached patch and report whether it works (if so,
> please send an Acked-By).

Add my patch.

Fri Apr 20 14:23:49 PDT 2007

[LinuxBIOS] Adding STMicroelectronics and Atmel 256k parts to FlashRom?

[roger]

On Fri, 2007-04-20 at 11:11 +0200, Uwe Hermann wrote:
> On Thu, Apr 19, 2007 at 06:17:10PM -0700, roger wrote:
> > Is it possible to add these parts to FlashRom?
> > Atmel AT29C020 256k
> > STMicroelectronics M29F002 256k
>
> Sure, please try attached patch and report whether it works (if so,
> please send an Acked-By).
>
> Note: this is just a random guess, I have no idea whether it'll really work!

Sorry, here's the patch.

Fri Apr 20 14:25:32 PDT 2007

[Uwe Hermann]

Your patch is missing a sign-off, thus cannot be committed.

http://linuxbios.org/Development_Guidelines#Sign-off_Procedure

I updated my patch to use jedec* functions everywhere, please ack.

On Fri, Apr 20, 2007 at 02:26:06PM -0700, roger wrote:
> diff -uN ./flashrom/README ./flashrom.mine/README
> --- ./flashrom/README	2007-04-09 15:59:22.000000000 -0700
> +++ ./flashrom.mine/README	2007-04-20 14:03:52.000000000 -0700

Try 'svn diff', that's a lot easier :)
> {"M29F040B",	ST_ID, 		ST_M29F040B,	NULL, 512, 64 * 1024,
> probe_29f040b, erase_29f040b,	write_29f040b,	NULL},

I've changed this one to use the jedec* functions, too. Untested, of
course, but if the others work then this one probably does, too.

Uwe.

[LinuxBIOS] Adding STMicroelectronics and Atmel 256k parts to FlashRom?

[roger]

On Sun, 2007-04-22 at 03:02 +0200, Uwe Hermann wrote:
> Your patch is missing a sign-off, thus cannot be committed.
>
> http://linuxbios.org/Development_Guidelines#Sign-off_Procedure

Interesting.

Sat Apr 21 22:05:28 PDT 2007

[LinuxBIOS] Adding STMicroelectronics and Atmel 256k parts to FlashRom?

[roger]

On Sun, 2007-04-22 at 03:02 +0200, Uwe Hermann wrote:
> Your patch is missing a sign-off, thus cannot be committed.
>
> http://linuxbios.org/Development_Guidelines#Sign-off_Procedure
>
> I updated my patch to use jedec* functions everywhere, please ack.
>
> On Fri, Apr 20, 2007 at 02:26:06PM -0700, roger wrote:
> > diff -uN ./flashrom/README ./flashrom.mine/README
> > --- ./flashrom/README	2007-04-09 15:59:22.000000000 -0700
> > +++ ./flashrom.mine/README	2007-04-20 14:03:52.000000000 -0700
>
> Try 'svn diff', that's a lot easier :)
> > {"M29F040B",	ST_ID, 		ST_M29F040B,	NULL, 512, 64 * 1024,
> > probe_29f040b, erase_29f040b,	write_29f040b,	NULL},
>
> I've changed this one to use the jedec* functions, too. Untested, of
> course, but if the others work then this one probably does, too.

I've just noticed a small, appropriately described as trivial, bug.

There is no jedec_erase function.  The correct function to call is
jedec_chip_erase.

This initially also gave me a spin with the naming consistancy of this
function compared to other jedec_* calls (ie. probe_jedec &
write_jedec).

With this bug, Atmel AT29C020 chips are not detected.

I will practice using SVN tonight and submit a more official patch.

Wed Apr 25 17:17:23 PDT 2007

[LinuxBIOS] Adding STMicroelectronics and Atmel 256k parts to FlashRom?

[roger]

On Sun, 2007-04-22 at 03:02 +0200, Uwe Hermann wrote:
> I updated my patch to use jedec* functions everywhere, please ack.
> Try 'svn diff', that's a lot easier :)

Oh yea! Much much easier!
> > {"M29F040B",	ST_ID, 		ST_M29F040B,	NULL, 512, 64 * 1024,
> > probe_29f040b, erase_29f040b,	write_29f040b,	NULL},
>
> I've changed this one to use the jedec* functions, too. Untested, of
> course, but if the others work then this one probably does, too.

Renamed to properly use erase_chip_jedec & attached patch as mentioned
within the previous email including following LinuxBios Dev guidelines.

Wed Apr 25 23:32:37 PDT 2007

[Uwe Hermann]

On Wed, Apr 25, 2007 at 11:37:52PM -0700, roger wrote:
> Renamed to properly use erase_chip_jedec & attached patch as mentioned
> within the previous email including following LinuxBios Dev guidelines.

Oops, yeah, erase_jedec() is wrong, of course.
> Add initial support for the following flash chips:
> Atmel AT29C020
> STMicroelectronics M29F002B
> STMicroelectronics M29F002T
> STMicroelectronics M29F002NT
>
> Signed-off-by: Roger Zauner

Please never remove Signed-off-by lines, only add new ones
(see attached patch).

This patch is ready to be committed now, IHMO. Someone please ack
and/or commit.

Uwe.

[Peter Stuge]

On Sat, Apr 28, 2007 at 01:28:11AM +0200, Uwe Hermann wrote:
> This patch is ready to be committed now, IHMO. Someone please ack
> and/or commit.

Ack, r2621.

However, I didn't like reordering the list of chips.

And please always do svn diff from the root of the tree.

//Peter

[LinuxBIOS] Adding STMicroelectronics and Atmel 256k parts to FlashRom?

[roger]

On Sat, 2007-04-28 at 04:24 +0200, Peter Stuge wrote:
> On Sat, Apr 28, 2007 at 01:28:11AM +0200, Uwe Hermann wrote:
> > This patch is ready to be committed now, IHMO. Someone please ack
> > and/or commit.
>
> Ack, r2621.
>
> However, I didn't like reordering the list of chips.

Didn't even think of this when I was working on it.
> And please always do svn diff from the root of the tree.

sorry.
--
Roger
http://www.eskimo.com/~roger/index.html
Key fingerprint = 8977 A252 2623 F567 70CD 1261 640F C963 1005 1D61

Fri Apr 27 20:17:36 PDT 2007