Re: [coreboot] r3373 - trunk/util/flashrom

[Carl-Daniel Hailfinger]

On 21.06.2008 02:19, [e-mail] wrote:
> Author: stuge
> Date: 2008-06-21 02:19:52 +0200 (Sat, 21 Jun 2008)
> New Revision: 3373
>
> Modified:
>    trunk/util/flashrom/jedec.c
> Log:
> flashrom: Increase delay in probe_jedec() to 2ms to reliably detect AT29C020
>
> Run time is increased a few 100ms but this is needed for reliability.
> I consider this trivial.

Please fix the comment above your change to match the new reality. Thanks.
> Signed-off-by: Peter Stuge 
> Acked-by: Peter Stuge
> Modified: trunk/util/flashrom/jedec.c
>
> --- trunk/util/flashrom/jedec.c	2008-06-20 02:58:42 UTC (rev 3372)
> +++ trunk/util/flashrom/jedec.c	2008-06-21 00:19:52 UTC (rev 3373)
> @@ -103,7 +103,7 @@
>     * needs 10 ms according to the data sheet, but it has been tested
>     * to work reliably with 20 us. Allow a factor of 2 safety margin.
>     */
> myusec_delay(40);
>
> myusec_delay(2000);
>
> /* Read product ID */
> id1 = *(volatile uint8_t *)bios;

Regards,
Carl-Daniel

r3373 - trunk/util/flashrom

[Peter Stuge]

On Sat, Jun 21, 2008 at 02:52:10AM +0200, Carl-Daniel Hailfinger wrote:
> Please fix the comment above your change to match the new reality.

Yeah, good idea. r3375

//Peter