svn@openbios.org wrote:
Cosmetic changes to make the flashrom output more consistent (trivial).
printf("OK.\n");
printf("OK\n");
Removing the periods makes the output inconsistent. Please dont do this.
printf("Flash image seems to be a legacy BIOS. Disabling checks.\n");
printf("Flash image seems to be a legacy BIOS - disabling checks\n");
Why is this considered more consistent than before ? Removing periods from complete sentences is wrong.
printf_debug("LinuxBIOS last image size "
"(not rom size) is %d bytes.\n", *walk);
"(not ROM size) is %d bytes\n", *walk);
You are removing all dots all over the place. It was consistent before. Why did you change this? I put all of them there on purpose before. :-(
printf_debug("This firmware image matches "
"this motherboard.\n");
"this motherboard\n");
Full sentences should end with a period.
} else { if (force) { printf("WARNING: This firmware image does not "
"seem to fit to this machine - forcing it.\n");
"seem to fit to this machine - forcing it\n");
... It seems this was pretty consistent before. And it was correct.
if (i & 1) {
if (i & 1) value <<= 8;
}
Please don't do this.
Stefan
OK, second try, this time adding instead of removing full stops.
Uwe.
* Uwe Hermann uwe@hermann-uwe.de [071010 20:47]:
OK, second try, this time adding instead of removing full stops.
Uwe.
http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
Some cosmetic cleanups in the flashrom code and output.
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de
if (ret)
printf("Failed!\n");
printf("failed!\n");
Since we use a capital "OK" some times, should we also use a capital FAILED ? This is usually a pretty nasty situation.
fprintf(stdout, "Found LinuxBIOS table at: %08lx\n", addr);
fprintf(stdout, "Found LinuxBIOS table at 0x%08lx.\n", addr);
Maybe even %p?
printf_debug("lb_table found at address %p\n", lb_table);
printf_debug("LinuxBIOS table found at 0x%p.\n", lb_table);
%p already prints 0x on my system... so this would be 0x0x00000500 or so
if (board) {
printf("Found board \"%s\": Enabling flash write... ",
printf("Found board \"%s\", enabling flash write... ", board->name);ret = board->enable(board->name); if (ret)
printf("Failed!\n");
printf("failed!\n");
I'd rather leave words after periods capital. Maybe we should even CAPITALIZE it completely since it's a failure condition?
Stefan
On Thu, Oct 11, 2007 at 06:55:05PM +0200, Stefan Reinauer wrote:
printf("Failed!\n");
printf("failed!\n");FAILED ? This is usually a pretty nasty situation.
I like FAILED.
printf("Failed!\n");
printf("failed!\n");CAPITALIZE
Yeah.
//Peter
On Fri, Oct 12, 2007 at 11:23:03AM +0200, Peter Stuge wrote:
On Thu, Oct 11, 2007 at 06:55:05PM +0200, Stefan Reinauer wrote:
printf("Failed!\n");
printf("failed!\n");FAILED ? This is usually a pretty nasty situation.
I like FAILED.
printf("Failed!\n");
printf("failed!\n");CAPITALIZE
Yeah.
Agreed. Updated patch attached.
Uwe.
On Fri, Oct 12, 2007 at 12:54:22PM +0200, Uwe Hermann wrote:
printf("Failed!\n");
printf("failed!\n");CAPITALIZE
Yeah.
Agreed. Updated patch attached.
*ping*
Does the patch look ok now?
Uwe.
* Uwe Hermann uwe@hermann-uwe.de [071017 01:45]:
On Fri, Oct 12, 2007 at 12:54:22PM +0200, Uwe Hermann wrote:
printf("Failed!\n");
printf("failed!\n");CAPITALIZE
Yeah.
Agreed. Updated patch attached.
*ping*
Does the patch look ok now?
Acked-by: Stefan Reinauer stepan@coresystems.de
On Wed, Oct 17, 2007 at 09:16:52AM +0200, Stefan Reinauer wrote:
Acked-by: Stefan Reinauer stepan@coresystems.de
r2873.
Uwe.
-
Peter Stuge -
Stefan Reinauer -
Uwe Hermann