Does anyone know how much code is needed in v3 to parse the ELF format? It seems like that capability can be removed, since lar parses ELF and lar has to be used to add files to v3.
A side benefit would be not having to maintain two versions of an ELF parser.
Myles
On Feb 13, 2008 11:03 AM, Myles Watson myles@pel.cs.byu.edu wrote:
Does anyone know how much code is needed in v3 to parse the ELF format? It seems like that capability can be removed, since lar parses ELF and lar has to be used to add files to v3.
The ELF parser in v3 ought to be removed. Then the 'legacy' code can be removed too, and we have shrunk v3, and removed any elf parsing issues in v3.
I only left the ELF code in v3 until such time as we were sure everything worked. With the .bss patch I just committed, there are no problems left of which I am aware.
I would welcome this patch.
ron
On Wed, Feb 13, 2008 at 12:33:48PM -0800, ron minnich wrote:
The ELF parser in v3 ought to be removed.
Do you mean elfboot?
//Peter
On Wed, Feb 13, 2008 at 4:44 PM, Peter Stuge peter@stuge.se wrote:
On Wed, Feb 13, 2008 at 12:33:48PM -0800, ron minnich wrote:
The ELF parser in v3 ought to be removed.
Do you mean elfboot?
yes indeed.
One big reason is that you don't want to find out, after you have burned an elf into the coreboot image, that the elf has a problem.
When LAR parses the ELF, you know at coreboot build time that things are probably ok. When coreboot parses the ELF, you don't know until power on/reset -- a very bad time to find out there is a problem.
So elfboot should be removed from coreboot. We don't need it in there.
ron
ron minnich wrote:
On Wed, Feb 13, 2008 at 4:44 PM, Peter Stuge peter@stuge.se wrote:
On Wed, Feb 13, 2008 at 12:33:48PM -0800, ron minnich wrote:
The ELF parser in v3 ought to be removed.
Do you mean elfboot?
yes indeed.
One big reason is that you don't want to find out, after you have burned an elf into the coreboot image, that the elf has a problem.
When LAR parses the ELF, you know at coreboot build time that things are probably ok. When coreboot parses the ELF, you don't know until power on/reset -- a very bad time to find out there is a problem.
So elfboot should be removed from coreboot. We don't need it in there.
Please, lets not make any quick decisions here. We can disable it per default with a CONFIG option for those who do not want it. But unless lar does the right thing when packing/unpacking/packing a lar, this should not be removed. It's so small, it really doesnt hurt.
-
Myles Watson -
Peter Stuge -
ron minnich -
Stefan Reinauer