break out ide from cs5536. Next we can look at optionally not even compiling it in.
not signed off as it is maybe not what you want.
ron
On 09.05.2008 00:38, ron minnich wrote:
break out ide from cs5536. Next we can look at optionally not even compiling it in.
not signed off as it is maybe not what you want.
It's mostly what I have in mind as well, but you forgot to svn add the new ide.c file, so no Ack yet.
Regards, Carl-Daniel
On Thu, May 08, 2008 at 03:38:22PM -0700, ron minnich wrote:
break out ide from cs5536.
not signed off as it is maybe not what you want.
I think we should take an approach on this similar to the kernel.
Look at networking drivers. Most are a single c file, but some have their own directory with many files.
We always have a directory, but I still like one file over many, even if that one file becomes largeish.
Many files makes that greppy tree.
//Peter
On Thu, May 8, 2008 at 3:59 PM, Peter Stuge peter@stuge.se wrote:
I think we should take an approach on this similar to the kernel.
Look at networking drivers. Most are a single c file, but some have their own directory with many files.
We always have a directory, but I still like one file over many, even if that one file becomes largeish.
Many files makes that greppy tree.
That's why I didn't sign it off. I'm going to revert for now.
ron
On 09.05.2008 01:15, ron minnich wrote:
On Thu, May 8, 2008 at 3:59 PM, Peter Stuge peter@stuge.se wrote:
I think we should take an approach on this similar to the kernel.
Look at networking drivers. Most are a single c file, but some have their own directory with many files.
We always have a directory, but I still like one file over many, even if that one file becomes largeish.
Many files makes that greppy tree.
That's why I didn't sign it off. I'm going to revert for now.
OK, fine with me. Once my cs5536 cleanup patch with Subject: Re: [coreboot] [PATCH] [RFC] v3: CS5536 cleanup is reviewed and merged, I can continue the cleanup process and we'll see how it ends.
Regards, Carl-Daniel