the patches of AMD s1g1 socket

[Xie, Michael]

Hi,
    The attachments are the patches of AMD S1G1 socket, one located at CPU folder and the other located at Northbridge folder.

Signed-off-by:  Michael Xie [e-mail]

<<s1g1_cpu.patch>>  <<s1g1_k8.patch>>

[Carl-Daniel Hailfinger]

On 19.09.2008 03:44, Xie, Michael wrote:
> The attachments are the patches of AMD S1G1 socket, one located at CPU folder and the other located at Northbridge folder.
>
> Signed-off-by:  Michael Xie [e-mail]

Can someone else please review and commit? I roughly outlined in an
earlier thread with the same patches that we have to check the added
copyright header (a few persons are missing), some whitespace fixups,
then it looks good to go.

Stefan? Ron?

Regards,
Carl-Daniel

[ron minnich]

OK I am acking this patch.

What I would request is that in future all the k8 code be processed by:
indent -kr -i 8

before a patch is made.

But we can clean this up, it is important to get this code in.

Acked-by: Ronald G. Minnich

[Marc Jones]

I will check it in and then do a whitespace cleanup checkin today.
If someone wants to give me the other copyright holders I can also add that.

Marc

ron minnich wrote:
> OK I am acking this patch.
>
> What I would request is that in future all the k8 code be processed by:
> indent -kr -i 8
>
> before a patch is made.
>
> But we can clean this up, it is important to get this code in.
>
> Acked-by: Ronald G. Minnich

[ron minnich]

I think these are the proper extra copyright holders (from v3)
 * Copyright (C) 2002 Linux Networx
 * (Written by Eric Biederman  for Linux Networx)
 * Copyright (C) 2004 YingHai Lu

[Marc Jones]

ron minnich wrote:
> I think these are the proper extra copyright holders (from v3)
> Copyright (C) 2002 Linux Networx
> (Written by Eric Biederman  for Linux Networx)
> Copyright (C) 2004 YingHai Lu

Thanks, I will add that.

[Peter Stuge]

ron minnich wrote:
> But we can clean this up, it is important to get this code in.

History shows that we don't, although we can, and that a few years
later someone else comes along and doesn't understand a thing. :\

//Peter

[ron minnich]

On Fri, Sep 19, 2008 at 10:05 AM, Peter Stuge  wrote:
> ron minnich wrote:
> > But we can clean this up, it is important to get this code in.
>
> History shows that we don't, although we can, and that a few years
> later someone else comes along and doesn't understand a thing. :\

I've got a commitment from AMD to do a whitespace/copyright fix, and I
trust 'em :-)

It's gonna be fine :-)

ron

[Marc Jones]

ron minnich wrote:
> OK I am acking this patch.
>
> What I would request is that in future all the k8 code be processed by:
> indent -kr -i 8
>
> before a patch is made.
>
> But we can clean this up, it is important to get this code in.
>
> Acked-by: Ronald G. Minnich

Added copyright and fixed some whitespace in the new code. A more 
complete whitespace cleanup to follow this checkin.

r3585
Thanks Michael and Ron.
Marc

[Marc Jones]

Marc Jones wrote:
> ron minnich wrote:
> > OK I am acking this patch.
> >
> > What I would request is that in future all the k8 code be processed by:
> > indent -kr -i 8
> >
> > before a patch is made.
> >
> > But we can clean this up, it is important to get this code in.
> >
> > Acked-by: Ronald G. Minnich
>
> Added copyright and fixed some whitespace in the new code. A more 
> complete whitespace cleanup to follow this checkin.
>
> r3585
> Thanks Michael and Ron.
> Marc

Whitespace and style cleanup.
r3586

Thanks,
Marc

[Jordan Crouse]

On 19/09/08 09:44 +0800, Xie, Michael wrote:
> Hi,
>    The attachments are the patches of AMD S1G1 socket, one located at CPU folder and the other located at Northbridge folder.
>
> Signed-off-by:  Michael Xie [e-mail]

To make reviewing somewhat easier, here is the s1g1_k8.patch with -p1 
applied.  No code changes.

Jordan