Re: [coreboot] r1145 - in coreboot-v3: arch/x86 arch/x86/intel/core2 device include lib mainboard/kontron/986lcd-m

[Pattrick Hueper]

Hi,

On Wed, Mar 11, 2009 at 5:17 PM,   wrote:
...
> cpu_phase2(is_coldboot(), sysinfo);

This breaks the qemu-x86 build for me... is_coldboot() is undefined,
it is only defined in northbridge/intel/i945/reset_test.c

I have changed the CFLAGS to include -g to make debugging in qemu-x86
with gdb possible, dont know if that has anything to do with it...

Cheers, Patty

r1145 - in coreboot-v3: arch/x86 arch/x86/intel/core2 device include lib mainboard/kontron/986lcd-m

[ron minnich]

On Fri, Mar 13, 2009 at 2:27 PM, Pattrick Hueper  wrote:
> Hi,
>
> On Wed, Mar 11, 2009 at 5:17 PM,   wrote:
> ...
> > cpu_phase2(is_coldboot(), sysinfo);

Take it out for now. I'll ack any patch to fix what I broke :-)

ron

r1145 - in coreboot-v3: arch/x86 arch/x86/intel/core2 device include lib mainboard/kontron/986lcd-m

[Pattrick Hueper]

Well...

i did this:

--- a/northbridge/intel/i440bxemulation/i440bx.c
+++ b/northbridge/intel/i440bxemulation/i440bx.c
@@ -184,3 +184,10 @@ struct device_operations i440bx_northbridge = {
        .ops_pci_bus             = &pci_cf8_conf1,

};
+
+int is_coldboot(void)
+{
+       int boot_mode = 0;
+       return boot_mode;
+}
+

but it obviously only fixes the problem for qemu-x86...

Cheers, Patty

On Fri, Mar 13, 2009 at 10:35 PM, ron minnich  wrote:
> On Fri, Mar 13, 2009 at 2:27 PM, Pattrick Hueper  wrote:
> > Hi,
> >
> > On Wed, Mar 11, 2009 at 5:17 PM,   wrote:
> > ...
> > > cpu_phase2(is_coldboot(), sysinfo);
>
> Take it out for now. I'll ack any patch to fix what I broke :-)
>
> ron

r1145 - in coreboot-v3: arch/x86 arch/x86/intel/core2 device include lib mainboard/kontron/986lcd-m

[Mart Raudsepp]

Ühel kenal päeval, R, 2009-03-13 kell 22:47, kirjutas Pattrick Hueper:
> Well...
>
> i did this:
>
> --- a/northbridge/intel/i440bxemulation/i440bx.c
> +++ b/northbridge/intel/i440bxemulation/i440bx.c
> @@ -184,3 +184,10 @@ struct device_operations i440bx_northbridge = {
>         .ops_pci_bus             = &pci_cf8_conf1,
>
> };
>
> +int is_coldboot(void)
> +{
>   int boot_mode = 0;
>   return boot_mode;
>
> +}
>
> but it obviously only fixes the problem for qemu-x86...

Yes, this is breaking all boards besides intel i945 ones obviously.
DBE62 is broken too right now still. No time dealing with fixing what
was broken right now, so I will simply make a quick local workaround to
be able to work on my own small patches.

Regards,
Mart Raudsepp