Patches moved to main branch lost review scores

[Compostella, Jeremy]

Hi,

Most of my gerrit patches moved to the main branch over the
week-end. But they lost reviews score such +2 or V+1. Typically,
https://review.coreboot.org/c/coreboot/+/77615. If V+1 is mandatory
how do I trigger the Jenkins gerrit build ?

Regards,

[Felix Singer]

Hi Jeremy,

Jenkins builds can be just triggered by editing the commit message
without doing any changes to it. Just save it, which updates the commit
date. That is enough to trigger Jenkins.

For instance, run `git commit --amend`, don't do any changes, just save
it and repush as usual (though with HEAD:refs/for/main now).

Felix

On Mon, 2023-09-11 at 14:37 -0700, Compostella, Jeremy wrote:
> Hi,
>
> Most of my gerrit patches moved to the main branch over the
> week-end. But they lost reviews score such +2 or V+1. Typically,
> https://review.coreboot.org/c/coreboot/+/77615. If V+1 is mandatory
> how do I trigger the Jenkins gerrit build ?
>
> Regards,

[Martin Roth]

I'll work on running things through jenkins again, but it's going to take a while to get all of the patches done. If anyone has a specific patch they need to get verified, rebasing it on top of the main branch is a good way to get jenkins to pick it up again.

*Please* do not rebase huge patch trains - this ties up the builders for long periods of time and prevents other people from getting their patches checked. 5 or 10 at a time should be okay, but beyond 10 patches, rebase the train in stages so that other people can use the builders as well. This isn't just now - this is a general rule mentioned in the gerrit guidelines document.

Martin

Sep 12, 2023, 09:44 by [e-mail]:
> Hi Jeremy,
>
> Jenkins builds can be just triggered by editing the commit message
> without doing any changes to it. Just save it, which updates the commit
> date. That is enough to trigger Jenkins.
>
> For instance, run `git commit --amend`, don't do any changes, just save
> it and repush as usual (though with HEAD:refs/for/main now).
>
> Felix
>
> On Mon, 2023-09-11 at 14:37 -0700, Compostella, Jeremy wrote:
> > Hi,
> >
> > Most of my gerrit patches moved to the main branch over the
> > week-end. But they lost reviews score such +2 or V+1. Typically,
> > https://review.coreboot.org/c/coreboot/+/77615. If V+1 is mandatory
> > how do I trigger the Jenkins gerrit build ?
> >
> > Regards,
>
> coreboot mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]