[PATCH] [v3] add pcengines alix.2c3

[Ward Vandewege]

Another product of the Denver summit. Thanks to the expert guidance of Ron,
Marc, Jordan and Stepan as well as the quality of the alix.1c v3 code, this
was probably the easiest port ever.

This patch is largely a copy-and-past from the alix.1c board, with some
tweaks (no superio, and the irqs are routed a bit differently).

One outstanding issue still - the usb ports fight over an interrupt with
eth2. Hopefully that will get fixed soon.

Tested on real hardware.

Thanks,
Ward.

[Carl-Daniel Hailfinger]

On 10.04.2008 03:14, Ward Vandewege wrote:
> Another product of the Denver summit. Thanks to the expert guidance of Ron,
> Marc, Jordan and Stepan as well as the quality of the alix.1c v3 code, this
> was probably the easiest port ever.
>
> This patch is largely a copy-and-past from the alix.1c board, with some
> tweaks (no superio, and the irqs are routed a bit differently).
>
> One outstanding issue still - the usb ports fight over an interrupt with
> eth2. Hopefully that will get fixed soon.
>
> Tested on real hardware.

Great work!

I'd like to see two "changes" before you commit, though:

- Use svn cp wherever possible. That helps to document the ancestry of
the code.
- Remove the unwanted_vpci stuff for now. I want to review that code
separately in depth and holding up alix.2c3 because of pending
unwanted_vpci reviews would be bad.

Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[Marc Jones]

Carl-Daniel Hailfinger wrote:
> On 10.04.2008 03:14, Ward Vandewege wrote:
> > Another product of the Denver summit. Thanks to the expert guidance of Ron,
> > Marc, Jordan and Stepan as well as the quality of the alix.1c v3 code, this
> > was probably the easiest port ever.
> >
> > This patch is largely a copy-and-past from the alix.1c board, with some
> > tweaks (no superio, and the irqs are routed a bit differently).
> >
> > One outstanding issue still - the usb ports fight over an interrupt with
> > eth2. Hopefully that will get fixed soon.
> >
> > Tested on real hardware.
>
> Great work!
>
> I'd like to see two "changes" before you commit, though:
> Use svn cp wherever possible. That helps to document the ancestry of
>
> the code.
> Remove the unwanted_vpci stuff for now. I want to review that code
>
> separately in depth and holding up alix.2c3 because of pending
> unwanted_vpci reviews would be bad.
>
> Acked-by: Carl-Daniel Hailfinger
>
> Regards,
> Carl-Daniel

Since the vpci patches have been acked, I think that this is ready to go.
Acked-by: Marc Jones

Marc

[Ward Vandewege]

On Thu, Apr 17, 2008 at 11:13:58AM -0600, Marc Jones wrote:
> > I'd like to see two "changes" before you commit, though:
> > Use svn cp wherever possible. That helps to document the ancestry of
> >
> > the code.

Done.
> > Acked-by: Carl-Daniel Hailfinger
> >
> > Regards,
> > Carl-Daniel
>
> Since the vpci patches have been acked, I think that this is ready to go.
> Acked-by: Marc Jones

r663

Thanks!
Ward.