RE: Freebios2 recovery progress... moving enable_childrens_resour ces

[YhLu]

Eric,

Why moving 
enable_childrens_resources(dev);
from void pci_dev_enable_resources(struct device *dev)
to 
void pci_bus_enable_resources(struct device *dev)

the superio under the PCI device will not be enabled with resources.

Regards

YH

-----Original Message-----
From: YhLu 
Sent: Thursday, October 21, 2004 2:03 PM
To: [e-mail]
Cc: LinuxBIOS
Subject: RE: Freebios2 recovery progress...

It's OK.

PCI: 04:01.0 bridge ctrl <- 0003
PCI: 04:01.0 cmd <- 146
PCI: 05:04.0 cmd <- 142
PCI: 04:01.1 subsystem <- 10f1/2895
PCI: 04:01.1 cmd <- 146
PCI: 04:02.0 bridge ctrl <- 0003
PCI: 04:02.0 cmd <- 147
PCI: 06:06.0 cmd <- 143
PCI: 06:06.1 cmd <- 143

-----Original Message-----
From: YhLu 
Sent: Thursday, October 21, 2004 12:11 PM
To: '[e-mail]'
Cc: LinuxBIOS
Subject: RE: Freebios2 recovery progress...

I will test that on s2885.

I suspect that will need MEM enable too.

YH

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] 
Sent: Thursday, October 21, 2004 11:39 AM
To: YhLu
Cc: LinuxBIOS
Subject: Re: Freebios2 recovery progress...

YhLu  writes:
> You can not test that in arima board. Because all device on 8131 is using
> ioapic in amd8111.

I can't test that it works but I can test that the bits are getting
set by running lspci.   And that is how I tested.  The bus
master bit is still getting set.  I just move the location.

Eric
_______________________________________________
Linuxbios mailing list
[e-mail]
http://www.clustermatic.org/mailman/listinfo/linuxbios

Freebios2 recovery progress... moving enable_childrens_resour ces

YhLu  writes:
> Eric,
>
> Why moving 
> enable_childrens_resources(dev);
> from void pci_dev_enable_resources(struct device *dev)
> to 
> void pci_bus_enable_resources(struct device *dev)
>
> the superio under the PCI device will not be enabled with resources.

We have some busses like i2c where it really is nonsense, the devices
don't have any resources.

In addition we manually have to recurse for all of the other functions
so this is not much of a burden except right now when I have made the
change.

I actually forgot about LPC/ISA busses when I made that change so I forgot
to fix them up, I will do that shortly.

Eric