i2c-i810 code

What do you guys think about this? Is there any licensing issues I  
should be worried about??
> My $.02 is that it's fine as long as you are complying with the
> lm-sensors licensing.
>
> Phil
>
> On Apr 6, 2008, at 8:42 PM, [e-mail] wrote:
> > Hello,
> > I am a coreboot developer working on some code for and intel   
> > northbridge chipset (Intel 830M). This board has an embedded tv-out  
> >  chip and I was wondering if it would be ok to use parts of the   
> > i2c-i810.c code from lm-sensors for this project. It would be of   
> > course be released under the terms of the GNU GPL. What do you think?
> >
> > Thanks - Joe

[Uwe Hermann]

On Mon, Apr 07, 2008 at 08:18:20AM -0400, [e-mail] wrote:
> What do you guys think about this? Is there any licensing issues I  
> should be worried about??

Are we talking about this file?
http://lm-sensors.org/browser/lm-sensors/trunk/kernel/busses/i2c-i810.c

If yes, there is no problem. It's GPLv2-or-later and can be copied into
our repo (and adapted as needed), no problem. Just keep the complete
license header intact, of course.

The question is how much of that code you need, lots of it looks very
Linux-specific and would need quite some modifications. It might be
easier to write your own code from scratch for coreboot.

What exactly do you intend to do? Where's this code needed?

Uwe.

Quoting Uwe Hermann :
> On Mon, Apr 07, 2008 at 08:18:20AM -0400, [e-mail] wrote:
> > What do you guys think about this? Is there any licensing issues I
> > should be worried about??
>
> Are we talking about this file?
> http://lm-sensors.org/browser/lm-sensors/trunk/kernel/busses/i2c-i810.c

Yes
> If yes, there is no problem. It's GPLv2-or-later and can be copied into
> our repo (and adapted as needed), no problem. Just keep the complete
> license header intact, of course.
>
> The question is how much of that code you need, lots of it looks very
> Linux-specific and would need quite some modifications.

Yes
> It might be
> easier to write your own code from scratch for coreboot.

Probibly, but I could use certian functions from this code.
> What exactly do you intend to do? Where's this code needed?

This code will enable communications with the Conexant CX25873 tv-out  
chip via i2c through the northbridge GPIO lines. Then I can program  
the tv-out registers and initialize it. I'm still not exactly sure  
where this code will run. If can run before VGA is initialized that  
would be great. But it may have to run after, to get the correct clock  
and timing signals from the northbridge graphics, which means a  
modification to the coreboot core code.

Thanks - Joe

Quoting [e-mail]:
> Quoting Uwe Hermann :
> > On Mon, Apr 07, 2008 at 08:18:20AM -0400, [e-mail] wrote:
> > > What do you guys think about this? Is there any licensing issues I
> > > should be worried about??
> >
> > Are we talking about this file?
> > http://lm-sensors.org/browser/lm-sensors/trunk/kernel/busses/i2c-i810.c
>
> Yes
> > If yes, there is no problem. It's GPLv2-or-later and can be copied into
> > our repo (and adapted as needed), no problem. Just keep the complete
> > license header intact, of course.
> >
> > The question is how much of that code you need, lots of it looks very
> > Linux-specific and would need quite some modifications.
>
> Yes
> > It might be
> > easier to write your own code from scratch for coreboot.
>
> Probibly, but I could use certian functions from this code.
> > What exactly do you intend to do? Where's this code needed?
>
> This code will enable communications with the Conexant CX25873 tv-out
> chip via i2c through the northbridge GPIO lines. Then I can program
> the tv-out registers and initialize it. I'm still not exactly sure
> where this code will run. If can run before VGA is initialized that
> would be great. But it may have to run after, to get the correct clock
> and timing signals from the northbridge graphics, which means a
> modification to the coreboot core code.

Anyone know from what file the vga device init code is from???

Initializing devices...
Root Device init
PCI: 00:00.0 init
Northbridge init
PCI: 00:02.0 init <<<- WHERE IS THIS???
rom address for PCI: 00:02.0 = fff00000
PCI Expansion ROM, signature 0xaa55, INIT size 0x10000, data ptr 0x0040
PCI ROM Image, Vendor 8086, Device 3577,
PCI ROM Image,  Class Code 030000, Code Type 00
copying VGA ROM Image from 0xfff00000 to 0xc0000, 0x10000 bytes
entering emulator
halt_sys: file  
/home/joe/coreboot-v2/src/devices/emulator/x86emu/ops.c, line 4387
PCI: 00:1d.0 init
PCI: 00:1d.1 init

Thanks - Joe

TV-out init on i810

[Peter Stuge]

Some grepping later..

On Tue, Apr 08, 2008 at 06:47:44AM -0400, [e-mail] wrote:
> Anyone know from what file the vga device init code is from???
>
> Initializing devices...
> Root Device init
> PCI: 00:00.0 init
> Northbridge init
> PCI: 00:02.0 init <<<- WHERE IS THIS???

src/devices/device.c dev_initialize() which calls ops->init which is
pci_device.c pci_dev_init() for most if not all devices.
> rom address for PCI: 00:02.0 = fff00000
> PCI Expansion ROM, signature 0xaa55, INIT size 0x10000, data ptr 0x0040
> PCI ROM Image, Vendor 8086, Device 3577,
> PCI ROM Image,  Class Code 030000, Code Type 00
> copying VGA ROM Image from 0xfff00000 to 0xc0000, 0x10000 bytes
> entering emulator
> halt_sys: file  
> /home/joe/coreboot-v2/src/devices/emulator/x86emu/ops.c, line 4387

These are from pci_rom_probe() and pci_rom_load() in pci_rom.c and
run_bios() in emulator/biosemu.c.

//Peter

Quoting [e-mail]:
> Quoting [e-mail]:
> > Quoting Uwe Hermann :
> > > On Mon, Apr 07, 2008 at 08:18:20AM -0400, [e-mail] wrote:
> > > > What do you guys think about this? Is there any licensing issues I
> > > > should be worried about??
> > >
> > > Are we talking about this file?
> > > http://lm-sensors.org/browser/lm-sensors/trunk/kernel/busses/i2c-i810.c
> >
> > Yes
> > > If yes, there is no problem. It's GPLv2-or-later and can be copied into
> > > our repo (and adapted as needed), no problem. Just keep the complete
> > > license header intact, of course.
> > >
> > > The question is how much of that code you need, lots of it looks very
> > > Linux-specific and would need quite some modifications.
> >
> > Yes
> > > It might be
> > > easier to write your own code from scratch for coreboot.
> >
> > Probibly, but I could use certian functions from this code.
> > > What exactly do you intend to do? Where's this code needed?
> >
> > This code will enable communications with the Conexant CX25873 tv-out
> > chip via i2c through the northbridge GPIO lines. Then I can program
> > the tv-out registers and initialize it. I'm still not exactly sure
> > where this code will run. If can run before VGA is initialized that
> > would be great. But it may have to run after, to get the correct clock
> > and timing signals from the northbridge graphics, which means a
> > modification to the coreboot core code.
>
> Anyone know from what file the vga device init code is from???

Ok, looks like it just uses the default init. Also looks like I won't  
have to modify any coreboot core code to run the i2c-i810 after VGA is  
initialized. I can just setup a vga.c file in the northbridge for a  
custom vga init, and call it from there. Kind of like Corey did for  
the Via CN700, thanks Corey :-)

Thanks - Joe

> > > What exactly do you intend to do? Where's this code needed?
> >
> > This code will enable communications with the Conexant CX25873 tv-out
> > chip via i2c through the northbridge GPIO lines. Then I can program
> > the tv-out registers and initialize it. I'm still not exactly sure
> > where this code will run. If can run before VGA is initialized that
> > would be great. But it may have to run after, to get the correct clock
> > and timing signals from the northbridge graphics, which means a
> > modification to the coreboot core code.
>
> Anyone know from what file the vga device init code is from???

Ok, looks like it just uses the default init. Also looks like I won't  
have to modify any coreboot core code to run the i2c-i810 after VGA is  
initialized. I can just setup a vga.c file in the northbridge for a  
custom vga init, and call it from there. Kind of like Corey did for  
the Via CN700, thanks Corey :-)

Thanks - Joe

Quoting [e-mail]:
> Quoting Uwe Hermann :
> > What exactly do you intend to do? Where's this code needed?
>
> This code will enable communications with the Conexant CX25873 tv-out
> chip via i2c through the northbridge GPIO lines. Then I can program
> the tv-out registers and initialize it. I'm still not exactly sure
> where this code will run. If can run before VGA is initialized that
> would be great. But it may have to run after, to get the correct clock
> and timing signals from the northbridge graphics, which means a
> modification to the coreboot core code.

Ok, looks like it just uses the default init. Also looks like I won't  
have to modify any coreboot core code to run the i2c-i810 after VGA is  
initialized. I can just setup a vga.c file in the northbridge for a  
custom vga init, and call it from there. Kind of like Corey did for  
the Via CN700, thanks Corey :-)

Thanks - Joe

[Jordan Crouse]

On 07/04/08 08:18 -0400, [e-mail] wrote:
> What do you guys think about this? Is there any licensing issues I  
> should be worried about??

I don't think so - as long as the original code can be licensed under
the GPLv2, then you can use it in coreboot as long as you retain the
original copyright information.

Jordan
> > > Hello,
> > > I am a coreboot developer working on some code for and intel   
> > > northbridge chipset (Intel 830M). This board has an embedded tv-out  
> > >  chip and I was wondering if it would be ok to use parts of the   
> > > i2c-i810.c code from lm-sensors for this project. It would be of   
> > > course be released under the terms of the GNU GPL. What do you think?
> > >
> > > Thanks - Joe