Idwer Vollering (vidwer@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2340
-gerrit
commit c228d09ec218dc3590c5a218a527d7e819184eb4 Author: Idwer Vollering vidwer@gmail.com Date: Sat Feb 9 19:23:35 2013 +0100
crossgcc: fix building acpica on BSD/non-linux
Fix building acpica on BSD/non-linux. Rename patches/acpica-unix-20121114_drop_cflags_unknown_to_xcode.patch to patches/acpica-unix-20121114_drop_unknown_cflags.patch
Error message: cc1: warnings being treated as errors ../../../source/components/executer/exdump.c: In function 'AcpiExDumpObject': ../../../source/components/executer/exdump.c:516: warning: cast from function call of type 'const char *' to non-matching type 'unsigned int' gmake[2]: *** [obj32/exdump.o] Error 1
Also new is the removal of -Wempty-body. Reason of its removal: cc -c -O -m32 -D_CYGWIN -D_GNU_SOURCE -D_FORTIFY_SOURCE=2 -I../../../source/include -DACPI_ASL_COMPILER -I../../../source/compiler -Iobj32 -ansi -Wall -Wbad-function-cast -Wdeclaration-after-statement -Werror -Wformat=2 -Wmissing-declarations -Wmissing-prototypes -Wstrict-aliasing=0 -Wstrict-prototypes -Wswitch-default -Wpointer-arith -Wundef -Waddress -Waggregate-return -Wchar-subscripts -Wempty-body -Wmissing-declarations -Wmissing-field-initializers -Wnested-externs -Wold-style-definition -Wredundant-decls -oobj32/adfile.o ../../../source/common/adfile.c cc1: error: unrecognized command line option "-Wempty-body"
This change doesn't appear to be required for GNU/linuxes.
Change-Id: Ia1d2915257af2a6631b5294b56f0f66b3830af3c Signed-off-by: Idwer Vollering vidwer@gmail.com --- ...nix-20121114_drop_cflags_unknown_to_xcode.patch | 20 --------------- .../acpica-unix-20121114_drop_unknown_cflags.patch | 29 ++++++++++++++++++++++ 2 files changed, 29 insertions(+), 20 deletions(-)
diff --git a/util/crossgcc/patches/acpica-unix-20121114_drop_cflags_unknown_to_xcode.patch b/util/crossgcc/patches/acpica-unix-20121114_drop_cflags_unknown_to_xcode.patch deleted file mode 100644 index a4d55da..0000000 --- a/util/crossgcc/patches/acpica-unix-20121114_drop_cflags_unknown_to_xcode.patch +++ /dev/null @@ -1,20 +0,0 @@ -diff -ur acpica-unix-20121114.orig/generate/unix/Makefile.config acpica-unix-20121114/generate/unix/Makefile.config ---- acpica-unix-20121114.orig/generate/unix/Makefile.config 2012-11-14 08:22:38.000000000 -0800 -+++ acpica-unix-20121114/generate/unix/Makefile.config 2012-12-05 15:53:35.000000000 -0800 -@@ -135,15 +135,11 @@ - -Waggregate-return \ - -Wchar-subscripts \ - -Wempty-body \ -- -Wlogical-op \ - -Wmissing-declarations \ - -Wmissing-field-initializers \ -- -Wmissing-parameter-type \ - -Wnested-externs \ -- -Wold-style-declaration \ - -Wold-style-definition \ -- -Wredundant-decls \ -- -Wtype-limits -+ -Wredundant-decls - - # - # Extra warning flags (possible future use) diff --git a/util/crossgcc/patches/acpica-unix-20121114_drop_unknown_cflags.patch b/util/crossgcc/patches/acpica-unix-20121114_drop_unknown_cflags.patch new file mode 100644 index 0000000..cfc392c --- /dev/null +++ b/util/crossgcc/patches/acpica-unix-20121114_drop_unknown_cflags.patch @@ -0,0 +1,29 @@ +diff -ur acpica-unix-20121114.orig/generate/unix/Makefile.config acpica-unix-20121114/generate/unix/Makefile.config +--- acpica-unix-20121114.orig/generate/unix/Makefile.config 2012-11-14 17:22:38.000000000 +0100 ++++ acpica-unix-20121114/generate/unix/Makefile.config 2013-02-09 17:57:59.000000000 +0100 +@@ -115,7 +115,6 @@ + CWARNINGFLAGS = \ + -ansi \ + -Wall \ +- -Wbad-function-cast \ + -Wdeclaration-after-statement \ + -Werror \ + -Wformat=2 \ +@@ -134,16 +133,11 @@ + -Waddress \ + -Waggregate-return \ + -Wchar-subscripts \ +- -Wempty-body \ +- -Wlogical-op \ + -Wmissing-declarations \ + -Wmissing-field-initializers \ +- -Wmissing-parameter-type \ + -Wnested-externs \ +- -Wold-style-declaration \ + -Wold-style-definition \ +- -Wredundant-decls \ +- -Wtype-limits ++ -Wredundant-decls + + # + # Extra warning flags (possible future use)
-
Idwer Vollering