The following patch fixes the 2 minute lag by marking out the printk_debug() which tries to send information to the serial console but it is not yet enabled - this should be done by another patch...
Signed-off-by: Elia Yehuda z4ziggy@gmail.com
On Mon, Nov 10, 2008 at 4:22 PM, Elia Yehuda z4ziggy@gmail.com wrote:
The following patch fixes the 2 minute lag by marking out the printk_debug() which tries to send information to the serial console but it is not yet enabled - this should be done by another patch...
Signed-off-by: Elia Yehuda z4ziggy@gmail.com
Why not just enable the serial console before enabling SMBus on your target? Also, please try to use more descriptive patch names, ie remove_early_print.patch or so.
-Corey
Corey Osgood wrote:
Why not just enable the serial console before enabling SMBus on your target?
Yes, this was the conclusion on IRC as well. I'd like to avoid committing this patch unless there really is no way to enable serial earlier on the board.
//Peter
On Mon, Nov 10, 2008 at 06:21:16PM -0500, Corey Osgood wrote:
On Mon, Nov 10, 2008 at 4:22 PM, Elia Yehuda z4ziggy@gmail.com wrote:
The following patch fixes the 2 minute lag by marking out the printk_debug() which tries to send information to the serial console but it is not yet enabled - this should be done by another patch...
Signed-off-by: Elia Yehuda z4ziggy@gmail.com
Why not just enable the serial console before enabling SMBus on your target?
Yep, we should do that.
Attached is a patch to fix all boards in v2 accordingly. I don't know if all of them had that delay problem, but it's very likely...
Uwe.
Uwe Hermann wrote:
Always enable serial before SMBus (or as early as possible), as the SMBus enable may do printk()s which result in a 2 minute delay on some boards.
Fix this on all boards which currently do smbus_enable() before enabling the serial console.
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de
Nice!
Acked-by: Peter Stuge peter@stuge.se
Uwe Hermann wrote:
On Mon, Nov 10, 2008 at 06:21:16PM -0500, Corey Osgood wrote:
On Mon, Nov 10, 2008 at 4:22 PM, Elia Yehuda z4ziggy@gmail.com wrote:
The following patch fixes the 2 minute lag by marking out the printk_debug() which tries to send information to the serial console but it is not yet enabled - this should be done by another patch...
Signed-off-by: Elia Yehuda z4ziggy@gmail.com
Why not just enable the serial console before enabling SMBus on your target?
Yep, we should do that.
Attached is a patch to fix all boards in v2 accordingly. I don't know if all of them had that delay problem, but it's very likely...
I remember seeing similar delays on the Epia-M occasionally. Good work!
'nother Acked-by: Stefan Reinauer stepan@coresystems.de
On Tue, Nov 11, 2008 at 01:08:16AM +0100, Stefan Reinauer wrote:
Why not just enable the serial console before enabling SMBus on your target?
Yep, we should do that.
Attached is a patch to fix all boards in v2 accordingly. I don't know if all of them had that delay problem, but it's very likely...
I remember seeing similar delays on the Epia-M occasionally. Good work!
'nother Acked-by: Stefan Reinauer stepan@coresystems.de
Thanks, r3742. Thanks again to Elia for finding this bug!
Uwe.
On Tue, 11 Nov 2008 00:47:08 +0100, Uwe Hermann uwe@hermann-uwe.de wrote:
On Mon, Nov 10, 2008 at 06:21:16PM -0500, Corey Osgood wrote:
On Mon, Nov 10, 2008 at 4:22 PM, Elia Yehuda z4ziggy@gmail.com wrote:
The following patch fixes the 2 minute lag by marking out the printk_debug() which tries to send information to the serial console but it is not yet enabled - this should be done by another patch...
Signed-off-by: Elia Yehuda z4ziggy@gmail.com
Why not just enable the serial console before enabling SMBus on your
target?
Yep, we should do that.
Attached is a patch to fix all boards in v2 accordingly. I don't know if all of them had that delay problem, but it's very likely...
Thanks Uwe. I didn't have this problem ont the RM4100 or IP1000, but hey it may speed up the boot time a little :-)
-
Corey Osgood -
Elia Yehuda -
Joseph Smith -
Peter Stuge -
Stefan Reinauer -
Uwe Hermann