I need to add some functions in early_setup.c of southbridge, sb700, for example. But some other mainboards don't use those functions. Given the Werror in Makefile, I can't make these 2 cases pass the compiling both. What is the resolution? Do I have to add a configuration in mainboard Kconfig for such a trivial function?
Zheng
Bao, Zheng wrote:
I need to add some functions in early_setup.c of southbridge, sb700, for example. But some other mainboards don't use those functions. Given the Werror in Makefile, I can't make these 2 cases pass the compiling both.
You mean to add a function in sb700 early_setup.c that will not be called in some mainboards, but will be used in other mainboards, right? I would expect that to work without errors. Can you show an example and the error message you encounter?
//Peter
I've got the way to handle it. Thanks.
Zheng
-----Original Message----- From: coreboot-bounces@coreboot.org
[mailto:coreboot-bounces@coreboot.org]
On Behalf Of Peter Stuge Sent: Thursday, January 20, 2011 11:16 AM To: coreboot@coreboot.org Subject: Re: [coreboot] what if some mainboard use that function,
others
dont
Bao, Zheng wrote:
I need to add some functions in early_setup.c of southbridge, sb700,
for
example. But some other mainboards don't use those functions. Given
the
Werror in Makefile, I can't make these 2 cases pass the compiling
both.
You mean to add a function in sb700 early_setup.c that will not be called in some mainboards, but will be used in other mainboards, right? I would expect that to work without errors. Can you show an example and the error message you encounter?
//Peter
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
-
Bao, Zheng -
Peter Stuge