+#define BIN2HEX(b) ("0123456789abcdef"[b & 15]) +#define HEX2BIN(h) (('0' <= h && h <= '9') ? (h - '0') : \
('a' <= h && h <= 'f') ? (h - 'a' + 10) : 0)
These macros are unsafe: lack of parentheses around the uses of the parameters, and multiple evaluation in the second macro.
Please consider using an inline function instead (or a "real" function, to make code size smaller).
Btw, could the SVN checkin list be set up with a followup-to: header?
Segher
On 04.04.2008 22:08, Segher Boessenkool wrote:
+#define BIN2HEX(b) ("0123456789abcdef"[b & 15]) +#define HEX2BIN(h) (('0' <= h && h <= '9') ? (h - '0') : \
('a' <= h && h <= 'f') ? (h - 'a' + 10) : 0)These macros are unsafe: lack of parentheses around the uses of the parameters, and multiple evaluation in the second macro.
Please consider using an inline function instead (or a "real" function, to make code size smaller).
Btw, could the SVN checkin list be set up with a followup-to: header?
Could we please change the Followup-To (standardized for newsgroups only) to Reply-To (standardized for mail)?
Thanks. Carl-Daniel
Btw, could the SVN checkin list be set up with a followup-to: header?
Could we please change the Followup-To (standardized for newsgroups only) to Reply-To (standardized for mail)?
I meant mail-followup-to:. If reply-to: does the right thing, fine by me, I don't pretend to understand email headers :-)
Segher
On Mon, Apr 07, 2008 at 10:43:26PM +0200, Segher Boessenkool wrote:
Btw, could the SVN checkin list be set up with a followup-to: header?
Could we please change the Followup-To (standardized for newsgroups only) to Reply-To (standardized for mail)?
I meant mail-followup-to:. If reply-to: does the right thing,
I don't think it does.
Neither header should be added automatically by the list, IMO.
fine by me, I don't pretend to understand email headers :-)
Please see http://www.unicom.com/pw/reply-to-harmful.html http://cr.yp.to/proto/replyto.html (also covers Mail-Followup-To)
//Peter
On 07.04.2008 23:12, Peter Stuge wrote:
On Mon, Apr 07, 2008 at 10:43:26PM +0200, Segher Boessenkool wrote:
Btw, could the SVN checkin list be set up with a followup-to: header?
Could we please change the Followup-To (standardized for newsgroups only) to Reply-To (standardized for mail)?
I meant mail-followup-to:. If reply-to: does the right thing,
I don't think it does.
Neither header should be added automatically by the list, IMO.
We are not talking about the list, but about the mails generated by svn. They have "From: svn@coreboot.org" and it would be nice if replies to svn commit mails ended up on the list.
fine by me, I don't pretend to understand email headers :-)
Please see http://www.unicom.com/pw/reply-to-harmful.html http://cr.yp.to/proto/replyto.html (also covers Mail-Followup-To)
Does not apply. See above.
Regards, Carl-Daniel
On Mon, Apr 07, 2008 at 11:16:45PM +0200, Carl-Daniel Hailfinger wrote:
Btw, could the SVN checkin list be set up with a followup-to: header?
..
We are not talking about the list, but about the mails generated by svn.
Ah, ok.
They have "From: svn@coreboot.org" and it would be nice if replies to svn commit mails ended up on the list.
I really like to point out the list-reply command, but for those who still lack list-reply in their mailers (Thunderbird has a plugin[1]) a Mail-Followup-To with the list address could be added to those messages (and those messages only) before they're sent to the list.
Please see http://www.unicom.com/pw/reply-to-harmful.html http://cr.yp.to/proto/replyto.html (also covers Mail-Followup-To)
Does not apply. See above.
Still does I think, both pages mention how and when the various headers are supposed to be used, and when not to use them.
//Peter
[1] http://alumnit.ca/wiki/index.php?page=ReplyToListThunderbirdExtension
On 07.04.2008 23:30, Peter Stuge wrote:
On Mon, Apr 07, 2008 at 11:16:45PM +0200, Carl-Daniel Hailfinger wrote:
Btw, could the SVN checkin list be set up with a followup-to: header?
..
We are not talking about the list, but about the mails generated by svn.
Ah, ok.
They have "From: svn@coreboot.org" and it would be nice if replies to svn commit mails ended up on the list.
I really like to point out the list-reply command, but for those who still lack list-reply in their mailers (Thunderbird has a plugin[1]) a Mail-Followup-To with the list address could be added to those messages (and those messages only) before they're sent to the list.
I vehemently oppose Mail-Followup-To: for svn mails. It has never reached official RFC status and the abandoned(!) RFC draft for it (draft-ietf-drums-mail-followup-to-00) explicitly specifies: 'The "Mail-Followup-To" contains a suggestion to the recipient of where to send group replies'. This means the purpose of Mail-Followup-To: is explicitly not intended for mails where a reply should always go to an address different from the one in the From: header.
Please see http://www.unicom.com/pw/reply-to-harmful.html http://cr.yp.to/proto/replyto.html (also covers Mail-Followup-To)
Does not apply. See above.
Still does I think, both pages mention how and when the various headers are supposed to be used, and when not to use them.
Both sites are very careful not to point to actual RFCs for their arguments and the second site fails to mention that Mail-Followup-To: is an abandoned effort. IMO Mail-Followup-To: has a value similar to that of JScript (yes, the Microsoft JavaScript Frankenstein monster).
[1] http://alumnit.ca/wiki/index.php?page=ReplyToListThunderbirdExtension
Thanks for the pointer, but unfortunately this does not work for seamonkey. Besides that, I like getting copies of mails I should read.
Regards, Carl-Daniel
-
Carl-Daniel Hailfinger -
Peter Stuge -
Segher Boessenkool