flashrom: some cleanup

[Mateusz Murawski]

Hi
Some work from http://www.coreboot.org/Easy_projects

[Carl-Daniel Hailfinger]

Hi Mateusz,

thanks for the patch.

On 12.06.2009 01:48, Mateusz Murawski wrote:
> Some work from http://www.coreboot.org/Easy_projects

I'd apply the patch immediately, but the nature of flashchips.c is that
some hunks repeat, so it is impossible to find out if the correct
locations are patched. Could you please regenerate the patch with
svn diff -x -U6
or if the above does not work
svn diff --diff-cmd diff -x -U6

Please also add a Signed-off-by statement.
http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure

Thanks!

Regards,
Carl-Daniel

[Mateusz Murawski]

-------- Original Message  --------
Subject: Re: [coreboot] flashrom: some cleanup
From: Carl-Daniel Hailfinger 
To: Mateusz Murawski 
Date: 12 czerwiec 2009 09:33:18
> Hi Mateusz,
>
> thanks for the patch.

No problem.
> On 12.06.2009 01:48, Mateusz Murawski wrote:
> > Some work from http://www.coreboot.org/Easy_projects
>
> I'd apply the patch immediately, but the nature of flashchips.c is that
> some hunks repeat, so it is impossible to find out if the correct
> locations are patched. Could you please regenerate the patch with
> svn diff -x -U6
> or if the above does not work
> svn diff --diff-cmd diff -x -U6
>
> Please also add a Signed-off-by statement.
> http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure

Signed-off-by: Mateusz Murawski

[Carl-Daniel Hailfinger]

On 12.06.2009 13:17, Mateusz Murawski wrote:
> Signed-off-by: Mateusz Murawski

Acked-by: Carl-Daniel Hailfinger

I fixed compilation (#defines are not allowed to start with a number)
and committed the resulting patch in r584

Regards,
Carl-Daniel

flashrom: some cleanup, part2

[Mateusz Murawski]

-------- Original Message  --------
Subject: bt
From: Waldemar Truszkowski 
To: matowy @ o2 
Date: 12 czerwiec 2009 19:56:06
> Hi
> Some work from http://www.coreboot.org/Easy_projects

flashrom: some cleanup, part2

[Carl-Daniel Hailfinger]

On 12.06.2009 21:31, Mateusz Murawski wrote:
> -------- Original Message  --------
> Subject: bt
> From: Waldemar Truszkowski 
> To: matowy @ o2 
> Date: 12 czerwiec 2009 19:56:06
> > Hi
> > Some work from http://www.coreboot.org/Easy_projects

Thanks! Looks good, can be applied.
Can I have a Signed-off-by statement from Waldemar?

Regards,
Carl-Daniel

flashrom: some cleanup, part2

[Mateusz Murawski]

-------- Original Message  --------
Subject: Re: [coreboot] flashrom: some cleanup, part2
From: Carl-Daniel Hailfinger 
To: Mateusz Murawski 
Date: 12 czerwiec 2009 22:22:47
> > > Some work from http://www.coreboot.org/Easy_projects
>
> Thanks! Looks good, can be applied.
> Can I have a Signed-off-by statement from Waldemar?

Heh, no, but you can from me.
Signed-off-by: Mateusz Murawski

I forgot my patch from work, and friend send it to me :)

flashrom: some cleanup, part2

[Carl-Daniel Hailfinger]

On 12.06.2009 22:48, Mateusz Murawski wrote:
> Signed-off-by: Mateusz Murawski

Thanks for the patch.

Acked-by: Carl-Daniel Hailfinger 
and committed in r588.

Regards,
Carl-Daniel